From patchwork Thu May 19 06:51:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 68093 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp3032868qge; Wed, 18 May 2016 23:53:23 -0700 (PDT) X-Received: by 10.28.18.11 with SMTP id 11mr11190591wms.51.1463640803056; Wed, 18 May 2016 23:53:23 -0700 (PDT) Return-Path: Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id v9si15790192wjw.43.2016.05.18.23.53.22; Wed, 18 May 2016 23:53:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 86732A767E; Thu, 19 May 2016 08:52:56 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OtufbKeSWTEN; Thu, 19 May 2016 08:52:56 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E6A8DA7611; Thu, 19 May 2016 08:52:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0C62BA74E3 for ; Thu, 19 May 2016 08:51:32 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GvdEiLlh9_Ff for ; Thu, 19 May 2016 08:51:31 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from conuserg-12.nifty.com (conuserg-12.nifty.com [210.131.2.79]) by theia.denx.de (Postfix) with ESMTPS id 216B3A74E9 for ; Thu, 19 May 2016 08:51:26 +0200 (CEST) Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id u4J6p2Zg001067; Thu, 19 May 2016 15:51:04 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com u4J6p2Zg001067 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1463640665; bh=ht0L4sABK5lE1+6EKydOlO0auRGSsrr7+ngcydXbKYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cYs7gx6I5bP3QBRxLbV8anxPZnfb753MFJbh3JLC3Wm4RVYwp/y+i1HKjVGFbwYfW UxUYqsw60cQ85goCEfDicLvF5MqMv/rjpXTF+T1STDxsZIZ4Ys2DDfXPlP5l91CRJx YzqG1eGWdWtr/ot1SMi4NM1Z5U7wd3aAZ/Tc5pQ9wFHR4XJaTq5Vj97ymnrYuM9KvX u2WVgtSjWhMc1I3nQRP5n2SUB5BXzbb5VYAsgG1kuiFbzKey1KQs7S/M6CWRb22DBI 4BBCHtGEd16Qi83j0LnfmOLYgQXBarBfRlzrSblC8NaDdCw3+cdLxjADqJhjw9VWVT +j48hO/GblbgA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: u-boot@lists.denx.de Date: Thu, 19 May 2016 15:51:51 +0900 Message-Id: <1463640729-25666-4-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1463640729-25666-1-git-send-email-yamada.masahiro@socionext.com> References: <1463640729-25666-1-git-send-email-yamada.masahiro@socionext.com> Cc: Joe Hershberger Subject: [U-Boot] [PATCH 03/21] tools: moveconfig: remove redundant else: after sys.exit() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Nesting by "else:" is not generally useful after such statements as return, break, and sys.exit(), etc. Signed-off-by: Masahiro Yamada --- tools/moveconfig.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) -- 1.9.1 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 9029287..1332bd2 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -623,13 +623,11 @@ class Slot: COLOR_LIGHT_CYAN, errout) if self.options.exit_on_error: sys.exit("Exit on error.") - else: - # If --exit-on-error flag is not set, - # skip this board and continue. - # Record the failed board. - self.failed_boards.append(self.defconfig) - self.state = STATE_IDLE - return True + # If --exit-on-error flag is not set, skip this board and continue. + # Record the failed board. + self.failed_boards.append(self.defconfig) + self.state = STATE_IDLE + return True if self.state == STATE_AUTOCONF: self.parser.update_dotconfig(self.defconfig)