From patchwork Tue Apr 21 13:35:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 47396 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3731020553 for ; Tue, 21 Apr 2015 13:36:15 +0000 (UTC) Received: by wgiv13 with SMTP id v13sf45017891wgi.3 for ; Tue, 21 Apr 2015 06:36:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=SdJycVwbCjcwenucT9NFZCCI2TLcLb2o0KCdPesYUGA=; b=MjbHbTlDVfGvNklXdtyeU6e3/x2AOGtQa5RsVyK31T8xteYzPoh3Akz+l2sSiR1tlk ZDZ7SQselwiv8MzuFaIOk7+p6uvw/ajQPcPGTOKPsGVOYYzkeKUMbIq0AQmPQLEgPtC2 MF6Q+qsvs27TcCUe+zZDG0xhiTJRmQ6ZYVCBo7HwGE8RDSAb8vSCdc54DKSig10RTNtp 40vL7L5KgHU+yplxM4giO5hDur3jh3maULdLRL7AUDqnpqkoYTlFrM1LCd/6AdHqaT1+ BDKMYU7HFr6IB74lVQ6rzb3Ws5dmaPbQnCYaCQ47k90yeCR2R5sAYQYYbj3LQR9rsVUr tzyw== X-Gm-Message-State: ALoCoQkxlc7aQUJ8Rtz4zHKWljc9+Y8Dxamzrialx3LywkxOkWevIE8YjFhzdnduskfUyLG5KyV7 X-Received: by 10.112.118.162 with SMTP id kn2mr9499768lbb.22.1429623374304; Tue, 21 Apr 2015 06:36:14 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.29.169 with SMTP id l9ls48084lah.52.gmail; Tue, 21 Apr 2015 06:36:14 -0700 (PDT) X-Received: by 10.112.13.233 with SMTP id k9mr15842435lbc.57.1429623374093; Tue, 21 Apr 2015 06:36:14 -0700 (PDT) Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com. [209.85.217.177]) by mx.google.com with ESMTPS id h19si1366314lbo.102.2015.04.21.06.36.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2015 06:36:14 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) client-ip=209.85.217.177; Received: by lbcga7 with SMTP id ga7so155961062lbc.1 for ; Tue, 21 Apr 2015 06:36:14 -0700 (PDT) X-Received: by 10.112.163.168 with SMTP id yj8mr20103950lbb.36.1429623374006; Tue, 21 Apr 2015 06:36:14 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp639656lbt; Tue, 21 Apr 2015 06:36:13 -0700 (PDT) X-Received: by 10.194.23.66 with SMTP id k2mr2681418wjf.18.1429623373340; Tue, 21 Apr 2015 06:36:13 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id p14si3735528wiv.47.2015.04.21.06.36.12; Tue, 21 Apr 2015 06:36:13 -0700 (PDT) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C80BB3937; Tue, 21 Apr 2015 15:36:10 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kWaghHfREGfM; Tue, 21 Apr 2015 15:36:10 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 169B1B37B5; Tue, 21 Apr 2015 15:36:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 64414B37B5 for ; Tue, 21 Apr 2015 15:36:08 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wjPkN83f6raj for ; Tue, 21 Apr 2015 15:36:08 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by theia.denx.de (Postfix) with ESMTPS id 27317B37B2 for ; Tue, 21 Apr 2015 15:36:04 +0200 (CEST) Received: by layy10 with SMTP id y10so151269696lay.0 for ; Tue, 21 Apr 2015 06:36:04 -0700 (PDT) X-Received: by 10.112.219.201 with SMTP id pq9mr20291695lbc.109.1429623364205; Tue, 21 Apr 2015 06:36:04 -0700 (PDT) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id xq2sm397704lbb.49.2015.04.21.06.36.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2015 06:36:03 -0700 (PDT) From: Linus Walleij To: u-boot@lists.denx.de, Albert Aribaud , Tom Rini , Simon Glass Date: Tue, 21 Apr 2015 15:35:59 +0200 Message-Id: <1429623359-32618-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.9.3 Cc: Steve Rae , u-boot-review@google.com Subject: [U-Boot] [PATCH 1/2] integrator: stop zeroing the gd flags X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 This assignment conflicts with code that add flags with gd->flags |= FOO prior to the execution of this function. Seems like a historical artifact and creates bugs with early alloc(). Cc: Masahiro Yamada Signed-off-by: Linus Walleij --- board/armltd/integrator/integrator.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c index f0fe0fd3aabe..e94ac850c751 100644 --- a/board/armltd/integrator/integrator.c +++ b/board/armltd/integrator/integrator.c @@ -54,8 +54,6 @@ int board_init (void) /* adress of boot parameters */ gd->bd->bi_boot_params = 0x00000100; - gd->flags = 0; - #ifdef CONFIG_CM_REMAP extern void cm_remap(void); cm_remap(); /* remaps writeable memory to 0x00000000 */