From patchwork Tue Sep 23 15:07:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 37735 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 446A820970 for ; Tue, 23 Sep 2014 15:07:52 +0000 (UTC) Received: by mail-wi0-f199.google.com with SMTP id hi2sf2645079wib.2 for ; Tue, 23 Sep 2014 08:07:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=uensQRhdTvcEfT4k2CbzpmB/boncvTsM1i4IzAZlDQM=; b=fbCBcN0aHF3Pt7ldjlt1ybQautcSNOfF3u46xmnZxZe09n9v4dvYMWIzel+AnNhkYa 0u5Znxv+RmJhPdqJjXXKuDOcEywD7k71d3MpNV2o+vMLT6txOWjn/MDJKIPuRC26oiIh fUk+bDs4yDylRpUJgKY3PYrJwEK0B1VTrbJHkU0C8TzDiHSMnQ0XQG40V9SSsYfJa2x7 Mhs2M3RF0RZBFiCPz3HlFntxmkJ7vf9iHMQWZMjJ08JR1M8zTiWJksxZYCb98q+OZsiP RcFnbIjf+Swu5DxT/Jpb4xMCaTIZL38O/xwvI22iUjw1xcwM8aVuXye+65a8f+TT2txs pmLw== X-Gm-Message-State: ALoCoQltlvwwWjexufAZKYIBi3tuhhyQwW0qVCPgL3ElyoMPovgUImltcXZbCO+64FcQKUtUUGzn X-Received: by 10.112.118.8 with SMTP id ki8mr66239lbb.4.1411484871447; Tue, 23 Sep 2014 08:07:51 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.1.40 with SMTP id 8ls55425laj.65.gmail; Tue, 23 Sep 2014 08:07:51 -0700 (PDT) X-Received: by 10.152.20.1 with SMTP id j1mr72807lae.57.1411484871032; Tue, 23 Sep 2014 08:07:51 -0700 (PDT) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by mx.google.com with ESMTPS id pk5si19063789lbb.60.2014.09.23.08.07.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Sep 2014 08:07:50 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by mail-lb0-f178.google.com with SMTP id z12so6433271lbi.9 for ; Tue, 23 Sep 2014 08:07:50 -0700 (PDT) X-Received: by 10.112.53.230 with SMTP id e6mr181908lbp.100.1411484870921; Tue, 23 Sep 2014 08:07:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp428880lbb; Tue, 23 Sep 2014 08:07:50 -0700 (PDT) X-Received: by 10.180.9.232 with SMTP id d8mr3556081wib.77.1411484870331; Tue, 23 Sep 2014 08:07:50 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id ct5si15474476wjb.7.2014.09.23.08.07.49 for ; Tue, 23 Sep 2014 08:07:50 -0700 (PDT) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C2A7DA744B; Tue, 23 Sep 2014 17:07:44 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Umg5jXvgAizB; Tue, 23 Sep 2014 17:07:44 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id CCF55A73EF; Tue, 23 Sep 2014 17:07:33 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4B0D9A7401 for ; Tue, 23 Sep 2014 17:07:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CxQX-h6aCTeU for ; Tue, 23 Sep 2014 17:07:27 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by theia.denx.de (Postfix) with ESMTPS id 04BBBA73EA for ; Tue, 23 Sep 2014 17:07:23 +0200 (CEST) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s8NF7CIn012338; Tue, 23 Sep 2014 10:07:12 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8NF7CRS015393; Tue, 23 Sep 2014 10:07:12 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Tue, 23 Sep 2014 10:07:11 -0500 Received: from localhost.localdomain (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s8NF76Tb017458; Tue, 23 Sep 2014 10:07:09 -0500 From: Roger Quadros To: Date: Tue, 23 Sep 2014 18:07:01 +0300 Message-ID: <1411484824-27265-2-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1411484824-27265-1-git-send-email-rogerq@ti.com> References: <1411484824-27265-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Cc: u-boot@lists.denx.de, ijc@hellion.org.uk, Roger Quadros Subject: [U-Boot] [PATCH 1/4] ahci: Don't start command DMA engine before buffers are set X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: rogerq@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The DMA/FIS buffers are set in ahci_port_start() which is called after ahci_host_init(). So don't start the DMA engine here (i.e. don't set FIS_RX) This fixes the following error at kernel boot on OMAP platforms (e.g. DRA7x) WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x260/0x358() 44000000.ocp:L3 Custom Error: MASTER SATA TARGET GPMC (Idle): Data Access in User mode during Functional access Signed-off-by: Roger Quadros --- drivers/block/ahci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c index dce99ad..a93a8e1 100644 --- a/drivers/block/ahci.c +++ b/drivers/block/ahci.c @@ -229,7 +229,6 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent) * already be on in the command register. */ cmd = readl(port_mmio + PORT_CMD); - cmd |= PORT_CMD_FIS_RX; cmd |= PORT_CMD_SPIN_UP; writel_with_flush(cmd, port_mmio + PORT_CMD);