From patchwork Thu May 23 13:15:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajeshwari Shinde X-Patchwork-Id: 17125 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f200.google.com (mail-ve0-f200.google.com [209.85.128.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 599602395B for ; Thu, 23 May 2013 13:08:45 +0000 (UTC) Received: by mail-ve0-f200.google.com with SMTP id m1sf4439302ves.3 for ; Thu, 23 May 2013 06:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:x-forwarded-to:x-forwarded-for :delivered-to:x-auditid:from:to:cc:subject:date:message-id:x-mailer :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=LuT3Fc7584PPxhbPqO9C2Yzq6taVQv2HiLT2Vdj2ZGY=; b=a7tUZ8ifiSqdLwaKmDioZqcVnn/vyVgBPzLRPVel7Vl5HJLBZiwXc7ySX/TnGtvYUi bTSRIEOHaLvmSGh9ncHBJwO5X0YSilFL5Dqv0AQwDe258cXw3s2YU931iPVQ/GZr3bRA Aew7GW7gzg3dwlenKoClWomjHR+IJ7pDn88mBgX26Ze6vk3P68U9apVvUiSsW3vG9lgc eALQpD+wEJxo2hiMeL/63+XjfxQefLeUIXXOWToSMgnhNBFT0H3k3+CzSPWfBZSiKH82 HVXmdTgZNiqhiOHJF6RR1YUTrEcqIb9V2kejBDdYdNBmgF686pKDrcZrV3fOqFWiW3pf g2Vw== X-Received: by 10.236.139.67 with SMTP id b43mr6261168yhj.26.1369314470171; Thu, 23 May 2013 06:07:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.0.78 with SMTP id 14ls1459604qec.10.gmail; Thu, 23 May 2013 06:07:50 -0700 (PDT) X-Received: by 10.52.16.105 with SMTP id f9mr698323vdd.101.1369314469969; Thu, 23 May 2013 06:07:49 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id mr2si6276549vcb.56.2013.05.23.06.07.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 May 2013 06:07:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id ha11so2124426vcb.7 for ; Thu, 23 May 2013 06:07:49 -0700 (PDT) X-Received: by 10.52.34.114 with SMTP id y18mr4376187vdi.56.1369314469813; Thu, 23 May 2013 06:07:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.126.138 with SMTP id c10csp50497vcs; Thu, 23 May 2013 06:07:49 -0700 (PDT) X-Received: by 10.66.159.168 with SMTP id xd8mr13127030pab.146.1369314468686; Thu, 23 May 2013 06:07:48 -0700 (PDT) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by mx.google.com with ESMTP id mr7si9051882pbb.77.2013.05.23.06.07.48 for ; Thu, 23 May 2013 06:07:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of rajeshwari.s@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MN9001JL5SZ0Q30@mailout2.samsung.com> for patches@linaro.org; Thu, 23 May 2013 22:07:47 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id D7.78.29708.3A41E915; Thu, 23 May 2013 22:07:47 +0900 (KST) X-AuditID: cbfee690-b7f6f6d00000740c-e4-519e14a34c06 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B8.34.28381.2A41E915; Thu, 23 May 2013 22:07:47 +0900 (KST) Received: from rajeshwari-linux.sisodomain.com ([107.108.215.115]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MN900HFK5RGLZ70@mmp2.samsung.com>; Thu, 23 May 2013 22:07:46 +0900 (KST) From: Rajeshwari Shinde To: u-boot@lists.denx.de Cc: patches@linaro.org, sjg@chromium.org, mk7.kang@samsung.com, afleming@gmail.com, jh80.chung@samsung.com, jagannadh.teki@gmail.com, u-boot-review@google.com Subject: [PATCH] MMC: DWMMC: Fix FIFO_DEPTH calculation Date: Thu, 23 May 2013 18:45:00 +0530 Message-id: <1369314900-16412-1-git-send-email-rajeshwari.s@samsung.com> X-Mailer: git-send-email 1.7.4.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsWyRsSkTnexyLxAg63neSxuXP/JZrFrawur xY1fbawWHUdaGC2mHP7CYvFtyzZGi+WvN7JbvN3bye7A4TG74SKLx85Zd9k9Fmwq9bhzbQ+b x9k7Oxg9+rasYgxgi+KySUnNySxLLdK3S+DKuPbSs2AfZ8XLDd+YGxjfsHcxcnJICJhIPJ88 kQnCFpO4cG89WxcjF4eQwFJGiZVHJrPAFZ27wgqRmM4o0XbiIDNIQkhgIpPE/39GIDabgJHE 1pPTGEFsEQEJiV/9VxlBGpgFFjFKbNv8gA0kISxgLjH91muwZhYBVYllbUvBGngFPCQm7rvM CLFNQeLY1K9g2yQEJrNLXGm4xgbRICDxbfIhoJM4gBKyEpsOMEPUS0ocXHGDZQKj4AJGhlWM oqkFyQXFSelFJnrFibnFpXnpesn5uZsYgaF8+t+zCTsY7x2wPsSYDDRuIrOUaHI+MBbySuIN jc2MLExNTI2NzC3NSBNWEudVb7EOFBJITyxJzU5NLUgtii8qzUktPsTIxMEp1cA4VygoUtE8 pXBjr9GBmy2mTbIrQgonzO46sSJna+jiRcce7lhpczHyZKmVdnuK2rPcDZJ6QTO/lmzicJQ2 NlUrE2TNVFq+WPTnv1zftQz5Bl3FUlzJPq075Voz3f5nHUjnSbLv1/pVERGwzYLncem8sm7t qvPJ1gmb+f8HOSdf15vwrsN3jhJLcUaioRZzUXEiABmvbsR7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t9jQd3FIvMCDa6dYLa4cf0nm8WurS2s Fjd+tbFadBxpYbSYcvgLi8W3LdsYLZa/3shu8XZvJ7sDh8fshossHjtn3WX3WLCp1OPOtT1s Hmfv7GD06NuyijGALaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfV VsnFJ0DXLTMH6CIlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8a1l54F +zgrXm74xtzA+Ia9i5GTQ0LAROL5uSusELaYxIV769m6GLk4hASmM0q0nTjIDJIQEpjIJPH/ nxGIzSZgJLH15DRGEFtEQELiV/9VRpAGZoFFjBLbNj9gA0kIC5hLTL/1GqyZRUBVYlnbUrAG XgEPiYn7LjNCbFOQODb1K+sERu4FjAyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYIj5ZnU DsaVDRaHGAU4GJV4eCVuzwkUYk0sK67MPcQowcGsJMK7uWduoBBvSmJlVWpRfnxRaU5q8SHG ZKDtE5mlRJPzgVGcVxJvaGxibmpsamliYWJmSZqwkjjvgVbrQCGB9MSS1OzU1ILUIpgtTByc Ug2MtfKv2n0Mhfdz2wXlZknPOycz8YBBZMZMg/63Sb/m1r+bZh5ucqyovjZw2ZQFgXVixkUX l8dIdF1rizwgN5HxIP/8zTZmKUbdZ8wZDv3/P/Xw0t4thy79nLmh8k/f0crT3XMFGWYb5dfx PFzaUuJzeGvxV/v+jANGLfodKd0TSkQfzfHQOZOpxFKckWioxVxUnAgAl4ENjdgCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Gm-Message-State: ALoCoQmPI6TcZlq4BeMbnhC8Tw/jyPVy4Ll9ps252abrAo1V5nizUnnvvfV2E8VBAzkKjf4j9OCp X-Original-Sender: rajeshwari.s@samsung.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Current DWMMC driver used to give FIFO underrun/overrun error every 3rd time for mmc rescan command. In current code FIFO_DEPTH is getting calculated after reading the FIFOTH register and extracting the RX_WMARK bits from it i.e (RX_WMARK = FIFO_DEPTH/2 -1). Instead of storing the correct value, we were recalculating the FIFO_DEPT each time which is not correct. Signed-off-by: Hatim Ali Signed-off-by: Rajeshwari Shinde Reviewed-by: Alim Akhtar Acked-by: Jaehoon Chung --- drivers/mmc/dw_mmc.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 4070d4e..be590a4 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -332,11 +332,13 @@ static int dwmci_init(struct mmc *mmc) dwmci_writel(host, DWMCI_BMOD, 1); fifo_size = dwmci_readl(host, DWMCI_FIFOTH); - if (host->fifoth_val) + if (host->fifoth_val) { fifoth_val = host->fifoth_val; - else + } else { fifoth_val = MSIZE(0x2) | RX_WMARK(fifo_size/2 -1) | TX_WMARK(fifo_size/2); + host->fifoth_val = fifoth_val; + } dwmci_writel(host, DWMCI_FIFOTH, fifoth_val); dwmci_writel(host, DWMCI_CLKENA, 0);