From patchwork Sat Apr 27 06:12:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amar X-Patchwork-Id: 16459 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f70.google.com (mail-vb0-f70.google.com [209.85.212.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8208324AAB for ; Sat, 27 Apr 2013 06:10:14 +0000 (UTC) Received: by mail-vb0-f70.google.com with SMTP id e13sf1633776vbg.9 for ; Fri, 26 Apr 2013 23:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-auditid:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-brightmail-tracker:x-brightmail-tracker :dlp-filter:x-mtr:x-cfilter-loop:x-gm-message-state :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-google-group-id:list-post:list-help :list-archive:list-unsubscribe; bh=x0OGxHP+nZDpkgL7ps+Nlsi4smilu0IXMuC4SjTmxMA=; b=WcWmTJrf11/aWBVWxtn/2sxpTl/zrfEVJwMpFEA67cnSQ0Mo87l+umKj4uPA9m57nX wSkoysEWnDqQeo23d58BKQ/qXiPRtabR15OA0CiS58yYDGW8KgreH0DQ4sxepOoDagg7 J5NmJf1O1g270RbvDN/JODR0Fvt8Xo2/EziW1Cqm3NCNqCw7VI6fVcuXo5oHtVvOJAJH gHSGSlR10TsGOQ3mfqZGsTulS6avfWcsWwYYkpV2DHMvEkaaG5PPXN+cymlXl+Svk+Hv 1RhWzI1+7jz6ff+RkvtPPAR87ttktRBsyoNrxkEVwG8RMxz77zHuxuhLIirc41y0sjCx GJkg== X-Received: by 10.224.215.194 with SMTP id hf2mr32570412qab.0.1367042957279; Fri, 26 Apr 2013 23:09:17 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.130.74 with SMTP id oc10ls2248411qeb.53.gmail; Fri, 26 Apr 2013 23:09:17 -0700 (PDT) X-Received: by 10.52.73.165 with SMTP id m5mr25919447vdv.5.1367042957026; Fri, 26 Apr 2013 23:09:17 -0700 (PDT) Received: from mail-vb0-x236.google.com (mail-vb0-x236.google.com [2607:f8b0:400c:c02::236]) by mx.google.com with ESMTPS id ff9si6702888vcb.37.2013.04.26.23.09.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Apr 2013 23:09:17 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::236 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::236; Received: by mail-vb0-f54.google.com with SMTP id w16so4125372vbf.13 for ; Fri, 26 Apr 2013 23:09:16 -0700 (PDT) X-Received: by 10.52.163.231 with SMTP id yl7mr25691026vdb.57.1367042956862; Fri, 26 Apr 2013 23:09:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp96731veb; Fri, 26 Apr 2013 23:09:16 -0700 (PDT) X-Received: by 10.66.248.68 with SMTP id yk4mr28824256pac.137.1367042955880; Fri, 26 Apr 2013 23:09:15 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by mx.google.com with ESMTP id ie7si1798548pbc.129.2013.04.26.23.09.15 for ; Fri, 26 Apr 2013 23:09:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of amarendra.xt@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLW003ZEH3DLXA0@mailout4.samsung.com>; Sat, 27 Apr 2013 15:09:14 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.122]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id E1.29.31024.A8B6B715; Sat, 27 Apr 2013 15:09:14 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-7c-517b6b8af03e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 3E.18.08957.A8B6B715; Sat, 27 Apr 2013 15:09:14 +0900 (KST) Received: from amarendra-desktop.sisodomain.com ([107.108.73.18]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MLW00DPDH2TOT50@mmp2.samsung.com>; Sat, 27 Apr 2013 15:09:14 +0900 (KST) From: amar_g To: u-boot@lists.denx.de, jh80.chung@samsung.com Cc: patches@linaro.org, sjg@chromium.org, mk7.kang@samsung.com, chander.kashyap@linaro.org, afleming@gmail.com, hs@denx.de, Amar Subject: [PATCH V9 5/9] EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results. Date: Sat, 27 Apr 2013 11:42:56 +0530 Message-id: <1367043180-6756-6-git-send-email-amarendra.xt@samsung.com> X-Mailer: git-send-email 1.7.3.rc2 In-reply-to: <1367043180-6756-1-git-send-email-amarendra.xt@samsung.com> References: <1367043180-6756-1-git-send-email-amarendra.xt@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42JZI2JSpduVXR1o0HdSwuLG9Z9sFl8WdLJb PFx/k8Vix537zBY3frWxWnQcaWG0mHL4C4vFty3bGC3e7u1kd+D0mN1wkcVj3qwTLB47Z91l 97hzbQ+bx9k7Oxg9+rasYgxgi+KySUnNySxLLdK3S+DKuLTmBWvBIoGK9Ue3MDUwruHtYuTk kBAwkZjVcYEZwhaTuHBvPVsXIxeHkMBSRonVD66wdjFygBVdvCIBEZ/OKLH/8RomkAYhgQlM Eqd2J4DYbALqEk8+rWUFsUUEDCSmP9nOCtLALDCfUWLxt0fsIAlhgSSJlUd2gw1lEVCVWP7G CcTkFXCXmNvOBXGDksT5ja/BxnAKeEj8u/GZGWKVu8S+aVPBRkoI7GKX6L3SyQaSYBEQkPg2 +RALxJ2yEpsOQP0iKXFwxQ2WCYzCCxgZVjGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmIExsDp f896dzDePmB9iDEZaNxEZinR5HxgDOWVxBsamxlZmJqYGhuZW5qRJqwkzqvWYh0oJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgVG9iE9X7mkFp9T7T43L2+vaFi2X85Gbk7ftz0fVq0bH5gSu an/uI7BEJ2Fjiu0Wwce5q76+mPe6UWhRUOhb+ULpP5krszu410/kP73/VtQRx/KTomILm6sW s7sGlGksi7u8ctbedtHXzXGTfHU/+xrOej6jTIfzzX8WrdvSxx2uLm+7f6Wza4ISS3FGoqEW c1FxIgAlRsyFlwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jQd2u7OpAg4NT+CxuXP/JZvFlQSe7 xcP1N1ksdty5z2xx41cbq0XHkRZGiymHv7BYfNuyjdHi7d5OdgdOj9kNF1k85s06weKxc9Zd do871/aweZy9s4PRo2/LKsYAtqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtz JYW8xNxUWyUXnwBdt8wcoLuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1 jBmX1rxgLVgkULH+6BamBsY1vF2MHBwSAiYSF69IdDFyApliEhfurWfrYuTiEBKYziix//Ea JpCEkMAEJolTuxNAbDYBdYknn9aygtgiAgYS059sZwVpYBaYzyix+NsjdpCEsECSxMoju1lB FrAIqEosf+MEYvIKuEvMbeeC2KUkcX7ja7AxnAIeEv9ufGaGWOUusW/aVNYJjLwLGBlWMYqm FiQXFCel5xrqFSfmFpfmpesl5+duYgRH2DOpHYwrGywOMQpwMCrx8GosqgoUYk0sK67MPcQo wcGsJMKrmFodKMSbklhZlVqUH19UmpNafIgxGeimicxSosn5wOjPK4k3NDYxNzU2tTSxMDGz JE1YSZz3QKt1oJBAemJJanZqakFqEcwWJg5OqQZG5XqJ3xP+WHS/iD0aJbtxw6SOqjNKl8xD bT3F9m1c2hmx2/pycK+39cx9/bnJNw9KpLw4+T6f4xHbJ67AxZvyypayTG0rCpMI+37oxJuy tuijDj6fVE10kn53vZf3mjfN7AnbS0nvYKsJ91KchRPZalXVnZ+V+5Ze/6f7loFtbu+VjP2C DmuVWIozEg21mIuKEwFb6kTy9AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Gm-Message-State: ALoCoQmKoclxag+V85s8eteG3CgiEcGMuw/drfD6yqac5EXqW9ziSc22VcFCp0pZ3qHHp0YnPpLL X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::236 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Amar This patch initialises the local variable 'shift' to zero. The uninitialised local variable 'shift' had garbage value and was resulting in unwnated results in the functions exynos5_get_mmc_clk() and exynos4_get_mmc_clk(). Signed-off-by: Amar Acked-by: Simon Glass Acked-by: Jaehoon Chung --- Changes since V1: 1)Updated the function exynos5_mmc_set_clk_div() to receive 'device_i'd as input parameter instead of 'index'. Changes since V2: 1)Updation of commit message and resubmition of proper patch set. Changes since V3: 1)Removed the new API exynos5_mmc_set_clk_div() from clock.c, because existing API set_mmc_clk() can be used to set mmc clock. Changes since V4: 1)Updated the subject line to reflect the changes present in this patch. 2)Changes of the file arch/arm/include/asm/arch-exynos/clk.h which were present in this patch, have been moved out of this patch. Changes since V5: No change. Changes since V6: No change. Changes since V7: No change. Changes since V8: No change. arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c index 223660a..cf3247a 100644 --- a/arch/arm/cpu/armv7/exynos/clock.c +++ b/arch/arm/cpu/armv7/exynos/clock.c @@ -613,7 +613,7 @@ static unsigned long exynos4_get_mmc_clk(int dev_index) (struct exynos4_clock *)samsung_get_base_clock(); unsigned long uclk, sclk; unsigned int sel, ratio, pre_ratio; - int shift; + int shift = 0; sel = readl(&clk->src_fsys); sel = (sel >> (dev_index << 2)) & 0xf; @@ -662,7 +662,7 @@ static unsigned long exynos5_get_mmc_clk(int dev_index) (struct exynos5_clock *)samsung_get_base_clock(); unsigned long uclk, sclk; unsigned int sel, ratio, pre_ratio; - int shift; + int shift = 0; sel = readl(&clk->src_fsys); sel = (sel >> (dev_index << 2)) & 0xf;