From patchwork Mon Jan 14 05:49:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajeshwari Shinde X-Patchwork-Id: 14022 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id D096923E2E for ; Mon, 14 Jan 2013 05:42:20 +0000 (UTC) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by fiordland.canonical.com (Postfix) with ESMTP id 71292A18FDF for ; Mon, 14 Jan 2013 05:42:20 +0000 (UTC) Received: by mail-vc0-f179.google.com with SMTP id p1so3124907vcq.24 for ; Sun, 13 Jan 2013 21:42:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-auditid:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:dlp-filter:x-mtr:x-brightmail-tracker :x-brightmail-tracker:x-cfilter-loop:x-gm-message-state; bh=jXwKZAajCznnksbcsUYe4Vz/4U3rUOe4NRucVGrxWDg=; b=lSmg7heSMw2MjmeeTKYCKOrZNyv+RkGS4oV7ytHTJkDYBcbvUIpEFjJpG4g3SfS224 a3Ht3t79ugUWz9CCznClcGNzH9psmxZ7e0K9BLu+//H8YaC7X08MBeTOxkY7Qfufvxhc str/f/88L/wyMuoOIuI+9auXk5Od14oEimAvUQaFQda7hDIdLGpwqG39EAvPZDUZb2em POmx7fi1aXRFJj6Kjr2BzZAjXo0Rr1YmG5Rwh9lh6Ca1fM2HXntLli8zAJg8QcLlG8Jw dJYRxen8/IdR7F0X66TcoteuMGgVkl079XGW/fRjl5nGKWfMPnrTXFkzmlpDezAz9NAR QoGw== X-Received: by 10.58.247.132 with SMTP id ye4mr104763477vec.9.1358142139848; Sun, 13 Jan 2013 21:42:19 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp45045veb; Sun, 13 Jan 2013 21:42:19 -0800 (PST) X-Received: by 10.68.253.137 with SMTP id aa9mr252684248pbd.102.1358142138616; Sun, 13 Jan 2013 21:42:18 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by mx.google.com with ESMTP id sn9si13211476pbc.39.2013.01.13.21.42.18; Sun, 13 Jan 2013 21:42:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of rajeshwari.s@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of rajeshwari.s@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=rajeshwari.s@samsung.com Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MGL00HVCP5QF580@mailout4.samsung.com>; Mon, 14 Jan 2013 14:42:17 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.124]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id AA.62.12699.9BA93F05; Mon, 14 Jan 2013 14:42:17 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-70-50f39ab93495 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 5A.62.12699.8BA93F05; Mon, 14 Jan 2013 14:42:17 +0900 (KST) Received: from rajeshwari-linux.sisodomain.com ([107.108.215.115]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MGL00F64P6ABA50@mmp1.samsung.com>; Mon, 14 Jan 2013 14:42:16 +0900 (KST) From: Rajeshwari Shinde To: u-boot@lists.denx.de Cc: patches@linaro.org, mk7.kang@samsung.com, chander.kashyap@linaro.org Subject: [PATCH V2] I2C: S3C24X0: Resolve build error for VCMA9 Date: Mon, 14 Jan 2013 11:19:36 +0530 Message-id: <1358142576-1957-1-git-send-email-rajeshwari.s@samsung.com> X-Mailer: git-send-email 1.7.4.4 In-reply-to: <712aayush@samsung.com> References: <712aayush@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsWyRsSkRnfnrM8BBk2L2S0err/JYjHl8BcW ByaPO9f2sAUwRnHZpKTmZJalFunbJXBldE+fwFbwmrfi9/x77A2MV7i7GDk5JARMJNa8f84I YYtJXLi3nq2LkYtDSGApo8Sj7hVsMEVfm6+wQCQWMUqcON7ODuFMZJK4cnIxM0gVm4CRxNaT 08BGiQhISPzqvwpkc3AwC3hITDodABIWFrCXOLlxNTuIzSKgKrHy1wswm1fAXaLj5HIWiGUK EsemfmUFsTkFVCSWTp3MAjJGSEBZ4vMmf4hWAYlvkw+BhSUEZCU2HWAGuUZC4DabxJI1i9kh xkhKHFxxg2UCo/ACRoZVjKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmbGIHBePrfM+kdjKsaLA4x CnAwKvHwTor4HCDEmlhWXJl7iFGCg1lJhDe0DijEm5JYWZValB9fVJqTWnyI0QfokonMUqLJ +cBIySuJNzQ2MTc1NrU0MjIzNcUhrCTOy3jqSYCQQHpiSWp2ampBahHMOCYOTqkGxnofWX3F zLlTTc8s6OdI+zZr5XXWE/5fGCu5/8yUC5/668LjvOpZC2P+CJ+dfXxOt+mURhvREAf1qJXS DwRczJyC/t9/u3CJt+nhT/m/p+zsutVzNbCSp3lJ/a0j7/I593eueSGrslyg5HbQUvEJzfe0 9UvvnjU/HH1s+stp/j3LZXJX8T7Sm6zEUpyRaKjFXFScCACUv+PkcwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e+xgO7OWZ8DDC6IWjxcf5PFYsrhLywO TB53ru1hC2CMamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ 0HXLzAEaraRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHM6J4+ga3gNW/F 7/n32BsYr3B3MXJySAiYSHxtvsICYYtJXLi3nq2LkYtDSGARo8SJ4+3sEM5EJokrJxczg1Sx CRhJbD05jRHEFhGQkPjVfxXI5uBgFvCQmHQ6ACQsLGAvcXLjanYQm0VAVWLlrxdgNq+Au0TH yeVQyxQkjk39ygpicwqoSCydOpkFZIyQgLLE503+Exh5FzAyrGIUTS1ILihOSs810itOzC0u zUvXS87P3cQIDvRn0jsYVzVYHGIU4GBU4uGdFPE5QIg1say4MvcQowQHs5IIb2gdUIg3JbGy KrUoP76oNCe1+BCjD9BRE5mlRJPzgVGYVxJvaGxibmpsamliYWJmiUNYSZyX8dSTACGB9MSS 1OzU1ILUIphxTBycUg2Mqh1iKy+/4jtdIR+bG7M+3fBt75YbEyb3u108+rtup3ln84Yd4i6a S6+yFOj6ah7XkGa7v6e05bCywQ3x0zvLb56ymHojxfitjJ+DR1rY2qyjkmcNznZ661xtk/Up zdm12m1i8pMt5cdn3jQVv+xe3rZgztLl23965Om83LEk7l1h/beK3fUnlViKMxINtZiLihMB fQVdy6ECAAA= X-CFilter-Loop: Reflected X-Gm-Message-State: ALoCoQk0xuuGtrdqZnXGT8yzJAqjicGPqCmTkFwjcvJimu4J8S9JzkOUnxAYgXii/al1U5PiHFRd This patch resolves the following build errors for I2C driver in VCMA9: In file included from s3c24x0_i2c.c:40:0: s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning: 'i2c_busses' defined but not used [-Wunused-variable] Signed-off-by: Rajeshwari Shinde --- Changes since V1: - Changes the commit message to add the errors. - changed enum periph_id to int drivers/i2c/s3c24x0_i2c.c | 4 +++- drivers/i2c/s3c24x0_i2c.h | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c index 7ec01ec..769a2ba 100644 --- a/drivers/i2c/s3c24x0_i2c.c +++ b/drivers/i2c/s3c24x0_i2c.c @@ -67,9 +67,11 @@ * variables to live in SRAM */ static unsigned int g_current_bus __attribute__((section(".data"))); +#ifdef CONFIG_OF_CONTROL +static int i2c_busses __attribute__((section(".data"))); static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM] __attribute__((section(".data"))); -static int i2c_busses __attribute__((section(".data"))); +#endif #if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5) static int GetI2CSDA(void) diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h index 1243bf1..a56d749 100644 --- a/drivers/i2c/s3c24x0_i2c.h +++ b/drivers/i2c/s3c24x0_i2c.h @@ -35,7 +35,6 @@ struct s3c24x0_i2c_bus { int node; /* device tree node */ int bus_num; /* i2c bus number */ struct s3c24x0_i2c *regs; - enum periph_id id; + int id; }; - #endif /* _S3C24X0_I2C_H */