diff mbox series

[v2,06/11] riscv: Fix incorrect cpu frequency on RV64

Message ID	0b623be8-a24e-e200-c406-be54d84bb04a@gmail.com
State	New
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: seanga2 at gmail.com (Sean Anderson) Date: Wed, 15 Jan 2020 17:55:39 -0500 Subject: [PATCH v2 06/11] riscv: Fix incorrect cpu frequency on RV64 In-Reply-To: <3411d84b-5a56-ae4e-1deb-085ef1a4971d@gmail.com> References: <3411d84b-5a56-ae4e-1deb-085ef1a4971d@gmail.com> Message-ID: <0b623be8-a24e-e200-c406-be54d84bb04a@gmail.com>
Series	riscv: Add Sipeed Maix support \| expand [v2,00/11] riscv: Add Sipeed Maix support [v2,01/11] clk: Always use the supplied struct clk [v2,02/11] clk: Check that ops of composite clock components, exist before calling [v2,03/11] riscv: Add headers for asm/global_data.h [v2,04/11] riscv: Add an option to default to RV64I [v2,05/11] riscv: Add option to disable writes to mcounteren [v2,06/11] riscv: Fix incorrect cpu frequency on RV64 [v2,07/11] riscv: Add initial Sipeed Maix support [v2,09/11] riscv: Add K210 sysctl support [v2,10/11] riscv: Add K210 pll support [v2,11/11] riscv: Add K210 clock support [v2,08/11] riscv: Add device tree for K210

Commit Message

Sean Anderson Jan. 15, 2020, 10:55 p.m. UTC

The riscv_cpu_get_info function does not always zero-out cpu_freq. This can
cause spurious higher frequencies.

Signed-off-by Sean Anderson <seanga2 at gmail.com>
---
Changes for v2:
  New.

 drivers/cpu/riscv_cpu.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lukas Auer Jan. 26, 2020, 10:04 p.m. UTC | #1

On Wed, 2020-01-15 at 17:55 -0500, Sean Anderson wrote:

> The riscv_cpu_get_info function does not always zero-out cpu_freq. This can
> cause spurious higher frequencies.
> 
> Signed-off-by Sean Anderson <seanga2 at gmail.com>
> ---
> Changes for v2:
>   New.
> 
>  drivers/cpu/riscv_cpu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Lukas Auer <lukas at auer.io>

diff mbox series

Patch

diff --git a/drivers/cpu/riscv_cpu.c b/drivers/cpu/riscv_cpu.c
index 28ad0aa30f..1e32bb5678 100644
--- a/drivers/cpu/riscv_cpu.c
+++ b/drivers/cpu/riscv_cpu.c
@@ -29,6 +29,8 @@  static int riscv_cpu_get_info(struct udevice *dev, struct cpu_info *info)
 {
 	const char *mmu;
 
+	/* Zero out the frequency, in case sizeof(ulong) != sizeof(u32) */
+	info->cpu_freq = 0;
 	dev_read_u32(dev, "clock-frequency", (u32 *)&info->cpu_freq);
 
 	mmu = dev_read_string(dev, "mmu-type");