| Message ID | 20241110083017.367565-1-ilias.apalodimas@linaro.org |
|---|---|
| Headers | show |
| Series | [v3,1/6] mbedtls: Enable TLS 1.2 support | expand |
Hi Ilias, On Sun, 10 Nov 2024 at 01:31, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > Hi all, > > This is a respin of [1] adding https support to wget. In short > > patch#1 enables the crypto algorithms we need in mbedTLS > patches#2, #3 enable anf fix the lwIP part we need > patch#4 is adding https:// parsing support in our wget > patch#5 is making https:// the default for QEMU lwip defconfig so > people can easily test > and finaly patch#6 updates our documentation > > [1] https://lore.kernel.org/u-boot/20241024112449.1362319-1-ilias.apalodimas@linaro.org/ > > > Changes since v2: > - Use a bool variable for https:// support instead of relying on the port number > - changed a memcpy to strlcpy to avoid reading extra bytes from the source buffer > - Removed unrelated whitespace fixes > - CONFIG_IS_ENABLED -> IS_ENABLED on mbedTLS header file > - Add r-b tags by Jerome > > Changes since v1: > - re-arranged the Makefile objects so they only get compiled when TLS ie enabled > - Fix all the applicable remarks Simon had on the wget patches > - Fixed the title of a patch pointer out by Peter > - Rebased on -master > - Collected r-b tags > > Ilias Apalodimas (4): > mbedtls: Enable TLS 1.2 support > net: lwip: Enable https:// support for wget > configs: Enable https for wget on qemu arm64 > doc: uefi: Describe UEFI HTTPs boot > > Javier Tia (2): > net: lwip: Update lwIP for mbedTLS > 3.0 support and enable https > net: lwip: Add Support Server Name Indication support > > cmd/Kconfig | 19 ++++ > configs/qemu_arm64_lwip_defconfig | 1 + > doc/develop/uefi/uefi.rst | 45 +++++++++- > lib/lwip/Makefile | 3 + > .../src/apps/altcp_tls/altcp_tls_mbedtls.c | 49 +++++++---- > lib/lwip/lwip/src/core/tcp_out.c | 8 -- > lib/lwip/lwip/src/include/lwip/altcp_tls.h | 2 +- > lib/lwip/u-boot/lwipopts.h | 6 ++ > lib/mbedtls/Kconfig | 12 +++ > lib/mbedtls/Makefile | 31 +++++++ > lib/mbedtls/mbedtls_def_config.h | 52 +++++++++++ > net/lwip/Kconfig | 2 +- > net/lwip/wget.c | 86 +++++++++++++++++-- > 13 files changed, 277 insertions(+), 39 deletions(-) > > -- > 2.43.0 > Can you also please update doc/usage/cmd/wget ? Also test/cmd/wget ? Regards, Simon
Hi Simon, On Mon, 11 Nov 2024 at 15:03, Simon Glass <sjg@chromium.org> wrote: > > Hi Ilias, > > On Sun, 10 Nov 2024 at 01:31, Ilias Apalodimas > <ilias.apalodimas@linaro.org> wrote: > > > > Hi all, > > > > This is a respin of [1] adding https support to wget. In short > > > > patch#1 enables the crypto algorithms we need in mbedTLS > > patches#2, #3 enable anf fix the lwIP part we need > > patch#4 is adding https:// parsing support in our wget > > patch#5 is making https:// the default for QEMU lwip defconfig so > > people can easily test > > and finaly patch#6 updates our documentation > > > > [1] https://lore.kernel.org/u-boot/20241024112449.1362319-1-ilias.apalodimas@linaro.org/ > > > > > > Changes since v2: > > - Use a bool variable for https:// support instead of relying on the port number > > - changed a memcpy to strlcpy to avoid reading extra bytes from the source buffer > > - Removed unrelated whitespace fixes > > - CONFIG_IS_ENABLED -> IS_ENABLED on mbedTLS header file > > - Add r-b tags by Jerome > > > > Changes since v1: > > - re-arranged the Makefile objects so they only get compiled when TLS ie enabled > > - Fix all the applicable remarks Simon had on the wget patches > > - Fixed the title of a patch pointer out by Peter > > - Rebased on -master > > - Collected r-b tags > > > > Ilias Apalodimas (4): > > mbedtls: Enable TLS 1.2 support > > net: lwip: Enable https:// support for wget > > configs: Enable https for wget on qemu arm64 > > doc: uefi: Describe UEFI HTTPs boot > > > > Javier Tia (2): > > net: lwip: Update lwIP for mbedTLS > 3.0 support and enable https > > net: lwip: Add Support Server Name Indication support > > > > cmd/Kconfig | 19 ++++ > > configs/qemu_arm64_lwip_defconfig | 1 + > > doc/develop/uefi/uefi.rst | 45 +++++++++- > > lib/lwip/Makefile | 3 + > > .../src/apps/altcp_tls/altcp_tls_mbedtls.c | 49 +++++++---- > > lib/lwip/lwip/src/core/tcp_out.c | 8 -- > > lib/lwip/lwip/src/include/lwip/altcp_tls.h | 2 +- > > lib/lwip/u-boot/lwipopts.h | 6 ++ > > lib/mbedtls/Kconfig | 12 +++ > > lib/mbedtls/Makefile | 31 +++++++ > > lib/mbedtls/mbedtls_def_config.h | 52 +++++++++++ > > net/lwip/Kconfig | 2 +- > > net/lwip/wget.c | 86 +++++++++++++++++-- > > 13 files changed, 277 insertions(+), 39 deletions(-) > > > > -- > > 2.43.0 > > > > Can you also please update doc/usage/cmd/wget ? > > Also test/cmd/wget ? Sure. Do you mind if I do this on a followup series? I want this to land in 2025.01. I can send a followup on this within the week Thanks /Ilias > > Regards, > Simon
Hi Ilias, On Mon, 11 Nov 2024 at 07:07, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > Hi Simon, > > On Mon, 11 Nov 2024 at 15:03, Simon Glass <sjg@chromium.org> wrote: > > > > Hi Ilias, > > > > On Sun, 10 Nov 2024 at 01:31, Ilias Apalodimas > > <ilias.apalodimas@linaro.org> wrote: > > > > > > Hi all, > > > > > > This is a respin of [1] adding https support to wget. In short > > > > > > patch#1 enables the crypto algorithms we need in mbedTLS > > > patches#2, #3 enable anf fix the lwIP part we need > > > patch#4 is adding https:// parsing support in our wget > > > patch#5 is making https:// the default for QEMU lwip defconfig so > > > people can easily test > > > and finaly patch#6 updates our documentation > > > > > > [1] https://lore.kernel.org/u-boot/20241024112449.1362319-1-ilias.apalodimas@linaro.org/ > > > > > > > > > Changes since v2: > > > - Use a bool variable for https:// support instead of relying on the port number > > > - changed a memcpy to strlcpy to avoid reading extra bytes from the source buffer > > > - Removed unrelated whitespace fixes > > > - CONFIG_IS_ENABLED -> IS_ENABLED on mbedTLS header file > > > - Add r-b tags by Jerome > > > > > > Changes since v1: > > > - re-arranged the Makefile objects so they only get compiled when TLS ie enabled > > > - Fix all the applicable remarks Simon had on the wget patches > > > - Fixed the title of a patch pointer out by Peter > > > - Rebased on -master > > > - Collected r-b tags > > > > > > Ilias Apalodimas (4): > > > mbedtls: Enable TLS 1.2 support > > > net: lwip: Enable https:// support for wget > > > configs: Enable https for wget on qemu arm64 > > > doc: uefi: Describe UEFI HTTPs boot > > > > > > Javier Tia (2): > > > net: lwip: Update lwIP for mbedTLS > 3.0 support and enable https > > > net: lwip: Add Support Server Name Indication support > > > > > > cmd/Kconfig | 19 ++++ > > > configs/qemu_arm64_lwip_defconfig | 1 + > > > doc/develop/uefi/uefi.rst | 45 +++++++++- > > > lib/lwip/Makefile | 3 + > > > .../src/apps/altcp_tls/altcp_tls_mbedtls.c | 49 +++++++---- > > > lib/lwip/lwip/src/core/tcp_out.c | 8 -- > > > lib/lwip/lwip/src/include/lwip/altcp_tls.h | 2 +- > > > lib/lwip/u-boot/lwipopts.h | 6 ++ > > > lib/mbedtls/Kconfig | 12 +++ > > > lib/mbedtls/Makefile | 31 +++++++ > > > lib/mbedtls/mbedtls_def_config.h | 52 +++++++++++ > > > net/lwip/Kconfig | 2 +- > > > net/lwip/wget.c | 86 +++++++++++++++++-- > > > 13 files changed, 277 insertions(+), 39 deletions(-) > > > > > > -- > > > 2.43.0 > > > > > > > Can you also please update doc/usage/cmd/wget ? > > > > Also test/cmd/wget ? > > Sure. Do you mind if I do this on a followup series? I want this to > land in 2025.01. I can send a followup on this within the week Yes that's fine with me. Regards, SImon
On Sun, 10 Nov 2024 10:28:36 +0200, Ilias Apalodimas wrote: > This is a respin of [1] adding https support to wget. In short > > patch#1 enables the crypto algorithms we need in mbedTLS > patches#2, #3 enable anf fix the lwIP part we need > patch#4 is adding https:// parsing support in our wget > patch#5 is making https:// the default for QEMU lwip defconfig so > people can easily test > and finaly patch#6 updates our documentation > > [...] Applied to u-boot/master, thanks!