mbox series

[v2,0/6] Miscellaneous FWU fixes

Message ID 20240909112021.1962801-1-sughosh.ganu@linaro.org
Headers show
Series Miscellaneous FWU fixes | expand

Message

Sughosh Ganu Sept. 9, 2024, 11:20 a.m. UTC
The following set of patches are miscellaneous fixes and some
hardening of the FWU update logic.


Changes since V1:
* Squash patch 1 and 2 in the earlier version into a single patch.
* Have a single check for image descriptor offset, and have a log
  message mention that image descriptor mandatory.
* Use a macro FWU_IMG_DESC_OFFSET for the image descriptor offset.
* Use the enum names for primary and secondary partitions from fwu.h
  instead of defining new macros.


Sughosh Ganu (6):
  fwu: v2: try reading both copies of metadata
  fwu: v1: do a version check for the metadata
  fwu: check all images for transitioning out of Trial State
  fwu: add dependency checks for selecting FWU metadata version
  fwu: do not allow capsule processing on exceeding Trial Counter
    threshold
  fwu: print a message if empty capsule checks fail

 include/fwu.h                | 11 +++++
 lib/efi_loader/efi_capsule.c | 11 +++--
 lib/fwu_updates/Kconfig      |  1 +
 lib/fwu_updates/fwu.c        | 31 +++++++++++++-
 lib/fwu_updates/fwu_v1.c     | 18 ++++++--
 lib/fwu_updates/fwu_v2.c     | 81 ++++++++++++++++++++----------------
 6 files changed, 108 insertions(+), 45 deletions(-)

Comments

Michal Simek Sept. 13, 2024, 1:02 p.m. UTC | #1
On 9/9/24 13:20, Sughosh Ganu wrote:
> 
> The following set of patches are miscellaneous fixes and some
> hardening of the FWU update logic.
> 
> 
> Changes since V1:
> * Squash patch 1 and 2 in the earlier version into a single patch.
> * Have a single check for image descriptor offset, and have a log
>    message mention that image descriptor mandatory.
> * Use a macro FWU_IMG_DESC_OFFSET for the image descriptor offset.
> * Use the enum names for primary and secondary partitions from fwu.h
>    instead of defining new macros.
> 
> 
> Sughosh Ganu (6):
>    fwu: v2: try reading both copies of metadata
>    fwu: v1: do a version check for the metadata
>    fwu: check all images for transitioning out of Trial State
>    fwu: add dependency checks for selecting FWU metadata version
>    fwu: do not allow capsule processing on exceeding Trial Counter
>      threshold
>    fwu: print a message if empty capsule checks fail
> 
>   include/fwu.h                | 11 +++++
>   lib/efi_loader/efi_capsule.c | 11 +++--
>   lib/fwu_updates/Kconfig      |  1 +
>   lib/fwu_updates/fwu.c        | 31 +++++++++++++-
>   lib/fwu_updates/fwu_v1.c     | 18 ++++++--
>   lib/fwu_updates/fwu_v2.c     | 81 ++++++++++++++++++++----------------
>   6 files changed, 108 insertions(+), 45 deletions(-)
> 

Tested-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal