mbox series

[v2,0/2] clk: add a stub clock driver

Message ID 20240527-b4-clk-stub-v2-0-29013855e343@linaro.org
Headers show
Series clk: add a stub clock driver | expand

Message

Caleb Connolly May 27, 2024, 5:12 p.m. UTC
As U-Boot works to align itself with upstream devicetrees, there are
some common issues we start to run into, that of hardware blocks which
might be important for an OS like Linux, but which aren't useful in
U-Boot.

For example, the Resource Power Manager found on Qualcomm platforms
includes clock controllers and power domains which are only useful for
managing power consumption and enabling low power states.

As this is not at all relevant for U-Boot, we can safely ignore these
devices, but we don't have a good way to communicate that to U-Boot.

As an initial step, implement a "stub" clock driver which can be bound
to these devices so that drivers will work as expected. Make the
Qualcomm SM6115 RPMCC the first user of this, and enable the driver for
Qualcomm platforms.

To: Tom Rini <trini@konsulko.com>
To: Lukasz Majewski <lukma@denx.de>
To: Sean Anderson <seanga2@gmail.com>
To: Caleb Connolly <caleb.connolly@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: u-boot@lists.denx.de
Cc: u-boot-qcom@groups.io

Changes in v2:
- Take the other discussed approach of just implementing a stub driver.
- Link to v1: https://lore.kernel.org/r/20240410-b4-stub-drivers-v1-0-6935bd2c07d1@linaro.org

---
Caleb Connolly (2):
      clk: add stub clock driver
      qcom_defconfig: enable stub clock

 configs/qcom_defconfig |  1 +
 drivers/clk/Kconfig    |  7 ++++++
 drivers/clk/Makefile   |  1 +
 drivers/clk/clk-stub.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 72 insertions(+)
---
change-id: 20240527-b4-clk-stub-9698797a65ef
base-commit: 7e52d6ccfb76e2afc2d183b357abe2a2e2f948cf

// Caleb (they/them)

Comments

Caleb Connolly June 17, 2024, 8:05 a.m. UTC | #1
Small bump, would folks mind taking a look at this?

On 27/05/2024 19:12, Caleb Connolly wrote:
> As U-Boot works to align itself with upstream devicetrees, there are
> some common issues we start to run into, that of hardware blocks which
> might be important for an OS like Linux, but which aren't useful in
> U-Boot.
> 
> For example, the Resource Power Manager found on Qualcomm platforms
> includes clock controllers and power domains which are only useful for
> managing power consumption and enabling low power states.
> 
> As this is not at all relevant for U-Boot, we can safely ignore these
> devices, but we don't have a good way to communicate that to U-Boot.
> 
> As an initial step, implement a "stub" clock driver which can be bound
> to these devices so that drivers will work as expected. Make the
> Qualcomm SM6115 RPMCC the first user of this, and enable the driver for
> Qualcomm platforms.
> 
> To: Tom Rini <trini@konsulko.com>
> To: Lukasz Majewski <lukma@denx.de>
> To: Sean Anderson <seanga2@gmail.com>
> To: Caleb Connolly <caleb.connolly@linaro.org>
> To: Neil Armstrong <neil.armstrong@linaro.org>
> To: Sumit Garg <sumit.garg@linaro.org>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: u-boot@lists.denx.de
> Cc: u-boot-qcom@groups.io
> 
> Changes in v2:
> - Take the other discussed approach of just implementing a stub driver.
> - Link to v1: https://lore.kernel.org/r/20240410-b4-stub-drivers-v1-0-6935bd2c07d1@linaro.org
> 
> ---
> Caleb Connolly (2):
>        clk: add stub clock driver
>        qcom_defconfig: enable stub clock
> 
>   configs/qcom_defconfig |  1 +
>   drivers/clk/Kconfig    |  7 ++++++
>   drivers/clk/Makefile   |  1 +
>   drivers/clk/clk-stub.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   4 files changed, 72 insertions(+)
> ---
> change-id: 20240527-b4-clk-stub-9698797a65ef
> base-commit: 7e52d6ccfb76e2afc2d183b357abe2a2e2f948cf
> 
> // Caleb (they/them)
>
Neil Armstrong June 28, 2024, 9:59 a.m. UTC | #2
On 27/05/2024 19:12, Caleb Connolly wrote:
> As U-Boot works to align itself with upstream devicetrees, there are
> some common issues we start to run into, that of hardware blocks which
> might be important for an OS like Linux, but which aren't useful in
> U-Boot.
> 
> For example, the Resource Power Manager found on Qualcomm platforms
> includes clock controllers and power domains which are only useful for
> managing power consumption and enabling low power states.
> 
> As this is not at all relevant for U-Boot, we can safely ignore these
> devices, but we don't have a good way to communicate that to U-Boot.
> 
> As an initial step, implement a "stub" clock driver which can be bound
> to these devices so that drivers will work as expected. Make the
> Qualcomm SM6115 RPMCC the first user of this, and enable the driver for
> Qualcomm platforms.
> 
> To: Tom Rini <trini@konsulko.com>
> To: Lukasz Majewski <lukma@denx.de>
> To: Sean Anderson <seanga2@gmail.com>
> To: Caleb Connolly <caleb.connolly@linaro.org>
> To: Neil Armstrong <neil.armstrong@linaro.org>
> To: Sumit Garg <sumit.garg@linaro.org>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: u-boot@lists.denx.de
> Cc: u-boot-qcom@groups.io
> 
> Changes in v2:
> - Take the other discussed approach of just implementing a stub driver.
> - Link to v1: https://lore.kernel.org/r/20240410-b4-stub-drivers-v1-0-6935bd2c07d1@linaro.org
> 
> ---
> Caleb Connolly (2):
>        clk: add stub clock driver
>        qcom_defconfig: enable stub clock
> 
>   configs/qcom_defconfig |  1 +
>   drivers/clk/Kconfig    |  7 ++++++
>   drivers/clk/Makefile   |  1 +
>   drivers/clk/clk-stub.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   4 files changed, 72 insertions(+)
> ---
> change-id: 20240527-b4-clk-stub-9698797a65ef
> base-commit: 7e52d6ccfb76e2afc2d183b357abe2a2e2f948cf
> 
> // Caleb (they/them)
> 

LGTM

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Ilias Apalodimas June 28, 2024, 10:04 a.m. UTC | #3
On Mon, 27 May 2024 at 20:12, Caleb Connolly <caleb.connolly@linaro.org> wrote:
>
> As U-Boot works to align itself with upstream devicetrees, there are
> some common issues we start to run into, that of hardware blocks which
> might be important for an OS like Linux, but which aren't useful in
> U-Boot.
>
> For example, the Resource Power Manager found on Qualcomm platforms
> includes clock controllers and power domains which are only useful for
> managing power consumption and enabling low power states.
>
> As this is not at all relevant for U-Boot, we can safely ignore these
> devices, but we don't have a good way to communicate that to U-Boot.
>
> As an initial step, implement a "stub" clock driver which can be bound
> to these devices so that drivers will work as expected. Make the
> Qualcomm SM6115 RPMCC the first user of this, and enable the driver for
> Qualcomm platforms.
>
> To: Tom Rini <trini@konsulko.com>
> To: Lukasz Majewski <lukma@denx.de>
> To: Sean Anderson <seanga2@gmail.com>
> To: Caleb Connolly <caleb.connolly@linaro.org>
> To: Neil Armstrong <neil.armstrong@linaro.org>
> To: Sumit Garg <sumit.garg@linaro.org>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: u-boot@lists.denx.de
> Cc: u-boot-qcom@groups.io
>
> Changes in v2:
> - Take the other discussed approach of just implementing a stub driver.
> - Link to v1: https://lore.kernel.org/r/20240410-b4-stub-drivers-v1-0-6935bd2c07d1@linaro.org
>
> ---
> Caleb Connolly (2):
>       clk: add stub clock driver
>       qcom_defconfig: enable stub clock
>
>  configs/qcom_defconfig |  1 +
>  drivers/clk/Kconfig    |  7 ++++++
>  drivers/clk/Makefile   |  1 +
>  drivers/clk/clk-stub.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 72 insertions(+)
> ---
> change-id: 20240527-b4-clk-stub-9698797a65ef
> base-commit: 7e52d6ccfb76e2afc2d183b357abe2a2e2f948cf
>
> // Caleb (they/them)
>

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>