mbox series

[RFC,v2,0/4] enable menu-driven boot device selection

Message ID 20220222160235.24748-1-masahisa.kojima@linaro.org
Headers show
Series enable menu-driven boot device selection | expand

Message

Masahisa Kojima Feb. 22, 2022, 4:02 p.m. UTC
This patch series adds the menu-driven boot device selection.
This menu also provides the functionality to add and delete
Boot#### variable, and edit the BootOrder variable.

This menu appears with the command "bootefi bootmgr",
the menu structure is as follows.

* Menu structure
[Boot Manager]
    -> select Boot#### to boot
[Boot Manager Maintenance]
    - [Add Boot Option]
        -> add new Boot#### variable
    - [Delete Boot Option]
        -> delete existing Boot#### variable
    - [Change Boot Order]
        -> update BootOrder variable

* Things to consider
 - eliminate EFI_CALLs
 - replacement of ANSI_CLEAR_CONSOLE

* Remaining items
 - Support of adding Boot#### other than block device(e.g. network)
 - error notification

Masahisa Kojima (4):
  efi_loader: add menu-driven boot device selection
  lib/charset: add u16_strlcat() function
  test: unit test for u16_strlcat()
  efi_loader: add menu-driven UEFI Boot Variable maintenance

 cmd/bootmenu.c                |  145 -----
 common/menu.c                 |  137 ++++
 include/charset.h             |   15 +
 include/efi_loader.h          |   27 +
 include/menu.h                |   20 +
 lib/charset.c                 |   20 +
 lib/efi_loader/Kconfig        |   20 +
 lib/efi_loader/efi_bootmgr.c  | 1105 ++++++++++++++++++++++++++++++++-
 lib/efi_loader/efi_boottime.c |   55 +-
 lib/efi_loader/efi_console.c  |   81 +++
 lib/efi_loader/efi_file.c     |   74 ++-
 test/unicode_ut.c             |   45 ++
 12 files changed, 1548 insertions(+), 196 deletions(-)

Comments

Heinrich Schuchardt Feb. 24, 2022, 10:31 a.m. UTC | #1
On 2/22/22 17:02, Masahisa Kojima wrote:
> This patch series adds the menu-driven boot device selection.
> This menu also provides the functionality to add and delete
> Boot#### variable, and edit the BootOrder variable.
>
> This menu appears with the command "bootefi bootmgr",
> the menu structure is as follows.

Unfortunately there is neither a changelog in this coverletter nor the
individual patches.

What is the difference to v1?

Best regards

Heinrich

>
> * Menu structure
> [Boot Manager]
>      -> select Boot#### to boot
> [Boot Manager Maintenance]
>      - [Add Boot Option]
>          -> add new Boot#### variable
>      - [Delete Boot Option]
>          -> delete existing Boot#### variable
>      - [Change Boot Order]
>          -> update BootOrder variable
>
> * Things to consider
>   - eliminate EFI_CALLs
>   - replacement of ANSI_CLEAR_CONSOLE
>
> * Remaining items
>   - Support of adding Boot#### other than block device(e.g. network)
>   - error notification
>
> Masahisa Kojima (4):
>    efi_loader: add menu-driven boot device selection
>    lib/charset: add u16_strlcat() function
>    test: unit test for u16_strlcat()
>    efi_loader: add menu-driven UEFI Boot Variable maintenance
>
>   cmd/bootmenu.c                |  145 -----
>   common/menu.c                 |  137 ++++
>   include/charset.h             |   15 +
>   include/efi_loader.h          |   27 +
>   include/menu.h                |   20 +
>   lib/charset.c                 |   20 +
>   lib/efi_loader/Kconfig        |   20 +
>   lib/efi_loader/efi_bootmgr.c  | 1105 ++++++++++++++++++++++++++++++++-
>   lib/efi_loader/efi_boottime.c |   55 +-
>   lib/efi_loader/efi_console.c  |   81 +++
>   lib/efi_loader/efi_file.c     |   74 ++-
>   test/unicode_ut.c             |   45 ++
>   12 files changed, 1548 insertions(+), 196 deletions(-)
>
Masahisa Kojima Feb. 25, 2022, 12:07 a.m. UTC | #2
Hi Heinrich,

On Thu, 24 Feb 2022 at 19:31, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 2/22/22 17:02, Masahisa Kojima wrote:
> > This patch series adds the menu-driven boot device selection.
> > This menu also provides the functionality to add and delete
> > Boot#### variable, and edit the BootOrder variable.
> >
> > This menu appears with the command "bootefi bootmgr",
> > the menu structure is as follows.
>
> Unfortunately there is neither a changelog in this coverletter nor the
> individual patches.
>
> What is the difference to v1?

I'm sorry for not including a changelog, I will re-send the v2 patches
with changelog.

Thanks,
Masahisa Kojima

>
> Best regards
>
> Heinrich
>
> >
> > * Menu structure
> > [Boot Manager]
> >      -> select Boot#### to boot
> > [Boot Manager Maintenance]
> >      - [Add Boot Option]
> >          -> add new Boot#### variable
> >      - [Delete Boot Option]
> >          -> delete existing Boot#### variable
> >      - [Change Boot Order]
> >          -> update BootOrder variable
> >
> > * Things to consider
> >   - eliminate EFI_CALLs
> >   - replacement of ANSI_CLEAR_CONSOLE
> >
> > * Remaining items
> >   - Support of adding Boot#### other than block device(e.g. network)
> >   - error notification
> >
> > Masahisa Kojima (4):
> >    efi_loader: add menu-driven boot device selection
> >    lib/charset: add u16_strlcat() function
> >    test: unit test for u16_strlcat()
> >    efi_loader: add menu-driven UEFI Boot Variable maintenance
> >
> >   cmd/bootmenu.c                |  145 -----
> >   common/menu.c                 |  137 ++++
> >   include/charset.h             |   15 +
> >   include/efi_loader.h          |   27 +
> >   include/menu.h                |   20 +
> >   lib/charset.c                 |   20 +
> >   lib/efi_loader/Kconfig        |   20 +
> >   lib/efi_loader/efi_bootmgr.c  | 1105 ++++++++++++++++++++++++++++++++-
> >   lib/efi_loader/efi_boottime.c |   55 +-
> >   lib/efi_loader/efi_console.c  |   81 +++
> >   lib/efi_loader/efi_file.c     |   74 ++-
> >   test/unicode_ut.c             |   45 ++
> >   12 files changed, 1548 insertions(+), 196 deletions(-)
> >
>