[v4,00/13] x86: cbfs: Various clean-ups to CBFS implementation

This code is very old and has not had much of a clean-up since it was
written. This series aims to tidy it up to use error codes, avoid using
BSS when not necessary and to add a few more features.

Changes in v4:
- Stick with US spelling
- Fix 'his' typo

Changes in v3:
- Fix typo in commit message

Changes in v2:
- Fix incorrect function comments
- Fix s/u8/void/ in find_uncached()
- Fix setting of start in file_cbfs_find_uncached()
- Add more comments on @node in file_cbfs_find_uncached()
- Use void * instead of u8 * in file_cbfs_find_uncached_base()
- Fix and expand comments in file_cbfs_find_uncached_base()
- Rebase to master (with x86/master cherry-picked in too)
- Resending as some comments / reviews were missed

Simon Glass (13):
  cbfs: Rename the result variable
  cbfs: Use ulong consistently
  cbfs: Use bool type for whether initialised
  cbfs: Adjust return value of file_cbfs_next_file()
  cbfs: Adjust file_cbfs_load_header() to use cbfs_priv
  cbfs: Adjust cbfs_load_header_ptr() to use cbfs_priv
  cbfs: Unify the two header loaders
  cbfs: Use void * for the position pointers
  cbfs: Record the start address in cbfs_priv
  cbfs: Return the error code from file_cbfs_init()
  cbfs: Change file_cbfs_find_uncached() to return an error
  cbfs: Allow reading a file from a CBFS given its base addr
  cbfs: Don't require the CBFS size with cbfs_init_mem()

 arch/x86/lib/fsp2/fsp_init.c |   3 +-
 cmd/cbfs.c                   |   3 +-
 fs/cbfs/cbfs.c               | 240 ++++++++++++++++++++++-------------
 include/cbfs.h               |  40 ++++--
 4 files changed, 182 insertions(+), 104 deletions(-)

On Mon, May 25, 2020 at 7:38 AM Simon Glass <sjg at chromium.org> wrote:
>
> This code is very old and has not had much of a clean-up since it was
> written. This series aims to tidy it up to use error codes, avoid using
> BSS when not necessary and to add a few more features.
>
> Changes in v4:
> - Stick with US spelling
> - Fix 'his' typo
>

series applied to u-boot-x86, thanks!

Hi Simon,

On Mon, May 25, 2020 at 9:19 AM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, May 25, 2020 at 7:38 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > This code is very old and has not had much of a clean-up since it was
> > written. This series aims to tidy it up to use error codes, avoid using
> > BSS when not necessary and to add a few more features.
> >
> > Changes in v4:
> > - Stick with US spelling
> > - Fix 'his' typo
> >
>
> series applied to u-boot-x86, thanks!

It looks there are build errors for sandbox/x86:
https://dev.azure.com/bmeng/GitHub/_build/results?buildId=229&view=logs&j=8a1d3be7-a4c9-55b6-774d-e7f1a8f80847&t=b2f224a7-1103-5b52-edbc-3784ae727e03

Could you please take a look?

Regards,
Bin