mbox series

[0/2] u-boot support for ODROID-C4

Message ID 20200505202217.7849-1-b.galvani@gmail.com
Headers show
Series u-boot support for ODROID-C4 | expand

Message

Beniamino Galvani May 5, 2020, 8:22 p.m. UTC 
Hi,

these two patches add initial u-boot support for Hardkernel ODROID-C4.

https://wiki.odroid.com/odroid-c4/odroid-c4

Beniamino Galvani (2):
  arm: dts: import ODROID-C4 device tree
  boards: amlogic: add ODROID-C4 support

 arch/arm/dts/Makefile                |   1 +
 arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++++++++++++++++++++++++++
 board/amlogic/odroid-c4/MAINTAINERS  |   6 +
 board/amlogic/odroid-c4/Makefile     |   3 +
 board/amlogic/odroid-c4/README       |  83 ++++++
 board/amlogic/odroid-c4/odroid-c4.c  |  17 ++
 configs/odroid-c4_defconfig          |  63 +++++
 7 files changed, 572 insertions(+)
 create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts
 create mode 100644 board/amlogic/odroid-c4/MAINTAINERS
 create mode 100644 board/amlogic/odroid-c4/Makefile
 create mode 100644 board/amlogic/odroid-c4/README
 create mode 100644 board/amlogic/odroid-c4/odroid-c4.c
 create mode 100644 configs/odroid-c4_defconfig

Comments

Neil Armstrong May 6, 2020, 7:59 a.m. UTC | #1 
Hi Beniamino,

On 05/05/2020 22:22, Beniamino Galvani wrote:
> Hi,
> 
> these two patches add initial u-boot support for Hardkernel ODROID-C4.

Thanks for the patchset, I already have one in my test tree, by you did beat me
by sending it to the list !

> 
> https://wiki.odroid.com/odroid-c4/odroid-c4
> 
> Beniamino Galvani (2):
>   arm: dts: import ODROID-C4 device tree

The DT is not yet applied by kevin, thus I'll prefer waiting it to be accepted
and merged in a stable linux tree to keep DT synced.

>   boards: amlogic: add ODROID-C4 support

Please re-use the w400 board instead of adding a new board, there is no need for a new
one until you'll need to add more functionalities.

I know meson_generate_serial_ethaddr() is absent from w400, I'll add it shortly.

Neil

> 
>  arch/arm/dts/Makefile                |   1 +
>  arch/arm/dts/meson-sm1-odroid-c4.dts | 399 +++++++++++++++++++++++++++
>  board/amlogic/odroid-c4/MAINTAINERS  |   6 +
>  board/amlogic/odroid-c4/Makefile     |   3 +
>  board/amlogic/odroid-c4/README       |  83 ++++++
>  board/amlogic/odroid-c4/odroid-c4.c  |  17 ++
>  configs/odroid-c4_defconfig          |  63 +++++
>  7 files changed, 572 insertions(+)
>  create mode 100644 arch/arm/dts/meson-sm1-odroid-c4.dts
>  create mode 100644 board/amlogic/odroid-c4/MAINTAINERS
>  create mode 100644 board/amlogic/odroid-c4/Makefile
>  create mode 100644 board/amlogic/odroid-c4/README
>  create mode 100644 board/amlogic/odroid-c4/odroid-c4.c
>  create mode 100644 configs/odroid-c4_defconfig
>
Beniamino Galvani May 7, 2020, 7:28 p.m. UTC | #2 
On Wed, May 06, 2020 at 09:59:17AM +0200, Neil Armstrong wrote:
> Hi Beniamino,
> 
> On 05/05/2020 22:22, Beniamino Galvani wrote:
> > Hi,
> > 
> > these two patches add initial u-boot support for Hardkernel ODROID-C4.
> 
> Thanks for the patchset, I already have one in my test tree, by you did beat me
> by sending it to the list !

Oh, I didn't notice, sorry.

> > https://wiki.odroid.com/odroid-c4/odroid-c4
> > 
> > Beniamino Galvani (2):
> >   arm: dts: import ODROID-C4 device tree
> 
> The DT is not yet applied by kevin, thus I'll prefer waiting it to be accepted
> and merged in a stable linux tree to keep DT synced.
> 
> >   boards: amlogic: add ODROID-C4 support
> 
> Please re-use the w400 board instead of adding a new board, there is no need for a new
> one until you'll need to add more functionalities.
> 
> I know meson_generate_serial_ethaddr() is absent from w400, I'll add it shortly.

Okay, I'll wait that the DT gets merged and then will resubmit using w400.

Thanks,
Beniamino