mbox series

[v2,0/7] ddr: altera: arria10: Convert SDRAM driver to DM

Message ID 20200420084624.110026-1-ley.foon.tan@intel.com
Headers show
Series ddr: altera: arria10: Convert SDRAM driver to DM | expand

Message

Tan, Ley Foon April 20, 2020, 8:46 a.m. UTC
This patchset mainly to covert Arria 10 SDRAM driver to device model
and fixes few bugs in driver. It also added RAM size check function
to check valid RAM.

v1->v2:
- Update Patch[1] commit description
- Change debug() to printf() if failed to probe SDRAM driver in SPL. [Patch 2]
- Change to use MACRO(n) to calculate register address. [Patch 2]
- Call to reset_assert_bulk() if failed in _probe(). [Patch 3]
- Change SZ_1G to full SDRAM size in get_ram_size() argument. [Patch 5]
- Patch 4, 6 and 7 unchanged.

Ley Foon Tan (7):
  ddr: altera: arria10: Fix incorrect address for mpu1
  ddr: altera: arria10: Move SDRAM driver to DM
  ddr: altera: arria10: Change to use reset DM function
  arm: socfpga: arria10: Move sdram_arria10.h to drivers/ddr/altera
  ddr: altera: arria10: Add RAM size check
  ddr: altera: arria10: Change %i to %u for printf
  ddr: altera: arria10: Remove call to dram_init_banksize()

 arch/arm/dts/socfpga_arria10-u-boot.dtsi      |   8 +
 .../include/mach/reset_manager_arria10.h      |   1 -
 arch/arm/mach-socfpga/include/mach/sdram.h    |   2 +-
 arch/arm/mach-socfpga/misc_arria10.c          |   2 +-
 arch/arm/mach-socfpga/reset_manager_arria10.c |   7 -
 arch/arm/mach-socfpga/spl_a10.c               |  14 +-
 drivers/ddr/altera/Kconfig                    |   4 +-
 drivers/ddr/altera/sdram_arria10.c            | 382 ++++++++++--------
 .../ddr/altera}/sdram_arria10.h               | 225 ++---------
 9 files changed, 285 insertions(+), 360 deletions(-)
 rename {arch/arm/mach-socfpga/include/mach => drivers/ddr/altera}/sdram_arria10.h (72%)

Comments

Tan, Ley Foon April 27, 2020, 7:08 a.m. UTC | #1
> -----Original Message-----
> From: Tan, Ley Foon <ley.foon.tan at intel.com>
> Sent: Monday, April 20, 2020 4:46 PM
> To: u-boot at lists.denx.de
> Cc: Marek Vasut <marex at denx.de>; Ley Foon Tan <lftan.linux at gmail.com>;
> See, Chin Liang <chin.liang.see at intel.com>; Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com>; Chee, Tien Fong
> <tien.fong.chee at intel.com>; Tan, Ley Foon <ley.foon.tan at intel.com>
> Subject: [PATCH v2 0/7] ddr: altera: arria10: Convert SDRAM driver to DM
> 
> This patchset mainly to covert Arria 10 SDRAM driver to device model and
> fixes few bugs in driver. It also added RAM size check function to check valid
> RAM.
> 
> v1->v2:
> - Update Patch[1] commit description
> - Change debug() to printf() if failed to probe SDRAM driver in SPL. [Patch 2]
> - Change to use MACRO(n) to calculate register address. [Patch 2]
> - Call to reset_assert_bulk() if failed in _probe(). [Patch 3]
> - Change SZ_1G to full SDRAM size in get_ram_size() argument. [Patch 5]
> - Patch 4, 6 and 7 unchanged.
> 
> Ley Foon Tan (7):
>   ddr: altera: arria10: Fix incorrect address for mpu1
>   ddr: altera: arria10: Move SDRAM driver to DM
>   ddr: altera: arria10: Change to use reset DM function
>   arm: socfpga: arria10: Move sdram_arria10.h to drivers/ddr/altera
>   ddr: altera: arria10: Add RAM size check
>   ddr: altera: arria10: Change %i to %u for printf
>   ddr: altera: arria10: Remove call to dram_init_banksize()
> 
>  arch/arm/dts/socfpga_arria10-u-boot.dtsi      |   8 +
>  .../include/mach/reset_manager_arria10.h      |   1 -
>  arch/arm/mach-socfpga/include/mach/sdram.h    |   2 +-
>  arch/arm/mach-socfpga/misc_arria10.c          |   2 +-
>  arch/arm/mach-socfpga/reset_manager_arria10.c |   7 -
>  arch/arm/mach-socfpga/spl_a10.c               |  14 +-
>  drivers/ddr/altera/Kconfig                    |   4 +-
>  drivers/ddr/altera/sdram_arria10.c            | 382 ++++++++++--------
>  .../ddr/altera}/sdram_arria10.h               | 225 ++---------
>  9 files changed, 285 insertions(+), 360 deletions(-)  rename {arch/arm/mach-
> socfpga/include/mach => drivers/ddr/altera}/sdram_arria10.h (72%)
> 
> --
> 2.19.0
Hi 

Any further comment on this patchset?

Thanks.

Regards
Ley Foon