| Message ID | 20200409201506.133129-1-sjg@chromium.org |
|---|---|
| Headers | show |
| Series | common: Further reduce the size of common.h | expand |
On Thu, Apr 09, 2020 at 02:14:44PM -0600, Simon Glass wrote: > This is yet another series to remove the contents of common.h so that > individual files include the headers they need. > > With this series there are only 14 includes left. > > In order to get this far the commits include a number of small clean-ups: > > - Fixing code style like 'udelay (2)' to 'udelay(1) > - Dropping typedefs so that forward struct declarations can be used > - Actually adding common.h in a few files where it is missing (thus > causing inconsistent blk.h config in EFI, for example) > > Unfortunately removing a header from common.h does not always just affect > the files that rely on that header. For example, removing net.h from > common.h created problems since net.h itself includes a lots of headers. > Rather than blindly add net.h to each of those files, I chose to add what > those files actually needed. > > Changes in v2: > - Split out code-style changes for flash functions into a new patch > - Split out code-style changes for log functions into a new patch > - Split out code-style changes for time functions into a new patch > - Add new patch to fix occurances of __ASSEMBLER__ > > Simon Glass (22): > common: Drop uuid.h from common header > flash: Tidy up coding style for flash functions > common: Drop flash.h from common header > arm: Don't include common.h in header files > common: Drop net.h from common header > part: Drop disk_partition_t typedef > common: Drop part.h from common header > bootstage: Use BOOTSTAGE instead of BOOTSTATE > common: Drop bootstage.h from common header > common: Drop image.h from common header > common: Drop init.h from common header > command: Remove the cmd_tbl_t typedef > Fix some checkpatch warnings in calls to debug() > common: Drop log.h from common header > common: Drop asm/ptrace.h from common header > common: Drop asm_offsets.h from common header > common: Drop linux/bug.h from common header > common: Drop linux/stringify.h from common header > Fix some checkpatch warnings in calls to udelay() > common: Drop linux/delay.h from common header > Use __ASSEMBLY__ as the assembly macros > common: Drop linux/bitops.h from common header I rebased up to patch 13 before things started getting really hairy. Can you please rebase and resend the series? Thanks!
Hi Tom, On Fri, 8 May 2020 at 12:37, Tom Rini <trini at konsulko.com> wrote: > > On Thu, Apr 09, 2020 at 02:14:44PM -0600, Simon Glass wrote: > > > This is yet another series to remove the contents of common.h so that > > individual files include the headers they need. > > > > With this series there are only 14 includes left. > > > > In order to get this far the commits include a number of small clean-ups: > > > > - Fixing code style like 'udelay (2)' to 'udelay(1) > > - Dropping typedefs so that forward struct declarations can be used > > - Actually adding common.h in a few files where it is missing (thus > > causing inconsistent blk.h config in EFI, for example) > > > > Unfortunately removing a header from common.h does not always just affect > > the files that rely on that header. For example, removing net.h from > > common.h created problems since net.h itself includes a lots of headers. > > Rather than blindly add net.h to each of those files, I chose to add what > > those files actually needed. > > > > Changes in v2: > > - Split out code-style changes for flash functions into a new patch > > - Split out code-style changes for log functions into a new patch > > - Split out code-style changes for time functions into a new patch > > - Add new patch to fix occurances of __ASSEMBLER__ > > > > Simon Glass (22): > > common: Drop uuid.h from common header > > flash: Tidy up coding style for flash functions > > common: Drop flash.h from common header > > arm: Don't include common.h in header files > > common: Drop net.h from common header > > part: Drop disk_partition_t typedef > > common: Drop part.h from common header > > bootstage: Use BOOTSTAGE instead of BOOTSTATE > > common: Drop bootstage.h from common header > > common: Drop image.h from common header > > common: Drop init.h from common header > > command: Remove the cmd_tbl_t typedef > > Fix some checkpatch warnings in calls to debug() > > common: Drop log.h from common header > > common: Drop asm/ptrace.h from common header > > common: Drop asm_offsets.h from common header > > common: Drop linux/bug.h from common header > > common: Drop linux/stringify.h from common header > > Fix some checkpatch warnings in calls to udelay() > > common: Drop linux/delay.h from common header > > Use __ASSEMBLY__ as the assembly macros > > common: Drop linux/bitops.h from common header > > I rebased up to patch 13 before things started getting really hairy. > Can you please rebase and resend the series? Thanks! Yes sadly it needs quite a few changes. Will resend later today. I have at least one more series like this. Do you think it would be better to generate it at RC1 to avoid the churn caused by new boards, etc.? Regards, Simon