| Message ID | 20200324151705.1798021-1-lusus@denx.de |
|---|---|
| Headers | show |
| Series | cmd: add driver, fs and part type listing commands | expand |
Dear Tom, for patch series all review comments have been resolved, and the latest version has seen no further comments, but it has not been pulled either. Is any further action required to get this into mainline? > This series adds commands for listing the supported partition tables, > listing supported filesystems and expands Driver Model listing commands. > > The existing "dm drivers" command, which lists the DM drivers and their > compatibility strings, segmentation faulted on drivers for which of_match > was unpopulated (which appears to not be uncommon). This was fixed, and > the command was renamed "dm compat", and a new more extensive "dm drivers" > command was added, which list all DM drivers and for each, their uclass > id, uclass driver and the device names for active driver instances. The > purpose is show available drivers, but also to highlight unused drivers > or drivers with uclass ids without uclass drivers, etc. > > The following commands were added: > -"part types", lists partition tables supported > -"fstypes", lists filesystem types supported > -"dm compat", lists drivers and their compatibility strings (equivalent > to existing "dm drivers" command) > -"dm drivers", lists all DM drivers, and for each their uclass id, > uclass driver and the device names for active driver instances. > -"dm static", lists all DM drivers which use static platform data > (instead of the device tree). > > These patches were tested in the Sandbox and on the Wandboard > i.MX6Quad Board rev B1. > > Changes in v2: > - Rebased on https://patchwork.ozlabs.org/patch/1234460/ > - Added Python tests > - Fixed minor typographical errors > Changes in v3: > - Rewrote comment for do_fs_types() in fs.h > > Niel Fourie (3): > cmd: part: Add subcommand to list supported partition tables > cmd: fs: Add command to list supported fs types > cmd: dm: Fixed/Added DM driver listing subcommands > > cmd/dm.c | 22 ++++++++++- > cmd/fs.c | 11 ++++++ > cmd/part.c | 27 +++++++++++++- > drivers/core/dump.c | 55 +++++++++++++++++++++++++++- > fs/fs.c | 20 ++++++++++ > include/dm/util.h | 6 +++ > include/fs.h | 11 ++++++ > test/py/tests/test_dm.py | 22 ++++++++++- > test/py/tests/test_fs/test_fs_cmd.py | 12 ++++++ > test/py/tests/test_part.py | 14 +++++++ > 10 files changed, 194 insertions(+), 6 deletions(-) > create mode 100644 test/py/tests/test_fs/test_fs_cmd.py > create mode 100644 test/py/tests/test_part.py Best regards, Wolfgang Denk
On Tue, May 26, 2020 at 09:57:19AM +0200, Wolfgang Denk wrote: > Dear Tom, > > for patch series all review comments have been resolved, and the > latest version has seen no further comments, but it has not been > pulled either. > > Is any further action required to get this into mainline? Ah, sorry. It's on my list to grab and see what the size growth is, since there's new features in generic code. I'll try and get to that soon.
Hi Tom, On Tue, 26 May 2020 at 13:24, Tom Rini <trini at konsulko.com> wrote: > > On Tue, May 26, 2020 at 09:57:19AM +0200, Wolfgang Denk wrote: > > > Dear Tom, > > > > for patch series all review comments have been resolved, and the > > latest version has seen no further comments, but it has not been > > pulled either. > > > > Is any further action required to get this into mainline? > > Ah, sorry. It's on my list to grab and see what the size growth is, > since there's new features in generic code. I'll try and get to that > soon. I pushed a rebased tree to u-boot-dm/try-fs (due to cmd_tbl_t change). Size growth on firefly-rk3288 is: 04: cmd: dm: Fixed/Added DM driver listing subcommands arm: (for 1/1 boards) all +1434.0 bss +20.0 data +84.0 rodata +468.0 text +862.0 Regards, Simon