mbox series

[v5,00/10] Add support for loading main_r5fss0_core0

Message ID 20200128105115.21604-1-j-keerthy@ti.com
Headers show
Series Add support for loading main_r5fss0_core0 | expand

Message

Keerthy Jan. 28, 2020, 10:51 a.m. UTC
This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
Tested for firmware loading and execution on J721e.

Changes in v5:

  * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
  * Added more information on the envnowhere patch.
  * Added help LIB_ELF option and removed user configurable description.

Changes in v4:

  * Changed env variable names, config names and enhanced commit logs.

Changes in v3:

  * Removed saving env in MMC and fixed env saving in SPL when nowhere
    option is set.

Changes in v2:

  * Factored out all the generic elf handling functions under lib/elf.c 

Keerthy (10):
  env: nowhere: set default enviroment
  lib: elf: Move the generic elf loading/validating functions to lib
  arm: k3: Add support for loading non linux remote cores
  armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM
  armv7R: K3: Add support for jumping to firmware
  arm: dts: k3-j721e-r5-u-boot: Add fs_loader node
  arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL
  include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 &
    main_r5fss0_core0
  configs: j721e_evm_r5: Enable R5F remoteproc support
  configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC

 .../k3-j721e-r5-common-proc-board-u-boot.dtsi |  27 ++
 .../arm/dts/k3-j721e-r5-common-proc-board.dts |   2 +
 arch/arm/mach-k3/common.c                     | 106 +++++++-
 arch/arm/mach-k3/common.h                     |   2 +
 arch/arm/mach-k3/j721e_init.c                 |  34 +++
 arch/arm/mach-k3/r5_mpu.c                     |   4 +-
 cmd/Kconfig                                   |   1 +
 cmd/elf.c                                     | 229 ----------------
 configs/j721e_evm_r5_defconfig                |   6 +-
 env/nowhere.c                                 |   1 +
 include/configs/j721e_evm.h                   |   4 +
 include/elf.h                                 |   4 +
 lib/Kconfig                                   |   6 +
 lib/Makefile                                  |   1 +
 lib/elf.c                                     | 256 ++++++++++++++++++
 15 files changed, 438 insertions(+), 245 deletions(-)
 create mode 100644 arch/arm/dts/k3-j721e-r5-common-proc-board-u-boot.dtsi
 create mode 100644 lib/elf.c

Comments

Lokesh Vutla Jan. 29, 2020, 2:35 a.m. UTC | #1
On 28/01/20 4:21 PM, Keerthy wrote:
> This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
> Tested for firmware loading and execution on J721e.
> 
> Changes in v5:
> 
>   * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
>   * Added more information on the envnowhere patch.
>   * Added help LIB_ELF option and removed user configurable description.

There are many build errors with this series.

https://travis-ci.org/lokeshvutla/u-boot/builds/642979303

Thanks and regards,
Lokesh

> 
> Changes in v4:
> 
>   * Changed env variable names, config names and enhanced commit logs.
> 
> Changes in v3:
> 
>   * Removed saving env in MMC and fixed env saving in SPL when nowhere
>     option is set.
> 
> Changes in v2:
> 
>   * Factored out all the generic elf handling functions under lib/elf.c 
> 
> Keerthy (10):
>   env: nowhere: set default enviroment
>   lib: elf: Move the generic elf loading/validating functions to lib
>   arm: k3: Add support for loading non linux remote cores
>   armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM
>   armv7R: K3: Add support for jumping to firmware
>   arm: dts: k3-j721e-r5-u-boot: Add fs_loader node
>   arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL
>   include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 &
>     main_r5fss0_core0
>   configs: j721e_evm_r5: Enable R5F remoteproc support
>   configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC
> 
>  .../k3-j721e-r5-common-proc-board-u-boot.dtsi |  27 ++
>  .../arm/dts/k3-j721e-r5-common-proc-board.dts |   2 +
>  arch/arm/mach-k3/common.c                     | 106 +++++++-
>  arch/arm/mach-k3/common.h                     |   2 +
>  arch/arm/mach-k3/j721e_init.c                 |  34 +++
>  arch/arm/mach-k3/r5_mpu.c                     |   4 +-
>  cmd/Kconfig                                   |   1 +
>  cmd/elf.c                                     | 229 ----------------
>  configs/j721e_evm_r5_defconfig                |   6 +-
>  env/nowhere.c                                 |   1 +
>  include/configs/j721e_evm.h                   |   4 +
>  include/elf.h                                 |   4 +
>  lib/Kconfig                                   |   6 +
>  lib/Makefile                                  |   1 +
>  lib/elf.c                                     | 256 ++++++++++++++++++
>  15 files changed, 438 insertions(+), 245 deletions(-)
>  create mode 100644 arch/arm/dts/k3-j721e-r5-common-proc-board-u-boot.dtsi
>  create mode 100644 lib/elf.c
>
Keerthy Jan. 29, 2020, 4:28 a.m. UTC | #2
On 29/01/20 8:05 am, Lokesh Vutla wrote:
> 
> 
> On 28/01/20 4:21 PM, Keerthy wrote:
>> This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
>> Tested for firmware loading and execution on J721e.
>>
>> Changes in v5:
>>
>>    * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
>>    * Added more information on the envnowhere patch.
>>    * Added help LIB_ELF option and removed user configurable description.
> 
> There are many build errors with this series.
> 
> https://travis-ci.org/lokeshvutla/u-boot/builds/642979303

Ah there is a static declaration of load_elf_image_phdr in 
arch/arm/mach-imx/imx_bootaux.c

Should i send a fix patch alone on top?

> 
> Thanks and regards,
> Lokesh
> 
>>
>> Changes in v4:
>>
>>    * Changed env variable names, config names and enhanced commit logs.
>>
>> Changes in v3:
>>
>>    * Removed saving env in MMC and fixed env saving in SPL when nowhere
>>      option is set.
>>
>> Changes in v2:
>>
>>    * Factored out all the generic elf handling functions under lib/elf.c
>>
>> Keerthy (10):
>>    env: nowhere: set default enviroment
>>    lib: elf: Move the generic elf loading/validating functions to lib
>>    arm: k3: Add support for loading non linux remote cores
>>    armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM
>>    armv7R: K3: Add support for jumping to firmware
>>    arm: dts: k3-j721e-r5-u-boot: Add fs_loader node
>>    arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL
>>    include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 &
>>      main_r5fss0_core0
>>    configs: j721e_evm_r5: Enable R5F remoteproc support
>>    configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC
>>
>>   .../k3-j721e-r5-common-proc-board-u-boot.dtsi |  27 ++
>>   .../arm/dts/k3-j721e-r5-common-proc-board.dts |   2 +
>>   arch/arm/mach-k3/common.c                     | 106 +++++++-
>>   arch/arm/mach-k3/common.h                     |   2 +
>>   arch/arm/mach-k3/j721e_init.c                 |  34 +++
>>   arch/arm/mach-k3/r5_mpu.c                     |   4 +-
>>   cmd/Kconfig                                   |   1 +
>>   cmd/elf.c                                     | 229 ----------------
>>   configs/j721e_evm_r5_defconfig                |   6 +-
>>   env/nowhere.c                                 |   1 +
>>   include/configs/j721e_evm.h                   |   4 +
>>   include/elf.h                                 |   4 +
>>   lib/Kconfig                                   |   6 +
>>   lib/Makefile                                  |   1 +
>>   lib/elf.c                                     | 256 ++++++++++++++++++
>>   15 files changed, 438 insertions(+), 245 deletions(-)
>>   create mode 100644 arch/arm/dts/k3-j721e-r5-common-proc-board-u-boot.dtsi
>>   create mode 100644 lib/elf.c
>>
Tom Rini Jan. 29, 2020, 3:57 p.m. UTC | #3
On Wed, Jan 29, 2020 at 09:58:41AM +0530, Keerthy wrote:
> 
> 
> On 29/01/20 8:05 am, Lokesh Vutla wrote:
> > 
> > 
> > On 28/01/20 4:21 PM, Keerthy wrote:
> > > This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
> > > Tested for firmware loading and execution on J721e.
> > > 
> > > Changes in v5:
> > > 
> > >    * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
> > >    * Added more information on the envnowhere patch.
> > >    * Added help LIB_ELF option and removed user configurable description.
> > 
> > There are many build errors with this series.
> > 
> > https://travis-ci.org/lokeshvutla/u-boot/builds/642979303
> 
> Ah there is a static declaration of load_elf_image_phdr in
> arch/arm/mach-imx/imx_bootaux.c
> 
> Should i send a fix patch alone on top?

You should integrate reworking it into your series and please CC Stefano
Babic and Fabio Estevam and Igor Opaniuk for testing / review.  Thanks!