mbox series

[v5,00/12] ClearFog Base static variant support

Message ID 20200127200156.15173-1-mrjoel@lixil.net
Headers show
Series ClearFog Base static variant support | expand

Message

Joel Johnson Jan. 27, 2020, 8:01 p.m. UTC 
This patch series adds support for ClearFog Base static configuration,
as well as updating and fixing the ClearFog support for MMC and SPI
booting.

v2 changes:
  - updated against, and dependent on, https://patchwork.ozlabs.org/cover/1200324
v3 changes:
  - rebased against ClearFog runtime TLV EEPROM changes merged into mvebu/master
v4
  - adjust static SerDes configuration at runtime instead of #ifdef
v5
  - distinguish build-only config changes (SFP and PCIe/SATA) from
    runtime detectable config changes
  - retested SATA mode in PCIe slot with swap rx changes, confirmed
    working as presently patched. Only tested with ClearFog Base which
    only provides single channel, but Pro mechanism is parallel.


Joel Johnson (12):
  arm: mvebu: fix SerDes table alignment
  arm: mvebu: solidrun: remove hardcoded DTS MAC address
  arm: mvebu: clearfog: use Pro name by default
  arm: mvebu: clearfog: initial ClearFog Base variant
  arm: mvebu: clearfog: Add option for 2.5 Gbps SFP
  arm: mvebu: clearfog: Add SATA mode flags
  arm: mvebu: clearfog: Unify DT selection paths
  arm: mvebu: clearfog: add SPI offsets
  arm: mvebu: enable working default boot support
  arm: mvebu: clearfog: move ENV params to Kconfig
  arm: mvebu: clearfog: don't always use SPL MMC
  arm: mvebu: clearfog: Use Pro DT by default

 .../arm/dts/armada-38x-solidrun-microsom.dtsi |  1 -
 arch/arm/mach-mvebu/Kconfig                   | 13 ++++
 .../serdes/a38x/high_speed_env_spec.c         |  6 +-
 board/solidrun/clearfog/Kconfig               | 62 +++++++++++++++++++
 board/solidrun/clearfog/clearfog.c            | 53 +++++++++++++---
 configs/clearfog_defconfig                    |  4 --
 include/configs/clearfog.h                    |  1 -
 7 files changed, 124 insertions(+), 16 deletions(-)
 create mode 100644 board/solidrun/clearfog/Kconfig

Comments

Joel Johnson March 22, 2020, 6:46 p.m. UTC | #1 
I just wanted to ping on this review 
(http://patchwork.ozlabs.org/project/uboot/list/?series=155533) to see 
if it had reached an agreeable state or if there were still lingering 
issues. I've been using it without issue against RC releases.

If the plan is to not include it in v2020.04 that's completely 
reasonable, but I would request review and feedback on blocking issues, 
otherwise does it have general agreement for merging in the next merge 
window?

Thanks,
Joel

On 2020-01-27 13:01, Joel Johnson wrote:
> This patch series adds support for ClearFog Base static configuration,
> as well as updating and fixing the ClearFog support for MMC and SPI
> booting.
> 
> v2 changes:
>   - updated against, and dependent on,
> https://patchwork.ozlabs.org/cover/1200324
> v3 changes:
>   - rebased against ClearFog runtime TLV EEPROM changes merged into 
> mvebu/master
> v4
>   - adjust static SerDes configuration at runtime instead of #ifdef
> v5
>   - distinguish build-only config changes (SFP and PCIe/SATA) from
>     runtime detectable config changes
>   - retested SATA mode in PCIe slot with swap rx changes, confirmed
>     working as presently patched. Only tested with ClearFog Base which
>     only provides single channel, but Pro mechanism is parallel.
> 
> 
> Joel Johnson (12):
>   arm: mvebu: fix SerDes table alignment
>   arm: mvebu: solidrun: remove hardcoded DTS MAC address
>   arm: mvebu: clearfog: use Pro name by default
>   arm: mvebu: clearfog: initial ClearFog Base variant
>   arm: mvebu: clearfog: Add option for 2.5 Gbps SFP
>   arm: mvebu: clearfog: Add SATA mode flags
>   arm: mvebu: clearfog: Unify DT selection paths
>   arm: mvebu: clearfog: add SPI offsets
>   arm: mvebu: enable working default boot support
>   arm: mvebu: clearfog: move ENV params to Kconfig
>   arm: mvebu: clearfog: don't always use SPL MMC
>   arm: mvebu: clearfog: Use Pro DT by default
> 
>  .../arm/dts/armada-38x-solidrun-microsom.dtsi |  1 -
>  arch/arm/mach-mvebu/Kconfig                   | 13 ++++
>  .../serdes/a38x/high_speed_env_spec.c         |  6 +-
>  board/solidrun/clearfog/Kconfig               | 62 +++++++++++++++++++
>  board/solidrun/clearfog/clearfog.c            | 53 +++++++++++++---
>  configs/clearfog_defconfig                    |  4 --
>  include/configs/clearfog.h                    |  1 -
>  7 files changed, 124 insertions(+), 16 deletions(-)
>  create mode 100644 board/solidrun/clearfog/Kconfig
Stefan Roese March 23, 2020, 9:03 a.m. UTC | #2 
Hi Joel,

On 22.03.20 19:46, Joel Johnson wrote:
> I just wanted to ping on this review 
> (http://patchwork.ozlabs.org/project/uboot/list/?series=155533) to see 
> if it had reached an agreeable state or if there were still lingering 
> issues. I've been using it without issue against RC releases.
> 
> If the plan is to not include it in v2020.04 that's completely 
> reasonable, but I would request review and feedback on blocking issues, 
> otherwise does it have general agreement for merging in the next merge 
> window?

I won't pull this into v2020.04 as you might understand. I was hoping to
get some reviews and testing from people with access to those boards.

Baruch, could you please check again, if you agree with this approach?
Or do you have some change request for this build-time vs run-time
detection?

Thanks,
Stefan

> Thanks,
> Joel
> 
> On 2020-01-27 13:01, Joel Johnson wrote:
>> This patch series adds support for ClearFog Base static configuration,
>> as well as updating and fixing the ClearFog support for MMC and SPI
>> booting.
>>
>> v2 changes:
>> ? - updated against, and dependent on,
>> https://patchwork.ozlabs.org/cover/1200324
>> v3 changes:
>> ? - rebased against ClearFog runtime TLV EEPROM changes merged into 
>> mvebu/master
>> v4
>> ? - adjust static SerDes configuration at runtime instead of #ifdef
>> v5
>> ? - distinguish build-only config changes (SFP and PCIe/SATA) from
>> ??? runtime detectable config changes
>> ? - retested SATA mode in PCIe slot with swap rx changes, confirmed
>> ??? working as presently patched. Only tested with ClearFog Base which
>> ??? only provides single channel, but Pro mechanism is parallel.
>>
>>
>> Joel Johnson (12):
>> ? arm: mvebu: fix SerDes table alignment
>> ? arm: mvebu: solidrun: remove hardcoded DTS MAC address
>> ? arm: mvebu: clearfog: use Pro name by default
>> ? arm: mvebu: clearfog: initial ClearFog Base variant
>> ? arm: mvebu: clearfog: Add option for 2.5 Gbps SFP
>> ? arm: mvebu: clearfog: Add SATA mode flags
>> ? arm: mvebu: clearfog: Unify DT selection paths
>> ? arm: mvebu: clearfog: add SPI offsets
>> ? arm: mvebu: enable working default boot support
>> ? arm: mvebu: clearfog: move ENV params to Kconfig
>> ? arm: mvebu: clearfog: don't always use SPL MMC
>> ? arm: mvebu: clearfog: Use Pro DT by default
>>
>> ?.../arm/dts/armada-38x-solidrun-microsom.dtsi |? 1 -
>> ?arch/arm/mach-mvebu/Kconfig?????????????????? | 13 ++++
>> ?.../serdes/a38x/high_speed_env_spec.c???????? |? 6 +-
>> ?board/solidrun/clearfog/Kconfig?????????????? | 62 +++++++++++++++++++
>> ?board/solidrun/clearfog/clearfog.c??????????? | 53 +++++++++++++---
>> ?configs/clearfog_defconfig??????????????????? |? 4 --
>> ?include/configs/clearfog.h??????????????????? |? 1 -
>> ?7 files changed, 124 insertions(+), 16 deletions(-)
>> ?create mode 100644 board/solidrun/clearfog/Kconfig


Viele Gr??e,
Stefan
Baruch Siach March 23, 2020, 4:59 p.m. UTC | #3 
Hi Stefan,

On Mon, Mar 23 2020, Stefan Roese wrote:
> On 22.03.20 19:46, Joel Johnson wrote:
>> I just wanted to ping on this review
>> (http://patchwork.ozlabs.org/project/uboot/list/?series=155533) to see if it
>> had reached an agreeable state or if there were still lingering issues. I've
>> been using it without issue against RC releases.
>>
>> If the plan is to not include it in v2020.04 that's completely reasonable,
>> but I would request review and feedback on blocking issues, otherwise does
>> it have general agreement for merging in the next merge window?
>
> I won't pull this into v2020.04 as you might understand. I was hoping to
> get some reviews and testing from people with access to those boards.
>
> Baruch, could you please check again, if you agree with this approach?
> Or do you have some change request for this build-time vs run-time
> detection?

This series is the end result of discussions between Joel and me on the
list with a few iterations. I am fine with this result, and I think it
is good to go. I can't test these patches at the moment. Hope to do that
some time later.

Thanks,
baruch

>> On 2020-01-27 13:01, Joel Johnson wrote:
>>> This patch series adds support for ClearFog Base static configuration,
>>> as well as updating and fixing the ClearFog support for MMC and SPI
>>> booting.
>>>
>>> v2 changes:
>>>   - updated against, and dependent on,
>>> https://patchwork.ozlabs.org/cover/1200324
>>> v3 changes:
>>>   - rebased against ClearFog runtime TLV EEPROM changes merged into
>>> mvebu/master
>>> v4
>>>   - adjust static SerDes configuration at runtime instead of #ifdef
>>> v5
>>>   - distinguish build-only config changes (SFP and PCIe/SATA) from
>>>     runtime detectable config changes
>>>   - retested SATA mode in PCIe slot with swap rx changes, confirmed
>>>     working as presently patched. Only tested with ClearFog Base which
>>>     only provides single channel, but Pro mechanism is parallel.
>>>
>>>
>>> Joel Johnson (12):
>>>   arm: mvebu: fix SerDes table alignment
>>>   arm: mvebu: solidrun: remove hardcoded DTS MAC address
>>>   arm: mvebu: clearfog: use Pro name by default
>>>   arm: mvebu: clearfog: initial ClearFog Base variant
>>>   arm: mvebu: clearfog: Add option for 2.5 Gbps SFP
>>>   arm: mvebu: clearfog: Add SATA mode flags
>>>   arm: mvebu: clearfog: Unify DT selection paths
>>>   arm: mvebu: clearfog: add SPI offsets
>>>   arm: mvebu: enable working default boot support
>>>   arm: mvebu: clearfog: move ENV params to Kconfig
>>>   arm: mvebu: clearfog: don't always use SPL MMC
>>>   arm: mvebu: clearfog: Use Pro DT by default
>>>
>>>  .../arm/dts/armada-38x-solidrun-microsom.dtsi |  1 -
>>>  arch/arm/mach-mvebu/Kconfig                   | 13 ++++
>>>  .../serdes/a38x/high_speed_env_spec.c         |  6 +-
>>>  board/solidrun/clearfog/Kconfig               | 62 +++++++++++++++++++
>>>  board/solidrun/clearfog/clearfog.c            | 53 +++++++++++++---
>>>  configs/clearfog_defconfig                    |  4 --
>>>  include/configs/clearfog.h                    |  1 -
>>>  7 files changed, 124 insertions(+), 16 deletions(-)
>>>  create mode 100644 board/solidrun/clearfog/Kconfig
>
>
> Viele Gr??e,
> Stefan


--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -