From patchwork Thu Jul 19 22:28:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 142383 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2255205ljj; Thu, 19 Jul 2018 15:28:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeaA5nKTe2XqZJJKKWmQcaGKFgKbcqHKk30JFwv9H+qRiNrXG8EgNthKGFkvj2+Dvk4nm/P X-Received: by 2002:a50:f4d2:: with SMTP id v18-v6mr13216498edm.162.1532039334409; Thu, 19 Jul 2018 15:28:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532039334; cv=none; d=google.com; s=arc-20160816; b=edqrCSBdLMELltdcurw4BigJzmvo4EtXiOGSe8c4rNVf4WmkRi3HX8nSfXlLIytHpD 1+W1rqcK5GcCXEGIgIyrnNXFJ2X/addwPoM7ZY/Ga+y5ibEoLGrwAaoc/SSDePmAo+Bm 5D1QiQh5DljdXptKMyKNFaaAcNelK708d2ZRCTYoqPCtTfohnAF1GGzvQ85YaaIHQ4vq m5p5CkZGeBpI+REleYErfkG/2x6hLio9JQeyEQJKQRDplbjxK6WyS+oVvFQcweb+7iLT vytoHbgKhKj2YZbrbom7ethueyy/wx4rcYp8ULG6noqE0DXz0d9NuTIv0GtTHbWzxN/O NsyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=HO1A2l+fV3o7FxYnvqV1UejE6uLYt2Of3ux7Qzr+ZR0=; b=DtKnn5kLjklc65R3dkHmXWtUqtbEL19SJCSJwD9mW3YWHIveRzWJjAFSoGw0kddK5W 6Bqzny0vaJ+I6OS3KyW327JQOBzS4cRjiDilJuPptc0lHn19mO2WqiqxOqTrkmJrVjpq UHqTFdYcL2XlOGfJ6hZM8t/Vdt3gXjbebOPdv103jw+kSd3cy2rmEK65KNK1fUhWucsY YfQkseFXdKz/9lMZYLfcW5e/4xxm3fK63btBS6UprpenZnEtG3jXWt8VKcwlR6dwKJXb 8hf79Omet5VJZTDNX188+/IEeafP1764o4GgsO4XEZdDLkMsW0U4w6OWrXRFR/J5JK/Q 3kog== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HkaEJ71k; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id k32-v6si554458edc.340.2018.07.19.15.28.53; Thu, 19 Jul 2018 15:28:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HkaEJ71k; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.denx.de (Postfix, from userid 105) id 610A1C21E45; Thu, 19 Jul 2018 22:28:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8119EC21C27; Thu, 19 Jul 2018 22:28:46 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D9A32C21C27; Thu, 19 Jul 2018 22:28:45 +0000 (UTC) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by lists.denx.de (Postfix) with ESMTPS id 737D7C21BE5 for ; Thu, 19 Jul 2018 22:28:45 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id v9-v6so9510301ljk.4 for ; Thu, 19 Jul 2018 15:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=DGEwqqNLjmHRmOuxNg9cdhYDCP0fZhhL6/EZG2w0EfA=; b=HkaEJ71k6JGJJaEx7H7KAUbw5dKOiV+9DSQsTo0n/qRF4/iSIyL1M4h9RqLIJYG/QU Beu7+l9/8JjZR/fcTZt+hv+1X+3fs9ruWH4MXsf4D7hK2H2e7X7pU3o+ZYuWct2cboAq 09rtj8f1G8Bu0Ky3PxzCEaA0MZkgyUWBoOEB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DGEwqqNLjmHRmOuxNg9cdhYDCP0fZhhL6/EZG2w0EfA=; b=eoygWtrFGOsVs3pOjM6gNWbU+n774AOheDbre3YbezapHHLpJYWY5c9c8UTuKeToOI Xre6VKCmVPztRuOuIHpmG+y2sQkGH2ksdJxgCXqxKvwc0/VdPMvOyk+u8VXdlUx/oRGh UXgWlX8ZsEPdPXau2coWHbTx8WlMqXr1g2qzepFc0DclJGnhDQEjxK7AUSrJbLDaNhRV U32Eibs9iz+mXv49DXQvZEop2DXf9oX8mnumT03JAnEFQNVBiFre2c5p+OQkMGrd4Gkc i5vxo7MfdDRLLC1K7h7/5ekjWCpoGfchmngMRIwszlE8JbHWd1izciZdeght/x3Yncvf CV0A== X-Gm-Message-State: AOUpUlGJUx2ejNzIGgHPCIpPMImq3aL+MAWed5TM5ea4YIOKdhGJ10R1 uNgoe6yG4VKstRHy/ecUDZxet1dOTZaukg== X-Received: by 2002:a2e:5759:: with SMTP id r25-v6mr8793081ljd.125.1532039324575; Thu, 19 Jul 2018 15:28:44 -0700 (PDT) Received: from localhost ([195.238.92.132]) by smtp.gmail.com with ESMTPSA id y74-v6sm43814lfi.61.2018.07.19.15.28.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Jul 2018 15:28:43 -0700 (PDT) From: Sam Protsenko To: u-boot@lists.denx.de Date: Fri, 20 Jul 2018 01:28:41 +0300 Message-Id: <20180719222843.28316-1-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.18.0 Cc: Maxime Ripard , Tom Rini Subject: [U-Boot] [RFC PATCH v3 0/2] env: Make environment loading log more clear X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This is another attempt to make boot log better, without hackery this time. Basically here we just remove unwanted error messages, relying on the message from most deep API to be printed (like mmc subsystem). This approach *might* have its shortcomings, though: 1. With no "Failed" message, at some point we *can* end up with no error messages printed at all 2. Removing some collateral error messages *may* lead to loss of useful debug info in other use-cases (env_load() is not only user of those APIs). That being said, at the moment this looks like most clean solution to cluttered log problem, as any other solution either will be hackish or will require some big architectural changes. If one of mentioned shortcomings occur, we can fix it ad hoc. With this patch set applied we will see something like this: Loading Environment from FAT... MMC: no card present Loading Environment from MMC... OK instead of: Loading Environment from FAT... MMC: no card present ** Bad device mmc 0 ** Failed (-5) Loading Environment from MMC... OK Sam Protsenko (2): env: Don't print "Failed" error message disk: part: Remove redundant error message disk/part.c | 1 - env/env.c | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-)