Message ID | 1583744842-24632-1-git-send-email-chee.hong.ang@intel.com |
---|---|
Headers | show |
Series | Enable ARM Trusted Firmware for U-Boot | expand |
Am 09.03.2020 um 10:07 schrieb chee.hong.ang at intel.com: > From: "Ang, Chee Hong" <chee.hong.ang at intel.com> > > v4 changes: > [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager > - Add System Manager driver (UCLASS_MISC) to handle secure access for SoC64 > > [PATCH v4 13/21] mmc: dwmmc: socfpga: MMC driver access System Manager via 'altera_sysmgr' > - DW MMC driver access System Manager via the System Manager driver > > [PATCH v4 14/21] arch: arm: socfpga: Add 'altr,sysmgr-syscon' for MMC > - DW MMC driver get DRVSEL & SMPLSEL clock settings from device tree > > [PATCH v4 15/21] net: designware: socfpga: MAC driver access System via 'altera_sysmgr' > - DW MAC driver access System Manager via the System Manager driver > > v3: > https://lists.denx.de/pipermail/u-boot/2020-February/400986.html > > These patchsets have dependency on: > https://lists.denx.de/pipermail/u-boot/2019-September/384906.html > > Chee Hong Ang (21): > configs: agilex: Remove CONFIG_OF_EMBED > arm: socfpga: add fit source file for pack itb with ATF > arm: socfpga: Add function for checking description from FIT image > arm: socfpga: Load FIT image with ATF support > arm: socfpga: Override 'lowlevel_init' to support ATF > configs: socfpga: Enable FIT image loading with ATF support > arm: socfpga: Disable "spin-table" method for booting Linux > arm: socfpga: Add SMC helper function for Intel SOCFPGA (64bits) > arm: socfpga: Define SMC function identifiers for PSCI SiP services > arm: socfpga: soc64: Remove PHY interface setup from misc arch init > misc: altera_sysmgr: Add Altera System Manager driver > arch: arm: socfpga: Enable driver model for misc drivers. > mmc: dwmmc: socfpga: MMC driver access System Manager via > 'altera_sysmgr' > arch: arm: socfpga: Add 'altr,sysmgr-syscon' for MMC node in device > tree > net: designware: socfpga: MAC driver access System Manager via > 'altera_sysmgr' > arm: socfpga: Add ATF support for Reset Manager driver > arm: socfpga: stratix10: Initialize timer in SPL > arm: socfpga: Add ATF support to query FPGA configuration status > arm: socfpga: stratix10: Add ATF support for FPGA reconfig driver > arm: socfpga: mailbox: Add 'SYSTEM_RESET' PSCI support to > mbox_reset_cold() > configs: socfpga: Add defconfig for Agilex and Stratix 10 without ATF > support Are you sure building all previously existing defconfigs keeps working with every single commit here? If not, that would break 'git bisect' in the future... I have the feeling that things might be broken in between - escpecially since you're adding the 'old' "without ATF" defconfig in the last patch. I think it would make more sense to keep the old defconfig name, keep it building correctly throughout this series and add a "with ATF" defconfig at the end. That way, you ensure existing usages keep working. Regards, Simon > > arch/arm/Kconfig | 2 + > arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 1 + > arch/arm/dts/socfpga_arria10_socdk_sdmmc.dts | 1 + > arch/arm/dts/socfpga_arria5_socdk-u-boot.dtsi | 1 + > arch/arm/dts/socfpga_cyclone5.dtsi | 1 + > arch/arm/dts/socfpga_stratix10.dtsi | 1 - > arch/arm/dts/socfpga_stratix10_socdk-u-boot.dtsi | 7 + > arch/arm/dts/socfpga_stratix10_socdk.dts | 2 - > arch/arm/mach-socfpga/Kconfig | 2 - > arch/arm/mach-socfpga/Makefile | 2 + > arch/arm/mach-socfpga/board.c | 10 + > arch/arm/mach-socfpga/include/mach/misc.h | 3 + > arch/arm/mach-socfpga/lowlevel_init_64.S | 81 +++++ > arch/arm/mach-socfpga/mailbox_s10.c | 4 + > arch/arm/mach-socfpga/misc_s10.c | 121 ++----- > arch/arm/mach-socfpga/reset_manager_s10.c | 10 + > arch/arm/mach-socfpga/timer_s10.c | 3 +- > board/altera/soc64/its/fit_spl_atf.its | 52 +++ > configs/socfpga_agilex_defconfig | 8 +- > ...lex_defconfig => socfpga_agilex_nofw_defconfig} | 2 +- > configs/socfpga_stratix10_defconfig | 7 +- > ..._defconfig => socfpga_stratix10_nofw_defconfig} | 2 +- > drivers/fpga/stratix10.c | 141 +++++++- > drivers/misc/Makefile | 1 + > drivers/misc/altera_sysmgr.c | 115 ++++++ > drivers/mmc/socfpga_dw_mmc.c | 63 +++- > drivers/net/dwmac_socfpga.c | 37 +- > include/configs/socfpga_soc64_common.h | 4 + > include/linux/intel-smc.h | 393 +++++++++++++++++++++ > 29 files changed, 955 insertions(+), 122 deletions(-) > create mode 100644 arch/arm/mach-socfpga/lowlevel_init_64.S > create mode 100644 board/altera/soc64/its/fit_spl_atf.its > copy configs/{socfpga_agilex_defconfig => socfpga_agilex_nofw_defconfig} (97%) > copy configs/{socfpga_stratix10_defconfig => socfpga_stratix10_nofw_defconfig} (97%) > create mode 100644 drivers/misc/altera_sysmgr.c > create mode 100644 include/linux/intel-smc.h >
> Am 09.03.2020 um 10:07 schrieb chee.hong.ang at intel.com: > > From: "Ang, Chee Hong" <chee.hong.ang at intel.com> > > > > v4 changes: > > [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager > > - Add System Manager driver (UCLASS_MISC) to handle secure access for > > SoC64 > > > > [PATCH v4 13/21] mmc: dwmmc: socfpga: MMC driver access System > Manager via 'altera_sysmgr' > > - DW MMC driver access System Manager via the System Manager driver > > > > [PATCH v4 14/21] arch: arm: socfpga: Add 'altr,sysmgr-syscon' for MMC > > - DW MMC driver get DRVSEL & SMPLSEL clock settings from device tree > > > > [PATCH v4 15/21] net: designware: socfpga: MAC driver access System via > 'altera_sysmgr' > > - DW MAC driver access System Manager via the System Manager driver > > > > v3: > > https://lists.denx.de/pipermail/u-boot/2020-February/400986.html > > > > These patchsets have dependency on: > > https://lists.denx.de/pipermail/u-boot/2019-September/384906.html > > > > Chee Hong Ang (21): > > configs: agilex: Remove CONFIG_OF_EMBED > > arm: socfpga: add fit source file for pack itb with ATF > > arm: socfpga: Add function for checking description from FIT image > > arm: socfpga: Load FIT image with ATF support > > arm: socfpga: Override 'lowlevel_init' to support ATF > > configs: socfpga: Enable FIT image loading with ATF support > > arm: socfpga: Disable "spin-table" method for booting Linux > > arm: socfpga: Add SMC helper function for Intel SOCFPGA (64bits) > > arm: socfpga: Define SMC function identifiers for PSCI SiP services > > arm: socfpga: soc64: Remove PHY interface setup from misc arch init > > misc: altera_sysmgr: Add Altera System Manager driver > > arch: arm: socfpga: Enable driver model for misc drivers. > > mmc: dwmmc: socfpga: MMC driver access System Manager via > > 'altera_sysmgr' > > arch: arm: socfpga: Add 'altr,sysmgr-syscon' for MMC node in device > > tree > > net: designware: socfpga: MAC driver access System Manager via > > 'altera_sysmgr' > > arm: socfpga: Add ATF support for Reset Manager driver > > arm: socfpga: stratix10: Initialize timer in SPL > > arm: socfpga: Add ATF support to query FPGA configuration status > > arm: socfpga: stratix10: Add ATF support for FPGA reconfig driver > > arm: socfpga: mailbox: Add 'SYSTEM_RESET' PSCI support to > > mbox_reset_cold() > > configs: socfpga: Add defconfig for Agilex and Stratix 10 without ATF > > support > > Are you sure building all previously existing defconfigs keeps working with every > single commit here? If not, that would break 'git bisect' in the future... I will test this. > > I have the feeling that things might be broken in between - escpecially since > you're adding the 'old' "without ATF" defconfig in the last patch. > I think it would make more sense to keep the old defconfig name, keep it > building correctly throughout this series and add a "with ATF" defconfig at the > end. That way, you ensure existing usages keep working. OK. > > Regards, > Simon > > > > > arch/arm/Kconfig | 2 + > > arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 1 + > > arch/arm/dts/socfpga_arria10_socdk_sdmmc.dts | 1 + > > arch/arm/dts/socfpga_arria5_socdk-u-boot.dtsi | 1 + > > arch/arm/dts/socfpga_cyclone5.dtsi | 1 + > > arch/arm/dts/socfpga_stratix10.dtsi | 1 - > > arch/arm/dts/socfpga_stratix10_socdk-u-boot.dtsi | 7 + > > arch/arm/dts/socfpga_stratix10_socdk.dts | 2 - > > arch/arm/mach-socfpga/Kconfig | 2 - > > arch/arm/mach-socfpga/Makefile | 2 + > > arch/arm/mach-socfpga/board.c | 10 + > > arch/arm/mach-socfpga/include/mach/misc.h | 3 + > > arch/arm/mach-socfpga/lowlevel_init_64.S | 81 +++++ > > arch/arm/mach-socfpga/mailbox_s10.c | 4 + > > arch/arm/mach-socfpga/misc_s10.c | 121 ++----- > > arch/arm/mach-socfpga/reset_manager_s10.c | 10 + > > arch/arm/mach-socfpga/timer_s10.c | 3 +- > > board/altera/soc64/its/fit_spl_atf.its | 52 +++ > > configs/socfpga_agilex_defconfig | 8 +- > > ...lex_defconfig => socfpga_agilex_nofw_defconfig} | 2 +- > > configs/socfpga_stratix10_defconfig | 7 +- > > ..._defconfig => socfpga_stratix10_nofw_defconfig} | 2 +- > > drivers/fpga/stratix10.c | 141 +++++++- > > drivers/misc/Makefile | 1 + > > drivers/misc/altera_sysmgr.c | 115 ++++++ > > drivers/mmc/socfpga_dw_mmc.c | 63 +++- > > drivers/net/dwmac_socfpga.c | 37 +- > > include/configs/socfpga_soc64_common.h | 4 + > > include/linux/intel-smc.h | 393 +++++++++++++++++++++ > > 29 files changed, 955 insertions(+), 122 deletions(-) create mode > > 100644 arch/arm/mach-socfpga/lowlevel_init_64.S > > create mode 100644 board/altera/soc64/its/fit_spl_atf.its > > copy configs/{socfpga_agilex_defconfig => > > socfpga_agilex_nofw_defconfig} (97%) copy > > configs/{socfpga_stratix10_defconfig => > > socfpga_stratix10_nofw_defconfig} (97%) create mode 100644 > > drivers/misc/altera_sysmgr.c create mode 100644 > > include/linux/intel-smc.h > >
From: "Ang, Chee Hong" <chee.hong.ang at intel.com> v4 changes: [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager - Add System Manager driver (UCLASS_MISC) to handle secure access for SoC64 [PATCH v4 13/21] mmc: dwmmc: socfpga: MMC driver access System Manager via 'altera_sysmgr' - DW MMC driver access System Manager via the System Manager driver [PATCH v4 14/21] arch: arm: socfpga: Add 'altr,sysmgr-syscon' for MMC - DW MMC driver get DRVSEL & SMPLSEL clock settings from device tree [PATCH v4 15/21] net: designware: socfpga: MAC driver access System via 'altera_sysmgr' - DW MAC driver access System Manager via the System Manager driver v3: https://lists.denx.de/pipermail/u-boot/2020-February/400986.html These patchsets have dependency on: https://lists.denx.de/pipermail/u-boot/2019-September/384906.html Chee Hong Ang (21): configs: agilex: Remove CONFIG_OF_EMBED arm: socfpga: add fit source file for pack itb with ATF arm: socfpga: Add function for checking description from FIT image arm: socfpga: Load FIT image with ATF support arm: socfpga: Override 'lowlevel_init' to support ATF configs: socfpga: Enable FIT image loading with ATF support arm: socfpga: Disable "spin-table" method for booting Linux arm: socfpga: Add SMC helper function for Intel SOCFPGA (64bits) arm: socfpga: Define SMC function identifiers for PSCI SiP services arm: socfpga: soc64: Remove PHY interface setup from misc arch init misc: altera_sysmgr: Add Altera System Manager driver arch: arm: socfpga: Enable driver model for misc drivers. mmc: dwmmc: socfpga: MMC driver access System Manager via 'altera_sysmgr' arch: arm: socfpga: Add 'altr,sysmgr-syscon' for MMC node in device tree net: designware: socfpga: MAC driver access System Manager via 'altera_sysmgr' arm: socfpga: Add ATF support for Reset Manager driver arm: socfpga: stratix10: Initialize timer in SPL arm: socfpga: Add ATF support to query FPGA configuration status arm: socfpga: stratix10: Add ATF support for FPGA reconfig driver arm: socfpga: mailbox: Add 'SYSTEM_RESET' PSCI support to mbox_reset_cold() configs: socfpga: Add defconfig for Agilex and Stratix 10 without ATF support arch/arm/Kconfig | 2 + arch/arm/dts/socfpga_agilex_socdk-u-boot.dtsi | 1 + arch/arm/dts/socfpga_arria10_socdk_sdmmc.dts | 1 + arch/arm/dts/socfpga_arria5_socdk-u-boot.dtsi | 1 + arch/arm/dts/socfpga_cyclone5.dtsi | 1 + arch/arm/dts/socfpga_stratix10.dtsi | 1 - arch/arm/dts/socfpga_stratix10_socdk-u-boot.dtsi | 7 + arch/arm/dts/socfpga_stratix10_socdk.dts | 2 - arch/arm/mach-socfpga/Kconfig | 2 - arch/arm/mach-socfpga/Makefile | 2 + arch/arm/mach-socfpga/board.c | 10 + arch/arm/mach-socfpga/include/mach/misc.h | 3 + arch/arm/mach-socfpga/lowlevel_init_64.S | 81 +++++ arch/arm/mach-socfpga/mailbox_s10.c | 4 + arch/arm/mach-socfpga/misc_s10.c | 121 ++----- arch/arm/mach-socfpga/reset_manager_s10.c | 10 + arch/arm/mach-socfpga/timer_s10.c | 3 +- board/altera/soc64/its/fit_spl_atf.its | 52 +++ configs/socfpga_agilex_defconfig | 8 +- ...lex_defconfig => socfpga_agilex_nofw_defconfig} | 2 +- configs/socfpga_stratix10_defconfig | 7 +- ..._defconfig => socfpga_stratix10_nofw_defconfig} | 2 +- drivers/fpga/stratix10.c | 141 +++++++- drivers/misc/Makefile | 1 + drivers/misc/altera_sysmgr.c | 115 ++++++ drivers/mmc/socfpga_dw_mmc.c | 63 +++- drivers/net/dwmac_socfpga.c | 37 +- include/configs/socfpga_soc64_common.h | 4 + include/linux/intel-smc.h | 393 +++++++++++++++++++++ 29 files changed, 955 insertions(+), 122 deletions(-) create mode 100644 arch/arm/mach-socfpga/lowlevel_init_64.S create mode 100644 board/altera/soc64/its/fit_spl_atf.its copy configs/{socfpga_agilex_defconfig => socfpga_agilex_nofw_defconfig} (97%) copy configs/{socfpga_stratix10_defconfig => socfpga_stratix10_nofw_defconfig} (97%) create mode 100644 drivers/misc/altera_sysmgr.c create mode 100644 include/linux/intel-smc.h