mbox series

[0/4] Add Cortina Access basic DM drivers

Message ID 1579513995-1822-1-git-send-email-alex.nemirovsky@cortina-access.com
Headers show
Series Add Cortina Access basic DM drivers | expand

Message

Alex Nemirovsky Jan. 20, 2020, 9:53 a.m. UTC
This series contains a set of basic DM drivers compatible
with Cortina Access ARM and MIPS series of SoCs.


Jason Li (4):
  gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs
  gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs
  watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs
  serial: serial_cortina: add UART DM driver for CAxxxx SoCs

 MAINTAINERS                     |   8 +++
 arch/arm/include/asm/gpio.h     |   2 +-
 drivers/gpio/Kconfig            |   8 +++
 drivers/gpio/Makefile           |   1 +
 drivers/gpio/cortina_gpio.c     | 113 +++++++++++++++++++++++++++++++
 drivers/serial/Kconfig          |   7 ++
 drivers/serial/Makefile         |   2 +-
 drivers/serial/serial_cortina.c | 129 +++++++++++++++++++++++++++++++++++
 drivers/serial/serial_cortina.h |  83 +++++++++++++++++++++++
 drivers/watchdog/Kconfig        |   8 +++
 drivers/watchdog/Makefile       |   1 +
 drivers/watchdog/cortina_wdt.c  | 144 ++++++++++++++++++++++++++++++++++++++++
 12 files changed, 504 insertions(+), 2 deletions(-)
 create mode 100644 drivers/gpio/cortina_gpio.c
 create mode 100644 drivers/serial/serial_cortina.c
 create mode 100644 drivers/serial/serial_cortina.h
 create mode 100644 drivers/watchdog/cortina_wdt.c

Comments

Andy Shevchenko Jan. 20, 2020, 11:39 a.m. UTC | #1
On Mon, Jan 20, 2020 at 09:53:31AM +0000, Alex Nemirovsky wrote:
> This series contains a set of basic DM drivers compatible
> with Cortina Access ARM and MIPS series of SoCs.

I'm not sure why my name appeared in the Cc list.

Please, remove it in the next versions if it's not related to me, otherwise,
please be explicit why my participation is needed.

> 
> 
> Jason Li (4):
>   gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs
>   gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs
>   watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs
>   serial: serial_cortina: add UART DM driver for CAxxxx SoCs
> 
>  MAINTAINERS                     |   8 +++
>  arch/arm/include/asm/gpio.h     |   2 +-
>  drivers/gpio/Kconfig            |   8 +++
>  drivers/gpio/Makefile           |   1 +
>  drivers/gpio/cortina_gpio.c     | 113 +++++++++++++++++++++++++++++++
>  drivers/serial/Kconfig          |   7 ++
>  drivers/serial/Makefile         |   2 +-
>  drivers/serial/serial_cortina.c | 129 +++++++++++++++++++++++++++++++++++
>  drivers/serial/serial_cortina.h |  83 +++++++++++++++++++++++
>  drivers/watchdog/Kconfig        |   8 +++
>  drivers/watchdog/Makefile       |   1 +
>  drivers/watchdog/cortina_wdt.c  | 144 ++++++++++++++++++++++++++++++++++++++++
>  12 files changed, 504 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/gpio/cortina_gpio.c
>  create mode 100644 drivers/serial/serial_cortina.c
>  create mode 100644 drivers/serial/serial_cortina.h
>  create mode 100644 drivers/watchdog/cortina_wdt.c
> 
> -- 
> 2.7.4
>
Igor Opaniuk Jan. 20, 2020, 12:11 p.m. UTC | #2
Hi Andy,

On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Mon, Jan 20, 2020 at 09:53:31AM +0000, Alex Nemirovsky wrote:
> > This series contains a set of basic DM drivers compatible
> > with Cortina Access ARM and MIPS series of SoCs.
>
> I'm not sure why my name appeared in the Cc list.
I assume this is patman/get_maintainers.pl who added your email.
That's usually done when MAINTAINERS is changed.

>
> Please, remove it in the next versions if it's not related to me, otherwise,
> please be explicit why my participation is needed.
>
> >
> >
> > Jason Li (4):
> >   gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs
> >   gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs
> >   watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs
> >   serial: serial_cortina: add UART DM driver for CAxxxx SoCs
> >
> >  MAINTAINERS                     |   8 +++
> >  arch/arm/include/asm/gpio.h     |   2 +-
> >  drivers/gpio/Kconfig            |   8 +++
> >  drivers/gpio/Makefile           |   1 +
> >  drivers/gpio/cortina_gpio.c     | 113 +++++++++++++++++++++++++++++++
> >  drivers/serial/Kconfig          |   7 ++
> >  drivers/serial/Makefile         |   2 +-
> >  drivers/serial/serial_cortina.c | 129 +++++++++++++++++++++++++++++++++++
> >  drivers/serial/serial_cortina.h |  83 +++++++++++++++++++++++
> >  drivers/watchdog/Kconfig        |   8 +++
> >  drivers/watchdog/Makefile       |   1 +
> >  drivers/watchdog/cortina_wdt.c  | 144 ++++++++++++++++++++++++++++++++++++++++
> >  12 files changed, 504 insertions(+), 2 deletions(-)
> >  create mode 100644 drivers/gpio/cortina_gpio.c
> >  create mode 100644 drivers/serial/serial_cortina.c
> >  create mode 100644 drivers/serial/serial_cortina.h
> >  create mode 100644 drivers/watchdog/cortina_wdt.c
> >
> > --
> > 2.7.4
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Andy Shevchenko Jan. 20, 2020, 2:07 p.m. UTC | #3
On Mon, Jan 20, 2020 at 02:11:20PM +0200, Igor Opaniuk wrote:
> On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> >
> > On Mon, Jan 20, 2020 at 09:53:31AM +0000, Alex Nemirovsky wrote:
> > > This series contains a set of basic DM drivers compatible
> > > with Cortina Access ARM and MIPS series of SoCs.
> >
> > I'm not sure why my name appeared in the Cc list.
> I assume this is patman/get_maintainers.pl who added your email.

Somebody needs to learn how to exclude not relevant people?

> That's usually done when MAINTAINERS is changed.

Where? I didn't get this.

> >
> > Please, remove it in the next versions if it's not related to me, otherwise,
> > please be explicit why my participation is needed.
> >
> > >
> > >
> > > Jason Li (4):
> > >   gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs
> > >   gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs
> > >   watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs
> > >   serial: serial_cortina: add UART DM driver for CAxxxx SoCs
> > >
> > >  MAINTAINERS                     |   8 +++
> > >  arch/arm/include/asm/gpio.h     |   2 +-
> > >  drivers/gpio/Kconfig            |   8 +++
> > >  drivers/gpio/Makefile           |   1 +
> > >  drivers/gpio/cortina_gpio.c     | 113 +++++++++++++++++++++++++++++++
> > >  drivers/serial/Kconfig          |   7 ++
> > >  drivers/serial/Makefile         |   2 +-
> > >  drivers/serial/serial_cortina.c | 129 +++++++++++++++++++++++++++++++++++
> > >  drivers/serial/serial_cortina.h |  83 +++++++++++++++++++++++
> > >  drivers/watchdog/Kconfig        |   8 +++
> > >  drivers/watchdog/Makefile       |   1 +
> > >  drivers/watchdog/cortina_wdt.c  | 144 ++++++++++++++++++++++++++++++++++++++++
> > >  12 files changed, 504 insertions(+), 2 deletions(-)
> > >  create mode 100644 drivers/gpio/cortina_gpio.c
> > >  create mode 100644 drivers/serial/serial_cortina.c
> > >  create mode 100644 drivers/serial/serial_cortina.h
> > >  create mode 100644 drivers/watchdog/cortina_wdt.c
Igor Opaniuk Jan. 20, 2020, 2:16 p.m. UTC | #4
On Mon, Jan 20, 2020 at 4:07 PM Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Mon, Jan 20, 2020 at 02:11:20PM +0200, Igor Opaniuk wrote:
> > On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko
> > <andriy.shevchenko at linux.intel.com> wrote:
> > >
> > > On Mon, Jan 20, 2020 at 09:53:31AM +0000, Alex Nemirovsky wrote:
> > > > This series contains a set of basic DM drivers compatible
> > > > with Cortina Access ARM and MIPS series of SoCs.
> > >
> > > I'm not sure why my name appeared in the Cc list.
> > I assume this is patman/get_maintainers.pl who added your email.
>
> Somebody needs to learn how to exclude not relevant people?
Patman does this automatically.

>
> > That's usually done when MAINTAINERS is changed.
>
> Where? I didn't get this.
Look below

>
> > >
> > > Please, remove it in the next versions if it's not related to me, otherwise,
> > > please be explicit why my participation is needed.
> > >
> > > >
> > > >
> > > > Jason Li (4):
> > > >   gpio: do not include <asm/arch/gpio.h> for Cortina CAxxxx SoCs
> > > >   gpio: cortina_gpio: add DM_GPIO driver for CAxxxx SoCs
> > > >   watchdog: cortina_wdt: add support for HW WDT on CAxxxx SoCs
> > > >   serial: serial_cortina: add UART DM driver for CAxxxx SoCs
> > > >
> > > >  MAINTAINERS                     |   8 +++
Here?

> > > >  arch/arm/include/asm/gpio.h     |   2 +-
> > > >  drivers/gpio/Kconfig            |   8 +++
> > > >  drivers/gpio/Makefile           |   1 +
> > > >  drivers/gpio/cortina_gpio.c     | 113 +++++++++++++++++++++++++++++++
> > > >  drivers/serial/Kconfig          |   7 ++
> > > >  drivers/serial/Makefile         |   2 +-
> > > >  drivers/serial/serial_cortina.c | 129 +++++++++++++++++++++++++++++++++++
> > > >  drivers/serial/serial_cortina.h |  83 +++++++++++++++++++++++
> > > >  drivers/watchdog/Kconfig        |   8 +++
> > > >  drivers/watchdog/Makefile       |   1 +
> > > >  drivers/watchdog/cortina_wdt.c  | 144 ++++++++++++++++++++++++++++++++++++++++
> > > >  12 files changed, 504 insertions(+), 2 deletions(-)
> > > >  create mode 100644 drivers/gpio/cortina_gpio.c
> > > >  create mode 100644 drivers/serial/serial_cortina.c
> > > >  create mode 100644 drivers/serial/serial_cortina.h
> > > >  create mode 100644 drivers/watchdog/cortina_wdt.c
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Andy Shevchenko Jan. 20, 2020, 2:53 p.m. UTC | #5
On Mon, Jan 20, 2020 at 04:16:53PM +0200, Igor Opaniuk wrote:
> On Mon, Jan 20, 2020 at 4:07 PM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> > On Mon, Jan 20, 2020 at 02:11:20PM +0200, Igor Opaniuk wrote:
> > > On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko
> > > <andriy.shevchenko at linux.intel.com> wrote:
> > > > On Mon, Jan 20, 2020 at 09:53:31AM +0000, Alex Nemirovsky wrote:
> > > > > This series contains a set of basic DM drivers compatible
> > > > > with Cortina Access ARM and MIPS series of SoCs.

> > > > I'm not sure why my name appeared in the Cc list.
> > > I assume this is patman/get_maintainers.pl who added your email.
> >
> > Somebody needs to learn how to exclude not relevant people?
> Patman does this automatically.

Hmm... Sounds like a bug in the tool.

> > > That's usually done when MAINTAINERS is changed.
> >
> > Where? I didn't get this.
> Look below

> > > > >  MAINTAINERS                     |   8 +++
> Here?

Okay, and I still didn't get why it adds my name to the Cc. Is any of that
change related to what I'm keeping an eye on?

P.S. To the core U-Boot maintainers, perhaps somebody, who knows that tooling,
may eventually fix it to avoid spamming people on unrelated matters?
Simon Glass Jan. 30, 2020, 2:18 a.m. UTC | #6
Hi Andy,

On Mon, 20 Jan 2020 at 07:53, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> On Mon, Jan 20, 2020 at 04:16:53PM +0200, Igor Opaniuk wrote:
> > On Mon, Jan 20, 2020 at 4:07 PM Andy Shevchenko
> > <andriy.shevchenko at linux.intel.com> wrote:
> > > On Mon, Jan 20, 2020 at 02:11:20PM +0200, Igor Opaniuk wrote:
> > > > On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko
> > > > <andriy.shevchenko at linux.intel.com> wrote:
> > > > > On Mon, Jan 20, 2020 at 09:53:31AM +0000, Alex Nemirovsky wrote:
> > > > > > This series contains a set of basic DM drivers compatible
> > > > > > with Cortina Access ARM and MIPS series of SoCs.
>
> > > > > I'm not sure why my name appeared in the Cc list.
> > > > I assume this is patman/get_maintainers.pl who added your email.
> > >
> > > Somebody needs to learn how to exclude not relevant people?
> > Patman does this automatically.
>
> Hmm... Sounds like a bug in the tool.
>
> > > > That's usually done when MAINTAINERS is changed.
> > >
> > > Where? I didn't get this.
> > Look below
>
> > > > > >  MAINTAINERS                     |   8 +++
> > Here?
>
> Okay, and I still didn't get why it adds my name to the Cc. Is any of that
> change related to what I'm keeping an eye on?
>
> P.S. To the core U-Boot maintainers, perhaps somebody, who knows that tooling,
> may eventually fix it to avoid spamming people on unrelated matters?

You can try something like this.

cat >asc
(copy in the diffstat)
ctrl-D
for f in $(cat asc |cut -d' ' -f1-2 |tr '\n' ' '); do echo $f;
./scripts/get_maintainer.pl -f $f |grep intel; done

In this case:

drivers/watchdog/Kconfig
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
(added_lines:8/103=8%,removed_lines:9/77=12%)
drivers/watchdog/Makefile
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
(commit_signer:1/7=14%,authored:1/7=14%,added_lines:1/6=17%,removed_lines:1/4=25%)

You have 5 commits in that directory.

Regards,
Simon