From patchwork Thu Mar 5 21:44:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 229835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37E4C3F2D1 for ; Thu, 5 Mar 2020 21:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2FA52072A for ; Thu, 5 Mar 2020 21:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583444975; bh=H78Lm9TQHOU3gAmn7HUttW+H0xtY4FMruh1AGaJQgHQ=; h=From:Date:Subject:To:Cc:Reply-to:List-ID:From; b=2nk/FnDnPYmJE2yAqFnoF/DGSV89Sx0VC5806RFYSRZu9hbV0LW1YDNsRVr1UdHTe JlCzn3/6B8omcH9RNxArzUN40v5qKUy2ZM0Sck6dpgRz4ZReBIAwFiu4WukwWiZUt9 5CP/81QCrb78fCPhH77lFmnwYda9qy2V6fBB9a6I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726049AbgCEVtf (ORCPT ); Thu, 5 Mar 2020 16:49:35 -0500 Received: from www.linuxtv.org ([130.149.80.248]:48800 "EHLO www.linuxtv.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgCEVtf (ORCPT ); Thu, 5 Mar 2020 16:49:35 -0500 Received: from mchehab by www.linuxtv.org with local (Exim 4.92) (envelope-from ) id 1j9yLC-004Drb-6S; Thu, 05 Mar 2020 21:47:38 +0000 From: Mauro Carvalho Chehab Date: Thu, 05 Mar 2020 21:44:06 +0000 Subject: [git:media_tree/master] media: v4l2-core: fix a use-after-free bug of sd->devnode To: linuxtv-commits@linuxtv.org Cc: Dafna Hirschfeld , Ezequiel Garcia , stable@vger.kernel.org, Hans Verkuil Mail-followup-to: linux-media@vger.kernel.org Forward-to: linux-media@vger.kernel.org Reply-to: linux-media@vger.kernel.org Message-Id: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is an automatic generated email to let you know that the following patch were queued: Subject: media: v4l2-core: fix a use-after-free bug of sd->devnode Author: Dafna Hirschfeld Date: Wed Feb 19 16:25:54 2020 +0100 sd->devnode is released after calling v4l2_subdev_release. Therefore it should be set to NULL so that the subdev won't hold a pointer to a released object. This fixes a reference after free bug in function v4l2_device_unregister_subdev Fixes: 0e43734d4c46e ("media: v4l2-subdev: add release() internal op") Cc: stable@vger.kernel.org Signed-off-by: Dafna Hirschfeld Reviewed-by: Ezequiel Garcia Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab drivers/media/v4l2-core/v4l2-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-device.c b/drivers/media/v4l2-core/v4l2-device.c index 63d6b147b21e..41da73ce2e98 100644 --- a/drivers/media/v4l2-core/v4l2-device.c +++ b/drivers/media/v4l2-core/v4l2-device.c @@ -179,6 +179,7 @@ static void v4l2_subdev_release(struct v4l2_subdev *sd) if (sd->internal_ops && sd->internal_ops->release) sd->internal_ops->release(sd); + sd->devnode = NULL; module_put(owner); }