From patchwork Thu Apr 14 15:21:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 562203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41719C433F5 for ; Thu, 14 Apr 2022 15:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346293AbiDNQBa (ORCPT ); Thu, 14 Apr 2022 12:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354449AbiDNPlE (ORCPT ); Thu, 14 Apr 2022 11:41:04 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44060DF493 for ; Thu, 14 Apr 2022 08:21:37 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id 14so3290989ily.11 for ; Thu, 14 Apr 2022 08:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=edIWwPKPDITXLPsh4Wu0h7S7XlZhTTuZiRx0vaBerYE=; b=sODaZuzK6WFQwdSPsSvBlmvjyC6uQsBG6yaQonMlvj+BWLAWXowycsPUCs3gEkIfos +3IRShz1y5QLm0C4clEjtjDUqmiUZw7dYFg7SkcEDDSKlBlmuthHMZ4wbrJJ5xGhRF2g 6+FbEeg+13WMR+MBoBbZldVLQB5Jg//bS7qjVligSpjcSthJw9QefQFOkopFHDRQq65h UTz3simjnU1R0zcKFiljfah+lXMZ80cn/BRts7k1WzPOQYxUp63IJcGU2wSyfLFpUT7u xq+zffIJXzQYu74Abg/eHf1j8HVZmOfE060yOwVVPTFWV6I3PMU054CLFraVv+eF3IhL 36uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=edIWwPKPDITXLPsh4Wu0h7S7XlZhTTuZiRx0vaBerYE=; b=gyeqo8KFB8UdogAfkzbzGNMDDsnn0aYYqKdMs4YGwGfE3GO5jb3YrbZnhmnVl+X/In uaEOu9w/CwifPu7lcF2lzlqqPqjBC1WnB6AnRMyzds7laTEeEH7kQiDMib7hrVvPwfs8 UXS6irc7Y4p39mB51X3L1b4NOn/pwOQJfkhjCDIKlncMUKFA9wyTqFkCUeGsMNnLn5or Czg5fZ02sNq2fXHFvOa+X6gXc8IHoVInN3yUyb3zbJLGzR3mR20WfO1uTEITowy5xIDy LNz9faBenwkji1e5tu1m4ujP8QMt1QyCnINecWeSbYeN7T07gIq/Al3A+YBjusKtjtnX vMqQ== X-Gm-Message-State: AOAM532VILwC7R82BIzpHUpIWfIjaZb0yo2FHWjKgDWO+wJjQqxXVQhw zSFk85kD0mo6M1A9IuokvohzB/9Dlt2lLw== X-Google-Smtp-Source: ABdhPJxPF3hsNkxjcclHg68S4IqDQdJbmqDUlzpmwr3KIPxP5d9SL5wHmXW19c7JOnL+LdTpTiDD1A== X-Received: by 2002:a05:6e02:12e9:b0:2c9:f576:8951 with SMTP id l9-20020a056e0212e900b002c9f5768951mr1310684iln.204.1649949696279; Thu, 14 Apr 2022 08:21:36 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id x2-20020a056602160200b006463c1977f9sm1365395iow.22.2022.04.14.08.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 08:21:35 -0700 (PDT) From: Alex Elder To: stable@vger.kernel.org Cc: Deepak Kumar Singh , quic_clew@quicinc.com, quic_deesin@quicinc.com, swboyd@chromium.org, kuba@kernel.org, bjorn.andersson@linaro.org, elder@kernel.org, gregkh@linuxfoundation.org Subject: [PATCH v2 1/3] soc: qcom: aoss: Expose send for generic usecase Date: Thu, 14 Apr 2022 10:21:29 -0500 Message-Id: <20220414152131.713724-2-elder@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220414152131.713724-1-elder@linaro.org> References: <20220414152131.713724-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Deepak Kumar Singh commit 8c75d585b931ac874fbe4ee5a8f1811d20c2817f upstream. Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own messages to aoss. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/1630420228-31075-2-git-send-email-deesin@codeaurora.org Signed-off-by: Alex Elder --- drivers/soc/qcom/qcom_aoss.c | 54 +++++++++++++++++++++++++++++- include/linux/soc/qcom/qcom_aoss.h | 38 +++++++++++++++++++++ 2 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 include/linux/soc/qcom/qcom_aoss.h diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index a0659cf278456..d40d8e20ceb46 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -8,10 +8,12 @@ #include #include #include +#include #include #include #include #include +#include #define QMP_DESC_MAGIC 0x0 #define QMP_DESC_VERSION 0x4 @@ -223,11 +225,14 @@ static bool qmp_message_empty(struct qmp *qmp) * * Return: 0 on success, negative errno on failure */ -static int qmp_send(struct qmp *qmp, const void *data, size_t len) +int qmp_send(struct qmp *qmp, const void *data, size_t len) { long time_left; int ret; + if (WARN_ON(IS_ERR_OR_NULL(qmp) || !data)) + return -EINVAL; + if (WARN_ON(len + sizeof(u32) > qmp->size)) return -EINVAL; @@ -261,6 +266,7 @@ static int qmp_send(struct qmp *qmp, const void *data, size_t len) return ret; } +EXPORT_SYMBOL(qmp_send); static int qmp_qdss_clk_prepare(struct clk_hw *hw) { @@ -519,6 +525,51 @@ static void qmp_cooling_devices_remove(struct qmp *qmp) thermal_cooling_device_unregister(qmp->cooling_devs[i].cdev); } +/** + * qmp_get() - get a qmp handle from a device + * @dev: client device pointer + * + * Return: handle to qmp device on success, ERR_PTR() on failure + */ +struct qmp *qmp_get(struct device *dev) +{ + struct platform_device *pdev; + struct device_node *np; + struct qmp *qmp; + + if (!dev || !dev->of_node) + return ERR_PTR(-EINVAL); + + np = of_parse_phandle(dev->of_node, "qcom,qmp", 0); + if (!np) + return ERR_PTR(-ENODEV); + + pdev = of_find_device_by_node(np); + of_node_put(np); + if (!pdev) + return ERR_PTR(-EINVAL); + + qmp = platform_get_drvdata(pdev); + + return qmp ? qmp : ERR_PTR(-EPROBE_DEFER); +} +EXPORT_SYMBOL(qmp_get); + +/** + * qmp_put() - release a qmp handle + * @qmp: qmp handle obtained from qmp_get() + */ +void qmp_put(struct qmp *qmp) +{ + /* + * Match get_device() inside of_find_device_by_node() in + * qmp_get() + */ + if (!IS_ERR_OR_NULL(qmp)) + put_device(qmp->dev); +} +EXPORT_SYMBOL(qmp_put); + static int qmp_probe(struct platform_device *pdev) { struct resource *res; @@ -615,6 +666,7 @@ static struct platform_driver qmp_driver = { .driver = { .name = "qcom_aoss_qmp", .of_match_table = qmp_dt_match, + .suppress_bind_attrs = true, }, .probe = qmp_probe, .remove = qmp_remove, diff --git a/include/linux/soc/qcom/qcom_aoss.h b/include/linux/soc/qcom/qcom_aoss.h new file mode 100644 index 0000000000000..3c2a82e606f81 --- /dev/null +++ b/include/linux/soc/qcom/qcom_aoss.h @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2021, The Linux Foundation. All rights reserved. + */ + +#ifndef __QCOM_AOSS_H__ +#define __QCOM_AOSS_H__ + +#include +#include + +struct qmp; + +#if IS_ENABLED(CONFIG_QCOM_AOSS_QMP) + +int qmp_send(struct qmp *qmp, const void *data, size_t len); +struct qmp *qmp_get(struct device *dev); +void qmp_put(struct qmp *qmp); + +#else + +static inline int qmp_send(struct qmp *qmp, const void *data, size_t len) +{ + return -ENODEV; +} + +static inline struct qmp *qmp_get(struct device *dev) +{ + return ERR_PTR(-ENODEV); +} + +static inline void qmp_put(struct qmp *qmp) +{ +} + +#endif + +#endif