From patchwork Fri Feb 11 11:04:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumeet Pawnikar X-Patchwork-Id: 542137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1425C433F5 for ; Fri, 11 Feb 2022 10:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346487AbiBKKpL (ORCPT ); Fri, 11 Feb 2022 05:45:11 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349053AbiBKKpK (ORCPT ); Fri, 11 Feb 2022 05:45:10 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE11AD57 for ; Fri, 11 Feb 2022 02:45:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644576309; x=1676112309; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=gWbfYAefts3s92UQBmfAdoLidMYHSC55tQX5FlzeGOI=; b=efeQkDT6Q5MNh8of6AL/uQZ9dEvgnJkPxECCFlrwJhicCAmhMJ9dYYGk Ll9QtN9o76MRiGc05Qvs8lmH02hJAhZgwbaR+vTa51pVpC75uxYBqI+Dl +SPRbDoJhKk2E7ytUSABCn2p/grrFGgSGYczyiFf/sk9fMkNYmr8XNTQh 989PfeXQWXvHRFI59eW2QtZV5hH89+erwDDw9FXPTlBwngT7q+A63gXuq ZShEf56ZBKPLHIQ1J0uEV/mjK0PjpAMUH7tMEc7ghz9ZTWDJCnaRgbYzq H21CQhKOa2vejKbvXF6deXl30ggz+SpNDVVCDbtmsBDE7MotpRHC1XGb2 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="233265719" X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="233265719" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 02:45:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="623186902" Received: from srpawnik-desktop.iind.intel.com ([10.223.141.132]) by FMSMGA003.fm.intel.com with ESMTP; 11 Feb 2022 02:45:07 -0800 From: Sumeet Pawnikar To: stable@vger.kernel.org, gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com, srinivas.pandruvada@linux.intel.com Cc: sumeet.r.pawnikar@intel.com, Arnd Bergmann Subject: [PATCH V2 3/4] thermal: int340x: Limit Kconfig to 64-bit Date: Fri, 11 Feb 2022 16:34:34 +0530 Message-Id: <20220211110435.3724-4-sumeet.r.pawnikar@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220211110435.3724-1-sumeet.r.pawnikar@intel.com> References: <20220211110435.3724-1-sumeet.r.pawnikar@intel.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann commit 994a04a20b03128838ec0250a0e266aab24d23f1 upstream. 32-bit processors cannot generally access 64-bit MMIO registers atomically, and it is unknown in which order the two halves of this registers would need to be read: drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In function 'send_mbox_cmd': drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:37: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration] 79 | *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA)); | ^~~~~ | readl The driver already does not build for anything other than x86, so limit it further to x86-64. Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal: Suppot 64 bit RFIM responses") Signed-off-by: Arnd Bergmann Reviewed-by: Srinivas Pandruvada Reviewed-by: Randy Dunlap Signed-off-by: Rafael J. Wysocki Signed-off-by: Sumeet Pawnikar --- Changes in V2 from V1: - Added upstream commit id from Linus's tree. --- drivers/thermal/intel/int340x_thermal/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig index 45c31f3d6054..5d046de96a5d 100644 --- a/drivers/thermal/intel/int340x_thermal/Kconfig +++ b/drivers/thermal/intel/int340x_thermal/Kconfig @@ -5,12 +5,12 @@ config INT340X_THERMAL tristate "ACPI INT340X thermal drivers" - depends on X86 && ACPI && PCI + depends on X86_64 && ACPI && PCI select THERMAL_GOV_USER_SPACE select ACPI_THERMAL_REL select ACPI_FAN select INTEL_SOC_DTS_IOSF_CORE - select PROC_THERMAL_MMIO_RAPL if X86_64 && POWERCAP + select PROC_THERMAL_MMIO_RAPL if POWERCAP help Newer laptops and tablets that use ACPI may have thermal sensors and other devices with thermal control capabilities outside the core