From patchwork Fri Jan 14 08:16:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 532587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFBCC433F5 for ; Fri, 14 Jan 2022 08:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237683AbiANIYa (ORCPT ); Fri, 14 Jan 2022 03:24:30 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:33932 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239900AbiANIWa (ORCPT ); Fri, 14 Jan 2022 03:22:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2ED60B82443; Fri, 14 Jan 2022 08:22:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 465A4C36AE9; Fri, 14 Jan 2022 08:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642148547; bh=8GFM8MvwpFq8w6DiPHbGyX52z5/r4lEr4SVXvAN/DRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cq9eNgTJVSOIcntwcD6+Jb364/juJKYI0wiQ/CUNbyWzoCoaAI6Cj1CP4Jgdy8itS lGQmHELQRS618GyCnwhQG1R1OvUEY7TlMrIbUYFN2NhdzbjnciI0OUP88uJ3Ls28BZ VE8uCfi9MThmVb633f0vrYTmHe9mFcVqSV9UirbA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Kaiser Subject: [PATCH 5.16 03/37] staging: r8188eu: switch the led off during deinit Date: Fri, 14 Jan 2022 09:16:17 +0100 Message-Id: <20220114081544.969588704@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220114081544.849748488@linuxfoundation.org> References: <20220114081544.849748488@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Martin Kaiser commit 9d36de31130542fc060f7cd17e72db670202c682 upstream. When the driver is unloaded or when the system goes into standby mode, DeInitLed871x is called to stop the led layer. In this case, we stop the blinking worker but we do not switch the led off explicitly. On my system, I can go into standby mode with the LED enabled. Add a call to SwLedOff to fix this. Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver") Cc: stable@vger.kernel.org Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20211226195556.159471-2-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- drivers/staging/r8188eu/core/rtw_led.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/r8188eu/core/rtw_led.c +++ b/drivers/staging/r8188eu/core/rtw_led.c @@ -54,6 +54,7 @@ void DeInitLed871x(struct LED_871x *pLed _cancel_workitem_sync(&pLed->BlinkWorkItem); _cancel_timer_ex(&pLed->BlinkTimer); ResetLedStatus(pLed); + SwLedOff(pLed->padapter, pLed); } static void SwLedBlink1(struct LED_871x *pLed)