diff mbox series

[net,1/5] can: softing_cs: softingcs_probe(): fix memleak on registration failure

Message ID 20220109134040.1945428-2-mkl@pengutronix.de
State Accepted
Commit ced4913efb0acc844ed65cc01d091a85d83a2082
Headers show
Series [net,1/5] can: softing_cs: softingcs_probe(): fix memleak on registration failure | expand

Commit Message

Marc Kleine-Budde Jan. 9, 2022, 1:40 p.m. UTC 
From: Johan Hovold <johan@kernel.org>

In case device registration fails during probe, the driver state and
the embedded platform device structure needs to be freed using
platform_device_put() to properly free all resources (e.g. the device
name).

Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
Link: https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org
Cc: stable@vger.kernel.org # 2.6.38
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/softing/softing_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 6dc9a23e29061e50c36523270de60039ccf536fa
diff mbox series

Patch

diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c
index 2e93ee792373..e5c939b63fa6 100644
--- a/drivers/net/can/softing/softing_cs.c
+++ b/drivers/net/can/softing/softing_cs.c
@@ -293,7 +293,7 @@  static int softingcs_probe(struct pcmcia_device *pcmcia)
 	return 0;
 
 platform_failed:
-	kfree(dev);
+	platform_device_put(pdev);
 mem_failed:
 pcmcia_bad:
 pcmcia_failed: