diff mbox series

[5.4,30/37] usb: mtu3: fix list_head check warning

Message ID	20220103142052.807297651@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Yuwen Ng <yuwen.ng@mediatek.com>, Chunfeng Yun <chunfeng.yun@mediatek.com> Subject: [PATCH 5.4 30/37] usb: mtu3: fix list_head check warning Date: Mon, 3 Jan 2022 15:24:08 +0100 Message-Id: <20220103142052.807297651@linuxfoundation.org> In-Reply-To: <20220103142051.883166998@linuxfoundation.org> References: <20220103142051.883166998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.4,02/37] tee: handle lookup of shm with reference count 0 [5.4,03/37] Input: i8042 - add deferred probe support [5.4,04/37] Input: i8042 - enable deferred probe quirk for ASUS UM325UA [5.4,05/37] tomoyo: Check exceeded quota early in tomoyo_domain_quota_is_ok(). [5.4,06/37] platform/x86: apple-gmux: use resource_size() with res [5.4,07/37] memblock: fix memblock_phys_alloc() section mismatch error [5.4,08/37] recordmcount.pl: fix typo in s390 mcount regex [5.4,09/37] selinux: initialize proto variable in selinux_ip_postroute_compat() [5.4,10/37] scsi: lpfc: Terminate string in lpfc_debugfs_nvmeio_trc_write() [5.4,11/37] net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources [5.4,12/37] udp: using datalen to cap ipv6 udp max gso segments [5.4,13/37] selftests: Calculate udpgso segment count without header adjustment [5.4,14/37] net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register [5.4,15/37] sctp: use call_rcu to free endpoint [5.4,16/37] net: usb: pegasus: Do not drop long Ethernet frames [5.4,17/37] net: lantiq_xrx200: fix statistics of received bytes [5.4,18/37] NFC: st21nfca: Fix memory leak in device probe and remove [5.4,19/37] ionic: Initialize the lif->dbid_inuse bitmap [5.4,20/37] net/mlx5e: Fix wrong features assignment in case of error [5.4,21/37] selftests/net: udpgso_bench_tx: fix dst ip argument [5.4,22/37] net/ncsi: check for error return from call to nla_put_u32 [5.4,23/37] fsl/fman: Fix missing put_device() call in fman_port_probe [5.4,24/37] i2c: validate user data in compat ioctl [5.4,25/37] nfc: uapi: use kernel size_t to fix user-space builds [5.4,26/37] uapi: fix linux/nfc.h userspace compilation errors [5.4,27/37] xhci: Fresco FL1100 controller should not have BROKEN_MSI quirk set. [5.4,28/37] usb: gadget: f_fs: Clear ffs_eventfd in ffs_data_clear. [5.4,29/37] usb: mtu3: add memory barrier before set GPDs HWO [5.4,30/37] usb: mtu3: fix list_head check warning [5.4,31/37] usb: mtu3: set interval of FS intr and isoc endpoint [5.4,32/37] binder: fix async_free_space accounting for empty parcels [5.4,33/37] scsi: vmw_pvscsi: Set residual data length conditionally [5.4,34/37] Input: appletouch - initialize work before device registration [5.4,35/37] Input: spaceball - fix parsing of movement data packets [5.4,36/37] net: fix use-after-free in tw_timer_handler [5.4,37/37] perf script: Fix CPU filtering of a scripts switch events

Commit Message

Greg KH Jan. 3, 2022, 2:24 p.m. UTC

From: Chunfeng Yun <chunfeng.yun@mediatek.com>

commit 8c313e3bfd9adae8d5c4ba1cc696dcbc86fbf9bf upstream.

This is caused by uninitialization of list_head.

BUG: KASAN: use-after-free in __list_del_entry_valid+0x34/0xe4

Call trace:
dump_backtrace+0x0/0x298
show_stack+0x24/0x34
dump_stack+0x130/0x1a8
print_address_description+0x88/0x56c
__kasan_report+0x1b8/0x2a0
kasan_report+0x14/0x20
__asan_load8+0x9c/0xa0
__list_del_entry_valid+0x34/0xe4
mtu3_req_complete+0x4c/0x300 [mtu3]
mtu3_gadget_stop+0x168/0x448 [mtu3]
usb_gadget_unregister_driver+0x204/0x3a0
unregister_gadget_item+0x44/0xa4

Fixes: 83374e035b62 ("usb: mtu3: add tracepoints to help debug")
Cc: stable@vger.kernel.org
Reported-by: Yuwen Ng <yuwen.ng@mediatek.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/20211218095749.6250-3-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/mtu3/mtu3_gadget.c |    1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

--- a/drivers/usb/mtu3/mtu3_gadget.c
+++ b/drivers/usb/mtu3/mtu3_gadget.c
@@ -245,6 +245,7 @@  struct usb_request *mtu3_alloc_request(s
 	mreq->request.dma = DMA_ADDR_INVALID;
 	mreq->epnum = mep->epnum;
 	mreq->mep = mep;
+	INIT_LIST_HEAD(&mreq->list);
 	trace_mtu3_alloc_request(mreq);
 
 	return &mreq->request;