From patchwork Mon Dec 6 14:57:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 522158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BE3CC43219 for ; Mon, 6 Dec 2021 15:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359190AbhLFPRD (ORCPT ); Mon, 6 Dec 2021 10:17:03 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:47790 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347164AbhLFPO2 (ORCPT ); Mon, 6 Dec 2021 10:14:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A19B9B8111F; Mon, 6 Dec 2021 15:10:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4017C341C1; Mon, 6 Dec 2021 15:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638803457; bh=BTanRUk18TYQP/QQ8wYtxZWnjMGsSttNcV2PCg2JJ/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sPP7VT9mbXZ4r0VzdAF5Icmn84SlDp87UMlQL5+K1+7bz/JOO7HO2bwCi5dHl2Y4Y P57jT+EwfGsUmtLN8ImtLq9f+KGTjYowInljbIVhazTqRzatTL0gssebGnrlaLpRp+ NtqC6+Sc4d3NVkJsJg0nLIFN8L051Sbn2VwbzHFQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wei Yongjun , Corey Minyard Subject: [PATCH 4.19 48/48] ipmi: msghandler: Make symbol remove_work_wq static Date: Mon, 6 Dec 2021 15:57:05 +0100 Message-Id: <20211206145550.500153405@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211206145548.859182340@linuxfoundation.org> References: <20211206145548.859182340@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wei Yongjun commit 5a3ba99b62d8486de0316334e72ac620d4b94fdd upstream. The sparse tool complains as follows: drivers/char/ipmi/ipmi_msghandler.c:194:25: warning: symbol 'remove_work_wq' was not declared. Should it be static? This symbol is not used outside of ipmi_msghandler.c, so marks it static. Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Message-Id: <20211123083618.2366808-1-weiyongjun1@huawei.com> Signed-off-by: Corey Minyard Signed-off-by: Greg Kroah-Hartman --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -219,7 +219,7 @@ struct ipmi_user { struct work_struct remove_work; }; -struct workqueue_struct *remove_work_wq; +static struct workqueue_struct *remove_work_wq; static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index) __acquires(user->release_barrier)