From patchwork Mon Sep 20 16:42:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 514358 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp2320349jao; Mon, 20 Sep 2021 11:26:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5PLci6FsVKfIXqblHmFN1p05vWJfbUBLZBDHxBH96xU8obPRc0xk5dmVhnPghNiOjIJCn X-Received: by 2002:aa7:db4d:: with SMTP id n13mr30901576edt.398.1632162365191; Mon, 20 Sep 2021 11:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632162365; cv=none; d=google.com; s=arc-20160816; b=MmMiJ2nlWRyiHYN3nhMXsOXj2ARAB1dUCoFUAxMWojA4TRef3RjteoQSxDL3OX5A9+ GVBkeoXk14XfS4E25lRiBqNqsPFEVCUmTZcYZ/TzwL2bFUZPXjukPWZTzY93wLislL1K p64YSyTJdOFd9uIGfdFduSXpACeP0COVHtVKVKxe2aPiC6hZ0j4jmk7ubKjZWhszPb6G jOHR7n1VHwpVheqwDIZBqKXJK+30sVaHsAZL3gBPTBWBDSJuhPao4melAsCn08NwL4rX /xv96Lkp8H/pTVjrG/UbmZcqwPMZzHCPSl0/y8pG0kmCTADVq0pLJi94JuF7FAPO175C S6yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=I0nsZvzF7GS9kPDI8KYOE3I53YFH1dwe06OH3GBoch8=; b=OhLAQ7gDXh22QKepFvMF229IVgS6HQ/DIicSzUWN0iDZHBicrRhtVzpC5k1gCgxmqK 2fREgF3XfTb2tZVPbCxUiOr5Mdbi3UkYXPTznr1V4ahUcYcJILjUVXlJmPX9OCxyBz2w 6UhxYq2/QS6HzBtXOb2YF0G1zWzsbjqYdUTEmvr7mrR1sKyX8LiE/7gBsjq2XtuLe440 QnltlDPiGo2DeGL3VaA6NHP2mpJTBEtskEwzJy/pvVeXkRTxMrLo9GZ7kXDMsRQ4jEa4 QU9xZ/3IqCTpdS5MMzwUmnOhkgzdc+b3EVWlU7Mjux2Hu1NrCdv8qh/HUo9dfn6SFtxi O1AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ChnCeAT5; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si19421526edh.492.2021.09.20.11.26.04; Mon, 20 Sep 2021 11:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ChnCeAT5; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378973AbhITS12 (ORCPT + 11 others); Mon, 20 Sep 2021 14:27:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:43766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348137AbhITSZ1 (ORCPT ); Mon, 20 Sep 2021 14:25:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 25F5D632D0; Mon, 20 Sep 2021 17:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632158723; bh=Rzk16eFGZCHkcQPmr+mLyNt0vij5JEP7qj3OXPPf9mQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ChnCeAT5dTQbw0u8rW4gq5XR/FIxBsaD+r4VD4WuWxErWyTUb4Yp0dC8Pvl2pCtID Y96oiIkKM2jwBVnqQRl9E0OOyZW+x09puCyF1xIEicbWBBNX5ri07daw9igjqcoS0N BhSTz8lvs4kPg5vSQWJivAMowDxlr4eWk3zwRE5Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown , Catalin Marinas Subject: [PATCH 5.10 006/122] arm64/sve: Use correct size when reinitialising SVE state Date: Mon, 20 Sep 2021 18:42:58 +0200 Message-Id: <20210920163915.970625637@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210920163915.757887582@linuxfoundation.org> References: <20210920163915.757887582@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Mark Brown commit e35ac9d0b56e9efefaeeb84b635ea26c2839ea86 upstream. When we need a buffer for SVE register state we call sve_alloc() to make sure that one is there. In order to avoid repeated allocations and frees we keep the buffer around unless we change vector length and just memset() it to ensure a clean register state. The function that deals with this takes the task to operate on as an argument, however in the case where we do a memset() we initialise using the SVE state size for the current task rather than the task passed as an argument. This is only an issue in the case where we are setting the register state for a task via ptrace and the task being configured has a different vector length to the task tracing it. In the case where the buffer is larger in the traced process we will leak old state from the traced process to itself, in the case where the buffer is smaller in the traced process we will overflow the buffer and corrupt memory. Fixes: bc0ee4760364 ("arm64/sve: Core task context handling") Cc: # 4.15.x Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20210909165356.10675-1-broonie@kernel.org Signed-off-by: Catalin Marinas Signed-off-by: Greg Kroah-Hartman --- arch/arm64/kernel/fpsimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -510,7 +510,7 @@ size_t sve_state_size(struct task_struct void sve_alloc(struct task_struct *task) { if (task->thread.sve_state) { - memset(task->thread.sve_state, 0, sve_state_size(current)); + memset(task->thread.sve_state, 0, sve_state_size(task)); return; }