From patchwork Mon Sep 13 13:12:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 509750 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp581817jao; Mon, 13 Sep 2021 06:59:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOZlTTpv4rPEnl/IPHmOUIDrsMEdvXJOeu3ws2CaJJjpB1RH9e3ny4AZN7m0WT2PSaEgaD X-Received: by 2002:a6b:fd1a:: with SMTP id c26mr8847269ioi.57.1631541550617; Mon, 13 Sep 2021 06:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631541550; cv=none; d=google.com; s=arc-20160816; b=JEunHAOKkA/SOV8e6AAsD30DdgtoBNgqbNaOxC/4lsrlW40O+3BLkKXXqK5M/e5uym NSAcRu9A9jit647mHuLPVfXP/rF2LPDNBzgoGEiEaCnUEovlwLLF1XnWyK0zMhR9EMSZ KzRg3HqgQUgiIALJ4sjo4ej4t+nHemQAuyyFU9BA3szbTodmD3Y+uCI0uV2q5i5Jr0dl GWRXsARLqcC8Yyl3jy0OVaq9JmUJJ/mnt+mgWD4VvazzJzk78xziL54WQUSoU7GyTZED xLsrvFCRYF6mrMBi6dv+NEVghNFLS6RQ1xcNzngdRnCvt1Xpi6S9SpbNxlpH9CarSpAE xciQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mNv0cY38+yyztZgwLnOtmdwOh06m1sjZdTxaB03QqQE=; b=ynKSJhWJwgMwbRf4HO8IdcK1S2PUt9vvBGsTSi+MZvuVAuZggGSOhXQFs341JAh35T Iuus9nN149NMitTOYO3vZNwcmpvxai8COQfaJ9cEpO8vTmY+mtg1nWZC65Og+9pYLQlF oFH0+LcfWPebvx2PAuelo5xHZ0mZa/g/5m3DcmqJtt34zM8WpmdGUSwrxpDapq+nenyA 8oGAM0LSW+zhACatH6L3jmaaq2g8/aqcpI/q4jo7sZPpbneRt4eS2uGi+UAfmiX0PksS YZb4Attmp8QbA1QTTO94nVc62eLDSNzEK/ekyAvFD6IyK4Edytx88WRaDns/fVh1K1+s I1Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xERwE6kz; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si6905699jac.2.2021.09.13.06.59.09; Mon, 13 Sep 2021 06:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xERwE6kz; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243169AbhIMOAX (ORCPT + 11 others); Mon, 13 Sep 2021 10:00:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:44092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245498AbhIMN5m (ORCPT ); Mon, 13 Sep 2021 09:57:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 13CF561391; Mon, 13 Sep 2021 13:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631540197; bh=AO33QXA2qI7bkkbxNCXmBfdIcH625xh+knSBmMfrrJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xERwE6kzmcYENPaolYnRNfVQ3e8CSeVw5UlS4qvi3CIX7rLnI1NMOnvrDUk12Wc0L rEH10rAl+TR3eRoi9BDsMqbK7Up4LBpHJyrFsxJt0rtFPsx8dW9TOdSdQ5n0H2sKT7 ZDV2BABRTlXdutquDoh/p7IFQcEm+BFIhw9qklGU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Thomas Gleixner , Sasha Levin Subject: [PATCH 5.13 060/300] genirq/timings: Fix error return code in irq_timings_test_irqs() Date: Mon, 13 Sep 2021 15:12:01 +0200 Message-Id: <20210913131111.390050684@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131109.253835823@linuxfoundation.org> References: <20210913131109.253835823@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b ] Return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com Signed-off-by: Sasha Levin --- kernel/irq/timings.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.30.2 diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 4d2a702d7aa9..c43e2ac2f8de 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/timings.c @@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti) __irq_timings_store(irq, irqs, ti->intervals[i]); if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) { + ret = -EBADSLT; pr_err("Failed to store in the circular buffer\n"); goto out; } } if (irqs->count != ti->count) { + ret = -ERANGE; pr_err("Count differs\n"); goto out; }