From patchwork Mon Sep 13 13:13:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 509741 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp555958jao; Mon, 13 Sep 2021 06:29:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdL8W6PegF3Pa/xf1GLhzDF0b2ec6m49eeKAmJhkFRQ1wUgF78zn2DpD4h01V6LCqiCsx+ X-Received: by 2002:a5d:914b:: with SMTP id y11mr9250638ioq.6.1631539748549; Mon, 13 Sep 2021 06:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631539748; cv=none; d=google.com; s=arc-20160816; b=WR8a+MPwV7VTYiUKkA5u5E7YlFxgvZI+utuxp31QyitTmmPtfxGKTVdBGjv6HcTuTM uWyAl1WJIgA6/GvDUDZrjpK3jOEKJljmuD16KdR8ZorG7l3TMIsXx9NAOKfmyoPwbRNx bGCwsmQwAPe7cfwlYNfbCUbrLYArDPg6WiZlJklsV+7ji3+lAQTpbn4BlYvA8Fy9plX+ PyohEHuiHvpvWSGMJ+uiIHV+tB/F0R4jPjKdVX4zoSCIH92eDMKP8G19x7wIRq6iTFq9 ef1/BrGpMr10j3Glk8YCpE4gVelX3qW3qdM5UkL0mFDmwhlGIB8+W/FbqWRVSpP9ppnp el8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hj09rhKpRFaZ3EMdSbLkX3bbBHuqCmjyOJjYzB3J2QM=; b=K98kCEFw0JyFAiA5sKfKbIbrR4YBkuLB4qXrqrT0Gxw1ziG9PvmyHOLqPQJTc526b0 44pqoVtQ8Ww5mCw3KUxz/i4wzZtDkEVPpLQ9CwpayblgSwYOgZopDjWJ939Jvof5KF2c sUnhTxkR3djHPoTnFoLeDBoSvlgfcVD/3Rufr1INMUnqAbTG8MXCTOcwjunhvccLPC+a NLTsuy5xis6K60cyvhyBwM38AHaREzSoN2w+4tVCGBWBrcAI3gN2zhXblns/tSAfllVg Gcg+vEyRKfF/8KCnKE2OX1qJ3xU+ad3RRghdpYaaSQ29ywtCKqetcxZsPporR/kq2Kur SQmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wtFdzsRf; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si2401623ilv.64.2021.09.13.06.29.08; Mon, 13 Sep 2021 06:29:08 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wtFdzsRf; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242315AbhIMNaO (ORCPT + 11 others); Mon, 13 Sep 2021 09:30:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:35056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240150AbhIMNT4 (ORCPT ); Mon, 13 Sep 2021 09:19:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 360056113B; Mon, 13 Sep 2021 13:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631539082; bh=ubLnOvhDD9HBiRyDL6wXMzREZ3bw2QB2Sm1N1wWnrIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wtFdzsRfJ6MG4y+HUtM2nQjcQ9tvWve+8NgQzl5smeJUY9RkTy2n8F/u6vcjMBPbM 7cM6GRJ21Q7WHmg8U7dPsXzQ05e2ybV8DxrFe0ju2KIup1n04+YCut+KLf8ShyRtxr BsLBfaxRW721b25T2vRm/ijvY6HbooEVEJMNRa50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Thomas Gleixner , Sasha Levin Subject: [PATCH 5.4 035/144] genirq/timings: Fix error return code in irq_timings_test_irqs() Date: Mon, 13 Sep 2021 15:13:36 +0200 Message-Id: <20210913131049.126722025@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913131047.974309396@linuxfoundation.org> References: <20210913131047.974309396@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b ] Return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com Signed-off-by: Sasha Levin --- kernel/irq/timings.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.30.2 diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index b5985da80acf..7ccc8edce46d 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/timings.c @@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti) __irq_timings_store(irq, irqs, ti->intervals[i]); if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) { + ret = -EBADSLT; pr_err("Failed to store in the circular buffer\n"); goto out; } } if (irqs->count != ti->count) { + ret = -ERANGE; pr_err("Count differs\n"); goto out; }