From patchwork Wed Aug 18 07:02:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 499696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E65C4320A for ; Wed, 18 Aug 2021 07:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56948610CB for ; Wed, 18 Aug 2021 07:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238775AbhHRHMD (ORCPT ); Wed, 18 Aug 2021 03:12:03 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:58283 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237805AbhHRHMC (ORCPT ); Wed, 18 Aug 2021 03:12:02 -0400 Received: from vokac-Latitude-7410.ysoft.local (unknown [10.1.22.96]) by uho.ysoft.cz (Postfix) with ESMTP id A51DAA01BF; Wed, 18 Aug 2021 09:02:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1629270155; bh=D3SoYq7cCf8X685kicAhxBhPpnT4tcM0Cnios45ggv8=; h=From:To:Cc:Subject:Date:From; b=D7nvxhBK4BVqR08HV+1wdjdazYuFbHJ1Z0xNzGRf0iWmt3yJCOUzQrgGGCJ/NKaGb JCo43iq0l7tp4z4w37qyEbuivD2ytuqa2KsBxBxLDyRto2ts4f6CJhe3/saOcTudNN /UTCQPD4ZETFImvdHD/dEkv4/4beEnAlbFQsPV2g= From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Shawn Guo Cc: Rob Herring , Fabio Estevam , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Pavel Machek , Jacek Anaszewski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= , stable@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH 1/2] ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe Date: Wed, 18 Aug 2021 09:02:08 +0200 Message-Id: <20210818070209.1540451-1-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Since the LED multicolor framework support was added in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") LEDs on this platform stopped working. Author of the framework attempted to accommodate this DT to the framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") but that is not sufficient. A color property is now required even if the multicolor framework is not used, otherwise the driver probe fails: lp5562: probe of 1-0030 failed with error -22 Add the color property to fix this. Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") Cc: Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč Acked-by: Pavel Machek Reviewed-by: Fabio Estevam --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi index 7d2c72562c73..8c796551352b 100644 --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi @@ -5,6 +5,7 @@ #include #include #include +#include #include / { @@ -271,6 +272,7 @@ chan@0 { led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <0>; + color = ; }; chan@1 { @@ -278,6 +280,7 @@ chan@1 { led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <1>; + color = ; }; chan@2 { @@ -285,6 +288,7 @@ chan@2 { led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <2>; + color = ; }; chan@3 { @@ -292,6 +296,7 @@ chan@3 { led-cur = /bits/ 8 <0x0>; max-cur = /bits/ 8 <0x0>; reg = <3>; + color = ; }; };