diff mbox series

[5.10,66/67] i40e: Add additional info to PHY type error

Message ID	20210802134341.302667404@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Lukasz Cieplicki <lukaszx.cieplicki@intel.com>, Michal Maloszewski <michal.maloszewski@intel.com>, Tony Brelinski <tonyx.brelinski@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com> Subject: [PATCH 5.10 66/67] i40e: Add additional info to PHY type error Date: Mon, 2 Aug 2021 15:45:29 +0200 Message-Id: <20210802134341.302667404@linuxfoundation.org> In-Reply-To: <20210802134339.023067817@linuxfoundation.org> References: <20210802134339.023067817@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.10,03/67] pipe: make pipe writes always wake up readers [5.10,05/67] btrfs: mark compressed range uptodate only if all bio succeed [5.10,06/67] Revert "ACPI: resources: Add checks for ACPI IRQ override" [5.10,07/67] ACPI: DPTF: Fix reading of attributes [5.10,11/67] ocfs2: issue zeroout to EOF blocks [5.10,12/67] can: j1939: j1939_xtp_rx_dat_one(): fix rxtimer value between consecutive TP.DT to 7... [5.10,16/67] can: usb_8dev: fix memory leak [5.10,18/67] can: esd_usb2: fix memory leak [5.10,19/67] alpha: register early reserved memory in memblock [5.10,20/67] HID: wacom: Re-enable touch by default for Cintiq 24HDT / 27QHDT [5.10,21/67] NIU: fix incorrect error return, missed in previous revert [5.10,22/67] drm/amd/display: ensure dentist display clock update finished in DCN20 [5.10,23/67] drm/amdgpu: Avoid printing of stack contents on firmware load error [5.10,24/67] drm/amdgpu: Fix resource leak on probe error path [5.10,28/67] RDMA/bnxt_re: Fix stats counters [5.10,32/67] netfilter: nft_nat: allow to specify layer 4 protocol NAT only [5.10,33/67] i40e: Fix logic of disabling queues [5.10,34/67] i40e: Fix firmware LLDP agent related warning [5.10,35/67] i40e: Fix queue-to-TC mapping on Tx [5.10,39/67] net: Set true network header for ECN decapsulation [5.10,40/67] net: qrtr: fix memory leaks [5.10,44/67] tipc: do not write skb_shinfo frags when doing decrytion [5.10,45/67] octeontx2-pf: Fix interface down flag on error [5.10,47/67] KVM: x86: Check the right feature bit for MSR_KVM_ASYNC_PF_ACK access [5.10,49/67] drm/msm/dpu: Fix sm8250_mdp register length [5.10,50/67] drm/msm/dp: Initialize the INTF_CONFIG register [5.10,51/67] skmsg: Make sk_psock_destroy() static [5.10,53/67] net/mlx5e: Fix nullptr in mlx5e_hairpin_get_mdev() [5.10,55/67] tulip: windbond-840: Fix missing pci_disable_device() in probe and remove [5.10,56/67] sis900: Fix missing pci_disable_device() in probe and remove [5.10,58/67] bpf: Introduce BPF nospec instruction for mitigating Spectre v4 [5.10,60/67] bpf: Remove superfluous aux sanitation on subprog rejection [5.10,61/67] bpf: verifier: Allocate idmap scratch in verifier env [5.10,64/67] powerpc/pseries: Fix regression while building external modules [5.10,66/67] i40e: Add additional info to PHY type error

Commit Message

Greg KH Aug. 2, 2021, 1:45 p.m. UTC

From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>

commit dc614c46178b0b89bde86ac54fc687a28580d2b7 upstream.

In case of PHY type error occurs, the message was too generic.
Add additional info to PHY type error indicating that it can be
wrong cable connected.

Fixes: 124ed15bf126 ("i40e: Add dual speed module support")
Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -980,7 +980,7 @@  static void i40e_get_settings_link_up(st
 	default:
 		/* if we got here and link is up something bad is afoot */
 		netdev_info(netdev,
-			    "WARNING: Link is up but PHY type 0x%x is not recognized.\n",
+			    "WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n",
 			    hw_link_info->phy_type);
 	}