From patchwork Mon Jul 19 14:50:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 479950 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4243270jao; Mon, 19 Jul 2021 08:41:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/O0YwMgm8ey7GcZoZrJThFv1HWQXpqV/ezfNAXbBB4RA7PSLgVtqyVh853Bew2M1Tr6jF X-Received: by 2002:a92:d98c:: with SMTP id r12mr18994535iln.304.1626709295271; Mon, 19 Jul 2021 08:41:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626709295; cv=none; d=google.com; s=arc-20160816; b=emW/xqAFV+6ri39IjZYbcmZyO6S/lz+8zg0yyodefA580uwRwMTNB/SVqGBoC7xvfO IZR8vQ3Lr+5K3XJuHOE4W6ut05rTaIK0p10hMUjBjlJusn08xSi+adYsiGTTbJPYr5Hg r6ekQk3HnXJO3asM/WnMyQCnRdQMAq/gy9i1nLcoRi6uj3G09+1bvCQMGdOFx4DNbFlx iVpA5K9DVt2EnV3CpAgKmioI/ERRoj1aKpzvxrr8/OwgG3lb6OA3IV1RGm++kCFmtM5h s1tPSrJ7IWqy2xOgnZERkN7/YgABKL528PvqjuY2sg2cstDCpxkfTw5fnh9XLmiSgRsz UksA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JO73L7wWkpwXU6Sk199O94dQdgn0su7en9DAaOWsLsM=; b=VEwA5ZfT4znQBFfutfKDCBI2wAcVXAoUd1wOvmI+i/FLprtpAv+8jCpEjBCAE9pYMC YRJAquRgwVxHTBMW9pjvZk2NHNG+xxdcK/ZiuNE+0eAsnRJ5WyuZKRlRkQt2jMW5gL2E H37N1pH3/lOFAkNgxvM1dcoCrxgdkQht9G4nNewonSVghL8cmboj9J6j85pmNZqIVYwj i1jxHmyoTbQsgcxqIejJrwf+U+qcZnZXQ4teFBMNf0rwV0S9ZANmy/uNEHs5ecKcFXg4 Qg6m+V4H/thtknV5cdTlxKvDMJ+cYBBRzpKHGgOLpFbdMjK2vvvobIqdig0O+lCXRqBF 8JdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QcHYnddY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay16si21406520jab.96.2021.07.19.08.41.35; Mon, 19 Jul 2021 08:41:35 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QcHYnddY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241083AbhGSPAi (ORCPT + 12 others); Mon, 19 Jul 2021 11:00:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:52466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237865AbhGSO63 (ORCPT ); Mon, 19 Jul 2021 10:58:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 940866121F; Mon, 19 Jul 2021 15:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708965; bh=xvrPnt3oh4IiGi8A6X9ogL7z4HopxPWHmJHDk2Mr23s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QcHYnddYKvO6u5cvjuF9zAa85WCyY8sF1w37c2Co1RAGNaPd/5NJxtO/yv9br7WI0 GEvbapUK3phe5TjiIYFwmPl4OUJQV7HvTXHzoHp/JR3Qfwk0NtYn5VDqHV6Iimqfxq QIVlMrFJz7qBF7qoZ+S+vvH0rM2VcF28rsFuHF5M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Andreas Klinger , =?utf-8?q?Nuno_S=C3=A1?= , Sasha Levin Subject: [PATCH 4.19 200/421] iio: adc: mxs-lradc: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Date: Mon, 19 Jul 2021 16:50:11 +0200 Message-Id: <20210719144953.316215281@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144946.310399455@linuxfoundation.org> References: <20210719144946.310399455@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cameron [ Upstream commit 6a6be221b8bd561b053f0701ec752a5ed9007f69 ] To make code more readable, use a structure to express the channel layout and ensure the timestamp is 8 byte aligned. Add a comment on why the buffer is the size it is as not immediately obvious. Found during an audit of all calls of this function. Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver") Signed-off-by: Jonathan Cameron Cc: Andreas Klinger Reviewed-by: Nuno Sá Link: https://lore.kernel.org/r/20210613152301.571002-4-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/adc/mxs-lradc-adc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c index c627513d9f0f..fc8b70d8d64c 100644 --- a/drivers/iio/adc/mxs-lradc-adc.c +++ b/drivers/iio/adc/mxs-lradc-adc.c @@ -124,7 +124,8 @@ struct mxs_lradc_adc { struct device *dev; void __iomem *base; - u32 buffer[10]; + /* Maximum of 8 channels + 8 byte ts */ + u32 buffer[10] __aligned(8); struct iio_trigger *trig; struct completion completion; spinlock_t lock;