From patchwork Mon Jul 19 14:48:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 479925 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4238931jao; Mon, 19 Jul 2021 08:36:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPL051eFDIZW9TRy1u0XMhHUlX2rk54MN+doEz0n+2McxogilxOs8MPhIr3UyIT7yDl5hO X-Received: by 2002:a92:cb0f:: with SMTP id s15mr18248323ilo.11.1626708999373; Mon, 19 Jul 2021 08:36:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708999; cv=none; d=google.com; s=arc-20160816; b=I7XKcMfTEPSay15vJRD0AgK7OdO8/Mek8OByVHuswgGxac/X8XA2yi+JWHKlY3RwbG RTzVpLM5BZG7wJ4wsqbMbJ5nhlsB52E1TMrjGJNuSxlyxKUpEisCjRQp2cfCEBef88Ix rAcM3JKByqrR1okSPP/98/hyXnEORsRfQJX4eXu0QJ5k0a1YVPmg2rLmwNl9il8zT7o3 XCGg+j2+uyNw9seHHcVaU2RW20bwdBQ25ftufmg26CUDBGpZ1ZPvrvhbMr6oxjUDJ/+Z YyDNGUFpKx+CzPkdX3mR+PHt5w4jdlBnZsA/s9iskt/4XemYPo31O9jYbRUyOFU1pUmo r5hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EXZVv0EOm3XZ2lvfT+d/mpHq57yCFK1w6QOUF15hY7o=; b=w/fyU0dSkwJqXSLnJgov+NsxzksaW3MGdu6v+XOnTWbH4lwM2hcYez1SamaglJ25uq bgFvY9ZbFpPN7fuoVmxwpfYnYv190B/4P146qszFZgnycY46yuZJcgsCl8zPkgKg5sCw DFV9x3AXMLVgySRmxgjtqLMsSu/VNBLfYeitIvOK8u0zTZ+xh7ah1BUc/VpZMfipf+ib vONe2/RHmJPLPMGVUb2SKt9MnT+GyBK2UX0UWOf0B+Y4SvRw9KxJfg2b5aiXjfFrABWQ 6OZdfn8EXx5mZG+fcGLPds85d8kdCHTlTo9Fvu/eFSp6mPb6Xip7sBLcYvWSK2xml57J P0LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=swM2fukN; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si23669220iol.44.2021.07.19.08.36.39; Mon, 19 Jul 2021 08:36:39 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=swM2fukN; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238737AbhGSOz4 (ORCPT + 12 others); Mon, 19 Jul 2021 10:55:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:45022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237323AbhGSOxs (ORCPT ); Mon, 19 Jul 2021 10:53:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C455B61244; Mon, 19 Jul 2021 15:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708777; bh=QnKnBfX6IL4YEZfxj4jH16D0AuitujISM3XNVbNUhfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=swM2fukNm9BkYA0NZpddomOpNRcXa4zwOFqthH265EGHfvUOzLAp0L/mH1hOZPEb7 bv0Pd3r4jo/6hedLhGzPdAy49jag0PYy56atExxrXOyPIGiAjOSI1xBa4gZq0ONvj4 39cxKQw/XgPdmIcEv2U2WwHksxSef3NIPTrf49KE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Ulf Hansson , Sasha Levin Subject: [PATCH 4.19 109/421] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Date: Mon, 19 Jul 2021 16:48:40 +0200 Message-Id: <20210719144950.353690598@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144946.310399455@linuxfoundation.org> References: <20210719144946.310399455@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 2f9ae69e5267f53e89e296fccee291975a85f0eb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210508020321.1677-1-thunder.leizhen@huawei.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/usdhi6rol0.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index ef3aa8b52078..b88728b686e8 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c @@ -1809,6 +1809,7 @@ static int usdhi6_probe(struct platform_device *pdev) version = usdhi6_read(host, USDHI6_VERSION); if ((version & 0xfff) != 0xa0d) { + ret = -EPERM; dev_err(dev, "Version not recognized %x\n", version); goto e_clk_off; }