From patchwork Mon Jul 19 14:48:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 479922 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4237644jao; Mon, 19 Jul 2021 08:35:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXPkrwnWKzH7LssST0AF5czgev/xttXMdnhjd182IfzZinAnmvCBdiIrqtjol3PUTxQR+H X-Received: by 2002:a50:fd8e:: with SMTP id o14mr35177417edt.80.1626708906009; Mon, 19 Jul 2021 08:35:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708906; cv=none; d=google.com; s=arc-20160816; b=J34aCl8Q3gT1t6f1dQlu9l2Cn60Z8PxP9EK6OHDc/rUZEmBRxbHt3UV8GleaKxPF4t aG5JnK0bjlAvLg4NVdkMoCMnzKfCceSSEA1SVDpLvX5DUaTBaFVUt1J65e39RqjXImI/ wB7LuHlCM6r+VCqfbdZzrFjyNtPeRuhxiEoDCtxRp6qVXUajWyx84iLGpywnQ2zAtKUl AQsaO7tb49Oy5UssfQ7vF2VWFKog6JeojODwPT2a6/JZTZ7a7Lj3jGgvF5g8F/ojtlwn saF8oyM7kpzT0AmbWhh78dbkHrqSOYCrtJ0s0poJv4pMQJfDtr3d7ryZI+4QHNwv6k9A kNtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=amL/0w63AMCM30tchmwD6KNvWY5uxNvgcvr8RWD0gpY=; b=wbRg3BLy0sSJ4Enk9wFS7HT3AQUD7EkgsW7X6e8kls4oyliKWV4pVU/KEQGsFwuW6U DqlYa9FyCYcaCUW0fLhvD7C4Lg4d5PAiIhRCuiAd0ZDtAjl8Lr+gne6zYfw82OhYShqn qUOqij+M779cQbVO8gow4iVlU7TBQ+i7fWIYB3ks+8x6bDJRHYphb/a+6qa/f2gRmB3s 0E9yckqa0Inffppa+tt2t+n8tB5tlvy5hk7Ui/x1Iu04UinrefZ88xQQd56k4uqBJEvB GGNIdAQ0oreUrED3wIuTrnj3LujrRNIrhk07mTSbQ1s8iZiPgiTj6Mm9Iae6nNA8T7c4 tvwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WuePi39j; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bo13si21364747edb.172.2021.07.19.08.35.05; Mon, 19 Jul 2021 08:35:06 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WuePi39j; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239096AbhGSOyS (ORCPT + 12 others); Mon, 19 Jul 2021 10:54:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:45098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243557AbhGSOv4 (ORCPT ); Mon, 19 Jul 2021 10:51:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 875E46121E; Mon, 19 Jul 2021 15:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708728; bh=cNms/ac6UK9W2T2Q9O7GdGBv0hSXcsudHqSmrEYw310=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WuePi39juBQ9GHhMZ+gMFAn9J86r6gSQ2F0ynSvgAsnAG7f/o02tyci7yJWYP2Tzz wXTvgJTIBmELWQLKScDbsTLcQ+Siahi60Vs04VM790nxr7NB43v2rHr9bqgr4xIxD/ ew7UU7NtkaX/fHVGGfLY/FDJ0kDKOylOaCHutoig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 106/421] media: tc358743: Fix error return code in tc358743_probe_of() Date: Mon, 19 Jul 2021 16:48:37 +0200 Message-Id: <20210719144950.261131110@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144946.310399455@linuxfoundation.org> References: <20210719144946.310399455@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ] When the CSI bps per lane is not in the valid range, an appropriate error code -EINVAL should be returned. However, we currently do not explicitly assign this error code to 'ret'. As a result, 0 was incorrectly returned. Fixes: 256148246852 ("[media] tc358743: support probe from device tree") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 041b16965b96..079b8db4bc48 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1972,6 +1972,7 @@ static int tc358743_probe_of(struct tc358743_state *state) bps_pr_lane = 2 * endpoint->link_frequencies[0]; if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); + ret = -EINVAL; goto disable_clk; }