From patchwork Mon Jul 19 14:48:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 479921 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp4237485jao; Mon, 19 Jul 2021 08:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz94a3oJpGt6dLA6/tseHF/OCw4SamXSlhEXrrL0ZP4vtow4139r1gJoViaqseoT4G0Faxl X-Received: by 2002:a17:906:70b:: with SMTP id y11mr27733230ejb.328.1626708896812; Mon, 19 Jul 2021 08:34:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626708896; cv=none; d=google.com; s=arc-20160816; b=objGSgNqcscyqq9oSqonzVkN8draWvv7y6xT6b5DIcHs91ubnkvH3xd6aRGYTydRfI rZCYQB8/0koiZbmL7MoQ1gzcAmoNZvHPjmYSpPDeOrStZjO3FmK5P67Hh4Gim0aesQdQ I33Lhqcl3Ti/bjV9s6QAEIlqwvZgsc0zTk7AdF47Z7JrY2df4LBcVEhNEW7lbuW+4Cpn K+N9wo0PO+WeCKIhoxa/7yWVookA/MzFxEEJ5MsPKyXdmTqn6lD0tsJRTHxvSKlkiV0N FzAjixqSl361Nsg6KJyQNcJMR5FQX+flZWilWveU04ds3QwcYZMJKafjwNL0FMejc+vs 4j8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dl6u3NTkvVcjWxQ0ht5L9yHSKUhm7So//FNQJ92fDtg=; b=kyDqSOzGt1HLec2kdXcwubh+s3ro3kJQltw7fiywW3tbtX5GqU8eqRbYd0sujJUrIG WpGWvVyVEYwko5suhcdKOemYll5syKo7rXAO1zyVNpD8xDxnSmx3CnBYOEUSq18QhiQr it1D1NVH8Lkcdm8Ls6GKntH+pGBFgMCTloFEz8xSRdbyqfckiqSi1ysrRBbiRzvAm+PH NxS8ZuIXTMlkDWkiMn0lRY8TqxNARFsD/uv3ZjgJYoLh6lNhxok7dO4oFl0i1f0Sogmn LQVZZr9cgqcFhI7AvTCIxNr81cgzyicoiMpPqPZr/fv18kQYffAYEOrkQpOd234bDmUB bbgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XA3hYnDe; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bo13si21364747edb.172.2021.07.19.08.34.56; Mon, 19 Jul 2021 08:34:56 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XA3hYnDe; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244202AbhGSOyJ (ORCPT + 12 others); Mon, 19 Jul 2021 10:54:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:43352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241204AbhGSOvU (ORCPT ); Mon, 19 Jul 2021 10:51:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67C1861003; Mon, 19 Jul 2021 15:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626708703; bh=dlU+t+ZCtT7qwf3dDRl88qYV4ImT7UQSVSAPpHHfI68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XA3hYnDeu5A/6Gt6AXP3oKV/wgzpSW1SU2qtswL9l4MMn+DLa8VDtViEDjVABfMTh WnaPT+8WK5EefatvD8zrW3xlpv0mUY3b9z9Ox0gPm3dXrprbJm6aCLxSRD3tOZwRHp jMW2fJN2TU1bYQD2qDs1KbBC3ewmPwbv+q87yCsM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Linus Walleij , Herbert Xu , Sasha Levin Subject: [PATCH 4.19 096/421] crypto: ux500 - Fix error return code in hash_hw_final() Date: Mon, 19 Jul 2021 16:48:27 +0200 Message-Id: <20210719144949.954370688@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210719144946.310399455@linuxfoundation.org> References: <20210719144946.310399455@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit b01360384009ab066940b45f34880991ea7ccbfb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 8a63b1994c50 ("crypto: ux500 - Add driver for HASH hardware") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Reviewed-by: Linus Walleij Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/ux500/hash/hash_core.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index a0bb8a6eec3f..18ef5b8cc18a 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c @@ -1007,6 +1007,7 @@ static int hash_hw_final(struct ahash_request *req) goto out; } } else if (req->nbytes == 0 && ctx->keylen > 0) { + ret = -EPERM; dev_err(device_data->dev, "%s: Empty message with keylength > 0, NOT supported\n", __func__); goto out;