From patchwork Mon Jul 12 06:12:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 473065 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2718348jao; Mon, 12 Jul 2021 01:17:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwk8lRBOuyNcBVVfeLdh+KPwKgUeSlOdX0zHjJntiv9qHr5Xub/QEWPCtJnIijThHtsEz4 X-Received: by 2002:a17:907:24d1:: with SMTP id e17mr27860492ejn.427.1626077850821; Mon, 12 Jul 2021 01:17:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626077850; cv=none; d=google.com; s=arc-20160816; b=crEORhOa9oZpnoaxPksJ+Bm/P0qG5sZ7R3fdEB3Kgm2NirQt3YTnAVAtdI6BWGoHCm hWLfaPv03my2vTxVZOBPqGbH8KwvLz+saY92nGtEZFamAh4FO8VLpE+mnlbUjvCG6OJF JgKL7+2fFPTAHw86u33cDFqK1meqrIhBfwNnZ3+iFLIh9BILWtW4ixcuhqszvqaLuFbn G0O+HNUh6sLZtEKfxANBSfhCnKZ+Neuni0OyQ2OTChxgfvbxeqPlD9CcwrFElkQz8zWG sUtx3DQS0D4+X8U7CqBWgtTq+WPqIKYsB5v5KB9bER4YwlxVbEtwk1XDpCUADritkRHe wJlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Qriq/7rT3l3hbfkUu5AOl3WaMtudyfWzKjpt1uBTL0o=; b=DSXm7QAJ1ngKXKyZJTE68ku4qQplW4nJVxh018SmfMmqJkJk3ZGleOFa8/bLuj8gCE akDz1Y9bPdgA+yTy9AsftgNabjLYiQHQ5so8kTBGpJP4n5I8bNaRu2ErIRDglgXv33Lh q71arbiMUhj8PyswxZbgh4PVQERIfuO1yX8KKE4BpWfBBeWFUGSBSSCUvcaGgGejIaAA xn2Wp9M8Yq7uigGWiGkoWE9Qj4vSlcI8UsDduQWRTpdpEOS/JiT8SAhK5dZNDziTHt+0 0DCnubWjsrSCneABkoRI6ooG+1FFk2fYBs3jq22vcyN8wKUOBJcQtDAttee70UQR9BdA inRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=B+v4ySPO; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si13642925eda.13.2021.07.12.01.17.30; Mon, 12 Jul 2021 01:17:30 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=B+v4ySPO; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232430AbhGLILZ (ORCPT + 12 others); Mon, 12 Jul 2021 04:11:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353828AbhGLIDB (ORCPT ); Mon, 12 Jul 2021 04:03:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFEAC61D0D; Mon, 12 Jul 2021 07:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626076668; bh=dvT+46BeYcIweLUBtLz0tP8R4ak/r69IrFhf05nTBFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B+v4ySPOJUFim32kUAZf0RV2mERaOiD5wplyBtXZVC8Z2Js3hbXf2V1x2PMjeNOg4 TLdK0S6pru3ZJGhhud15Fhh0IfVnKo+ORvfLMoxPQyqSFi4cNSoIpGhmgxKDgpBlo1 mDq8fplJy5tdblOT+TyQOcZ8I1LjRMmBbNozcw3Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shengjiu Wang , Fabio Estevam , Mark Brown , Sasha Levin Subject: [PATCH 5.13 740/800] ASoC: fsl_xcvr: disable all interrupts when suspend happens Date: Mon, 12 Jul 2021 08:12:43 +0200 Message-Id: <20210712061045.508332979@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Shengjiu Wang [ Upstream commit ea837090b388245744988083313f6e9c7c9b9699 ] There is an unhandled interrupt after suspend, which cause endless interrupt when system resume, so system may hang. Disable all interrupts in runtime suspend callback to avoid above issue. Fixes: 28564486866f ("ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver") Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam Link: https://lore.kernel.org/r/1624019913-3380-1-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_xcvr.c | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.30.2 diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 6cb558165848..46f3f2c68756 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -1233,6 +1233,16 @@ static __maybe_unused int fsl_xcvr_runtime_suspend(struct device *dev) struct fsl_xcvr *xcvr = dev_get_drvdata(dev); int ret; + /* + * Clear interrupts, when streams starts or resumes after + * suspend, interrupts are enabled in prepare(), so no need + * to enable interrupts in resume(). + */ + ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_IER0, + FSL_XCVR_IRQ_EARC_ALL, 0); + if (ret < 0) + dev_err(dev, "Failed to clear IER0: %d\n", ret); + /* Assert M0+ reset */ ret = regmap_update_bits(xcvr->regmap, FSL_XCVR_EXT_CTRL, FSL_XCVR_EXT_CTRL_CORE_RESET,