From patchwork Mon Jul 12 06:12:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 473064 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2718288jao; Mon, 12 Jul 2021 01:17:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6U5g3tXQs7QY6oro5ariRILC+xnoOVj2Ud9x7mDvzCGLeu1aZZogaJoarJeqarSRToEap X-Received: by 2002:a17:907:1c98:: with SMTP id nb24mr52720745ejc.316.1626077844749; Mon, 12 Jul 2021 01:17:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626077844; cv=none; d=google.com; s=arc-20160816; b=FrsHni7lU1lSYGaZ3YrryDMOu+v+YixnQlsR8Rd9IWxXw3GoNQ8N46/DD1pS8e3K5P azhp2015iVODBzgGObYLXbY27vKCMUZOCFJ/S4Ot8M0nldl2wV/NxHxsCNDIqI5QTLL1 xSJhYkOVMmaNurP7XJngJGDjjWYGrENWKMAxZsThGyWOFkkbvmH1DA9y8AyNjthLRpfl WZcV8c9RGJm3I+3H0On/xhukj43f2L+wzyUopN5wT/TitjyF58fgMoX86Y8MV27uciAi MFN5xQ+kxBVBtn6LPLUuSQ2zVI23n7qxMMYgYXtef5Wq1CjC7U0xqrubAbj/Nxr8NNjE uahg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VwBReSlgDnbVS/MSJgy/xeHDWzSlWhy1d0RqjXTRJak=; b=Okx9wzs9rBFIlowagr0bMuPqugUmCltxdCNAkUrpyauRWQKLdWiugVfDYyDcz+ESNk GkoUoz6zZQuK2PBiTaFxsXxtH1cmqI1aoxgsURU394ZR96ACe634rx0Z1g+z/3dSsZIu MwQGVtgHnSKAh7HnW33YquR0wrWo6+qlObCmPpe96kg7rv4GTS6JQgswqU2/ndNqf/jB hjj3/y7Xo1ZHzfb2AUC+pEnefs+O0N9ZvgUDvbcTrQbDiY76Fym0dGmHcac9a78mB2dE 23WuDq/vBS9DbHUX/OjdJbYd1c858ipohaEa8VdFPaMGVxMafeuvRLx2Yui2w2VasBv7 zXeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bmCqVkkI; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si13642925eda.13.2021.07.12.01.17.24; Mon, 12 Jul 2021 01:17:24 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bmCqVkkI; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231953AbhGLILM (ORCPT + 12 others); Mon, 12 Jul 2021 04:11:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:55670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353677AbhGLIDA (ORCPT ); Mon, 12 Jul 2021 04:03:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3CD9F6193D; Mon, 12 Jul 2021 07:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626076649; bh=KlMGQ3e8uTVoH70/r1i913wVeQy3pNxxandWLFVh+yw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bmCqVkkI7bU4aROfxIcKKM1g+sb5OIjFHI92YNeUWZX53BbGwusb91GEOKuTcXXGZ oJL9f5P88yv6CTuHny6hpUmWMGp6ezlaSF8c0cEYaFopvWlh7LFJElpKreenxgqFOR FIeSJgTZ8Cu4gBTZ6X0O3eOl85lYPGW/CDRlSbNg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kunihiko Hayashi , Vinod Koul , Sasha Levin Subject: [PATCH 5.13 733/800] phy: uniphier-pcie: Fix updating phy parameters Date: Mon, 12 Jul 2021 08:12:36 +0200 Message-Id: <20210712061044.763426816@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kunihiko Hayashi [ Upstream commit 4a90bbb478dbf18ecdec9dcf8eb708e319d24264 ] The current driver uses a value from register TEST_O as the original value for register TEST_I, though, the value is overwritten by "param", so there is a bug that the original value isn't no longer used. The value of TEST_O[7:0] should be masked with "mask", replaced with "param", and placed in the bitfield TESTI_DAT_MASK as new TEST_I value. Fixes: c6d9b1324159 ("phy: socionext: add PCIe PHY driver support") Signed-off-by: Kunihiko Hayashi Link: https://lore.kernel.org/r/1623037842-19363-1-git-send-email-hayashi.kunihiko@socionext.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/socionext/phy-uniphier-pcie.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) -- 2.30.2 diff --git a/drivers/phy/socionext/phy-uniphier-pcie.c b/drivers/phy/socionext/phy-uniphier-pcie.c index e4adab375c73..6bdbd1f214dd 100644 --- a/drivers/phy/socionext/phy-uniphier-pcie.c +++ b/drivers/phy/socionext/phy-uniphier-pcie.c @@ -24,11 +24,13 @@ #define PORT_SEL_1 FIELD_PREP(PORT_SEL_MASK, 1) #define PCL_PHY_TEST_I 0x2000 -#define PCL_PHY_TEST_O 0x2004 #define TESTI_DAT_MASK GENMASK(13, 6) #define TESTI_ADR_MASK GENMASK(5, 1) #define TESTI_WR_EN BIT(0) +#define PCL_PHY_TEST_O 0x2004 +#define TESTO_DAT_MASK GENMASK(7, 0) + #define PCL_PHY_RESET 0x200c #define PCL_PHY_RESET_N_MNMODE BIT(8) /* =1:manual */ #define PCL_PHY_RESET_N BIT(0) /* =1:deasssert */ @@ -77,11 +79,12 @@ static void uniphier_pciephy_set_param(struct uniphier_pciephy_priv *priv, val = FIELD_PREP(TESTI_DAT_MASK, 1); val |= FIELD_PREP(TESTI_ADR_MASK, reg); uniphier_pciephy_testio_write(priv, val); - val = readl(priv->base + PCL_PHY_TEST_O); + val = readl(priv->base + PCL_PHY_TEST_O) & TESTO_DAT_MASK; /* update value */ - val &= ~FIELD_PREP(TESTI_DAT_MASK, mask); - val = FIELD_PREP(TESTI_DAT_MASK, mask & param); + val &= ~mask; + val |= mask & param; + val = FIELD_PREP(TESTI_DAT_MASK, val); val |= FIELD_PREP(TESTI_ADR_MASK, reg); uniphier_pciephy_testio_write(priv, val); uniphier_pciephy_testio_write(priv, val | TESTI_WR_EN);