From patchwork Mon Jul 12 06:10:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 473042 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2713892jao; Mon, 12 Jul 2021 01:11:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRbDi7SuYC9BFlGyx1xZlo5iQ7n0cdUp9QAcQCSvG13+g9rLYRWSCMchgMYAiR/cVhG/tN X-Received: by 2002:a05:6402:451:: with SMTP id p17mr62470233edw.332.1626077464663; Mon, 12 Jul 2021 01:11:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626077464; cv=none; d=google.com; s=arc-20160816; b=st7etP/JyBzEf8IQs5qDhKmGWHpgcw/szRykasqLwsrDSQeLGgMHzndOFn/TQ5buLD mHaFFzNYJ8/UE1wWn2mXjVES97hLuriPNgu5VThbrWlSEP3r9I1x225/8YF3mu1YzpM1 d27xmLLvWrFFqEWN3xMXB6w6Cs+sFz4GdC11szluIOVvyC6IHMsRUFdv0JVaJt+vY/iF 5ID4uVkshM04XDte4zMC+KsfhI3Pu71IizhWhIf5G/tcputmMB9aFN/nOfsULWl8r553 T21l+cFOdSt40Duqg0IbXnRyB0aVvpFUoT8LCBh4zeEdee5M1l8dhTkiirzU87oURtkh h4Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZHe3gYhgPgyJbUhDToDzAO7NojFsazKUHxUBLKLl6Ko=; b=ltPHBvdNraHRCSkunvWOumden8Vf0Ylwtn/mNsM8cPYMik3sNQJyv91QD3bSmHkle9 3XGy3koA4EaJoRhCLINJuEXcaPynf7cShNNGdktZZe4WoG6ONEGmzu13JOjt5MQMpNPU oURJ3TLJegExyWuJuGIQi0000XcZsanlVTkgkQIBV2zP+sYEHTqvrJUnp7a471FkOlPA I+INayBbTrT+j3jyU/6hwHlQQDSbGrMY5WRHn3G3nkCo3PsLj7EuyQ+k/ZKkZPGCBO24 Pa0r+Ul/9DVDle+PlBd3O7OIq/hGqktawTRxn4Ry3oaV5JMR1Sv3rjliN/qLrmdNglu9 4j/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ParyDvLG; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si13642925eda.13.2021.07.12.01.11.04; Mon, 12 Jul 2021 01:11:04 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ParyDvLG; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353041AbhGLIJQ (ORCPT + 12 others); Mon, 12 Jul 2021 04:09:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:55110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352619AbhGLH7e (ORCPT ); Mon, 12 Jul 2021 03:59:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B43BC61186; Mon, 12 Jul 2021 07:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626076412; bh=q0kgSQ+nvfk1kPn0gHqgc8Mtyw07CI6RK73Q2udLmDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ParyDvLG43TCNApmcz4vzeRRCkIyuj8/kS8+xHAnk7fppA9+SmuE96fqctGeX5mUK kT3sdJUccRa45GyR6W0O/JRBA2l5wKY15LIcpCU2ZMs+wxjclSEtRPWU+yE8R7LXRA mDmSjWAvlmRWhfl+tDsUMJWdm7YfNWYSpS/cO2Pc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.13 632/800] iio: light: isl29125: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Date: Mon, 12 Jul 2021 08:10:55 +0200 Message-Id: <20210712061034.403312286@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cameron [ Upstream commit 3d4725194de6935dba2ad7c9cc075c885008f747 ] To make code more readable, use a structure to express the channel layout and ensure the timestamp is 8 byte aligned. Found during an audit of all calls of uses of iio_push_to_buffers_with_timestamp() Fixes: 6c25539cbc46 ("iio: Add Intersil isl29125 digital color light sensor driver") Signed-off-by: Jonathan Cameron Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210501170121.512209-18-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/light/isl29125.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.30.2 diff --git a/drivers/iio/light/isl29125.c b/drivers/iio/light/isl29125.c index b93b85dbc3a6..ba53b50d711a 100644 --- a/drivers/iio/light/isl29125.c +++ b/drivers/iio/light/isl29125.c @@ -51,7 +51,11 @@ struct isl29125_data { struct i2c_client *client; u8 conf1; - u16 buffer[8]; /* 3x 16-bit, padding, 8 bytes timestamp */ + /* Ensure timestamp is naturally aligned */ + struct { + u16 chans[3]; + s64 timestamp __aligned(8); + } scan; }; #define ISL29125_CHANNEL(_color, _si) { \ @@ -184,10 +188,10 @@ static irqreturn_t isl29125_trigger_handler(int irq, void *p) if (ret < 0) goto done; - data->buffer[j++] = ret; + data->scan.chans[j++] = ret; } - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, iio_get_time_ns(indio_dev)); done: