From patchwork Mon Jul 12 06:10:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 473034 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2713715jao; Mon, 12 Jul 2021 01:10:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVck1vL/3+PZhc/kJsmH84mgv5+U+H99Fiz8xsBJHwQQxmXFbhSGt19f3SK5fL8t5/oVel X-Received: by 2002:aa7:cd5a:: with SMTP id v26mr8041834edw.287.1626077451564; Mon, 12 Jul 2021 01:10:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626077451; cv=none; d=google.com; s=arc-20160816; b=mWbowUIXXfj7lKGgqxdsERuMR7ZoNBd7oeICI2Tyj/8gok4wsWtfUKglH0krbcdCR1 SVsUPXPQcOceHcwc56ZT0uWcGCstrRa1ojQd3pi+OZZnmDJQCmYMBqPuS9nNry/lJZ1L /jHBwkQq6COWRnzWOdyVbby+l2bMDRHqeJYxAyapgu0+PFvI1gwUe0QkNbmKzu4/rFo1 dYlxKl9/kbrl7zHPyHlISvSb168S9pH/WsXqbk1Y1/1TTFml4f9RzJS+xWKcOoJ55w3A i6ABUh5txaywxb9yUmVVDWDr2H+9mfN/dUVl19NO54pOCDR7RmxDFf8TmTieAbp6yflE 7nWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g9cuUdzTQ4TWnHOaZsAEL62l81I1IrHxEHRHaKU+PmQ=; b=U/5RrILa2McWqcwwyyWIX9wvy4n1tYZg8YywF10jKzcmTD78UoN1TNtMpMj4NGLBsE ZPo40CFuPrLGS2GmEN8GxdFlK6Xl8cfJKoI3Z+naorjBoTJNphKzao5ftj12hvBrhz9G j3qdr+ASJ5ImcY8BSzqFK9p3blxfUML9qasCcLASyekh3gSxwy8YRlzBCP27Ene1LiKW h1XH21PlfWqQtvZQeZTnSEzwZRHfi5lDuy5iuz97rDSNYz05rr9CxZHaGbaH7ezIABSc +KTacMr+KZ7r92GmjnXkXxTqXcAPlaVxGLfdcdtQCG+cDXvolOg35Gpej3ATXBnn/RQK CIkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o51gpmwR; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si13642925eda.13.2021.07.12.01.10.51; Mon, 12 Jul 2021 01:10:51 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o51gpmwR; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbhGLIJF (ORCPT + 12 others); Mon, 12 Jul 2021 04:09:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:45368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344930AbhGLH6p (ORCPT ); Mon, 12 Jul 2021 03:58:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 633E86199C; Mon, 12 Jul 2021 07:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626076390; bh=0vtx1rzit57snHuBv4JPMsOTKelZthfIUK7q67ljMk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o51gpmwR1yrM4IC2jNhmxclmbcpztpkeFq1cQ+/WnhEzsaWcJ8K6ONxsqXnbZs6+e CffePcofb1pbOEVqW0xXkbdi0b+/fR0uRzfnLa+atwVv3znSeB7iQnfrx/jTPbAEgU B4UxRyY0r66js++xmLqZ1tgr/ddOjSi5lu6Cd+R8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Stefan-Gabriel Mirea , Sanchayan Maity , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.13 624/800] iio: adc: vf610: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Date: Mon, 12 Jul 2021 08:10:47 +0200 Message-Id: <20210712061033.646880123@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cameron [ Upstream commit 7765dfaa22ea08abf0c175e7553826ba2a939632 ] To make code more readable, use a structure to express the channel layout and ensure the timestamp is 8 byte aligned. Found during an audit of all calls of uses of iio_push_to_buffers_with_timestamp() Fixes: 0010d6b44406 ("iio: adc: vf610: Add IIO buffer support for Vybrid ADC") Signed-off-by: Jonathan Cameron Cc: Stefan-Gabriel Mirea Cc: Sanchayan Maity Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210501170121.512209-10-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/adc/vf610_adc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.30.2 diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index 1d794cf3e3f1..fd57fc43e8e5 100644 --- a/drivers/iio/adc/vf610_adc.c +++ b/drivers/iio/adc/vf610_adc.c @@ -167,7 +167,11 @@ struct vf610_adc { u32 sample_freq_avail[5]; struct completion completion; - u16 buffer[8]; + /* Ensure the timestamp is naturally aligned */ + struct { + u16 chan; + s64 timestamp __aligned(8); + } scan; }; static const u32 vf610_hw_avgs[] = { 1, 4, 8, 16, 32 }; @@ -579,9 +583,9 @@ static irqreturn_t vf610_adc_isr(int irq, void *dev_id) if (coco & VF610_ADC_HS_COCO0) { info->value = vf610_adc_read_data(info); if (iio_buffer_enabled(indio_dev)) { - info->buffer[0] = info->value; + info->scan.chan = info->value; iio_push_to_buffers_with_timestamp(indio_dev, - info->buffer, + &info->scan, iio_get_time_ns(indio_dev)); iio_trigger_notify_done(indio_dev->trig); } else