From patchwork Mon Jul 12 06:09:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 473027 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2710267jao; Mon, 12 Jul 2021 01:05:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8yKPbQpeQU4CQiU6dMW8LxW34gtLofto5J2IET90p0zKKMWb0cqWIn3jzlfTCnkc7+G4e X-Received: by 2002:a05:6402:502:: with SMTP id m2mr39236013edv.57.1626077143991; Mon, 12 Jul 2021 01:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626077143; cv=none; d=google.com; s=arc-20160816; b=q1qtMn5jsCjo66Z3XZuCyw2esqppP7G8RJs4xnzUOiq9Z6DUTK2mfZjXmDSMJCrFoA zmOx7OhyR2REAzD/hXDoPPOwBia2ogBLTsznWkcTasf1lPv9TvagGcVePO8GhFSi1WEe WXU4xdhz28ONoaJkimR3Pe6PlH5kOw37FAPO0wb1p8SZJeK2PvdG0K19uwiO4+5DjoRP 0CiIivUDTJ4MD7qdE+HaFuPOEgiLY/iLdUkgS5gCJLsZUlDHxwcJ36aPV23VNnwwZC97 8TLm+l69RjCSG40I9JW9jZUXd78bIn2wqo2sBB+jC3zvhGWUciU0OHZwEl1xgMemVgRI yRfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0MjvVkAZ295VawANck+IyCFnKRhxsPjkSOJlbK2wazY=; b=F7TMHvJR82Tb5ejpxWPC/fGbuOd8mjw1JXuY/W+wTGglaDXrkmh9zzuOj2iVtiKgmk bV9xeZI0T7Y8TyGGt9CXpqQjr3GwKbNm0uDoNEAFHCDUz3iPsRth4zOCuVzwz8S6/Mqw qSSewA+QMhMJDln6ABB8uQ/oSm586SScYiO7XzHIMPK/0AlEziuH7r2uEsYNBhI8qQzL xoqxCi2uxdytQ2oZaP8YjNSC12SH6HUMvUD2YLjNJaIHp1AEXHNh+6fvKlhWj7H4ltue OCUjJg89Hgnhi7Da0TcrZ70I1YQtDf/LbVguoaHEp6LDKBRyYmblx1uURvN/Ec59thC5 Ba7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KFiuyQck; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si13642925eda.13.2021.07.12.01.05.43; Mon, 12 Jul 2021 01:05:43 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KFiuyQck; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347650AbhGLH5O (ORCPT + 12 others); Mon, 12 Jul 2021 03:57:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:42062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245745AbhGLHxN (ORCPT ); Mon, 12 Jul 2021 03:53:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3575661158; Mon, 12 Jul 2021 07:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626076223; bh=kIZ60M1nZfkEOjXB8kpvTant4ngMp9YGmo5D06dDtss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KFiuyQcksQOlrFF9wlCj7cihb9NKjzEDk/DrimXHfF1xxt6TG20m2dU05G0y0+yXe KHd4SKAZrWqJPnEVkKnCn0R0n87P9rVS3S4UcEvLDBq0HzQD96Bo/3vXHLVN8xwGlS O6wTL/u7cHVbxnldvF20y0zlt24HYuLXlsAaxKFw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Dmitry Baryshkov , Rob Clark , Sasha Levin Subject: [PATCH 5.13 550/800] drm/msm: Fix error return code in msm_drm_init() Date: Mon, 12 Jul 2021 08:09:33 +0200 Message-Id: <20210712061025.889215075@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit a1c9b1e3bdd6d8dc43c18699772fb6cf4497d45a ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210508022836.1777-1-thunder.leizhen@huawei.com Reviewed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index fe7d17cd35ec..afd555b0c105 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -523,6 +523,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) priv->event_thread[i].worker = kthread_create_worker(0, "crtc_event:%d", priv->event_thread[i].crtc_id); if (IS_ERR(priv->event_thread[i].worker)) { + ret = PTR_ERR(priv->event_thread[i].worker); DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); goto err_msm_uninit; }