From patchwork Mon Jul 12 06:05:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 473013 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2698044jao; Mon, 12 Jul 2021 00:46:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBLT/IdSh2Lu6a95BAjlAo6MqrtCaPbgbJSz34VrHfjETVCTSi2dNbEaNrrcClA+vkmx2Q X-Received: by 2002:a05:6402:22f4:: with SMTP id dn20mr4444550edb.335.1626075928646; Mon, 12 Jul 2021 00:45:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626075928; cv=none; d=google.com; s=arc-20160816; b=oNIK6B+XWSBufdfRk5qzzY2hJy3vt17/MyLn/N8hRTOyh+QyP/AjqaXY5Inh3OCTbO XEMmCeFO+TeDgaTBtoE8tjKOCO1X83VJvr2W7W47CqeNNsFH9h9u8/8IRWKYLLmeJ6Sg 9B6wVhTvlTp0xgUzSAbVhoymJXS3isdmQ5WTC8fM4d9yvBqRXlETuEB1OPhiP9dOc0eI Z4H6aCpQiFYIFtDs+/EJJJVLaFDttx0Iy2X0uTGEEFZ0To/KeoU+Bpp5iVWU1VGfTmxN ZGqoENSULmGqmd1Khf/Q6ggJ0zcZH7lB69SsJ/5O74tz3f4FaoO2/oyml3Zzivo9iZ6W o+1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=U0CA7eONEaKIUEqvMK4JPeridNcp6BNIfI9EAozvor4=; b=Phz0uMwOOntDHv89edGFb/yy+xdm/+taeDihDnBOWXa3I8LKGtsLA35e3Ziq5GpzIU Ph1RJcIBxWtd6zxYLoM454Uhm+O3lev4yhNKkS8MXaKnQDTLQgCLh3fwqyRrQ+te93m1 K/XA6J1duU99NnS58qVLW3zqsZBROTPGOgkJ8AM9YujNagEQi+dGIJjN5ENd0zhn38/9 o9aezVXTyGznDvFKMDk5PxOzvqE7pxFfS0EDM2ftpkSZQd1CS3U9ABUQ5539+FMOqcet 0k2rmOf2qUj+VazW55LGeQPrKiy7sprpJGCN4BRMtBddEAynEVl6mq6RXhq/LmuFdmKp ALFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m8O3yf2s; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n21si13642925eda.13.2021.07.12.00.45.28; Mon, 12 Jul 2021 00:45:28 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m8O3yf2s; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346028AbhGLHpn (ORCPT + 12 others); Mon, 12 Jul 2021 03:45:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:51472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343915AbhGLHno (ORCPT ); Mon, 12 Jul 2021 03:43:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F17E061166; Mon, 12 Jul 2021 07:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626075638; bh=K0RB13v0alRNHwX75C8a5XcddkCCjo9XD092qfbXoss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m8O3yf2sqAK1pkVqatWMctjpEQ5Nhlkd0MmSBSM0pj0YdrLLiwQnTHRuFxbYc9egY mnmTgpJSmC9man7bFXtMKqEsFskkqsVM0GrkMGrUdZl98jZ9kHDOzte+xz4A21tykb R3AOlgJ4F4JHxJ5K6FB1Ay+4Hv6uQUSR/BtK2ji8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.13 301/800] media: tc358743: Fix error return code in tc358743_probe_of() Date: Mon, 12 Jul 2021 08:05:24 +0200 Message-Id: <20210712060957.301466817@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ] When the CSI bps per lane is not in the valid range, an appropriate error code -EINVAL should be returned. However, we currently do not explicitly assign this error code to 'ret'. As a result, 0 was incorrectly returned. Fixes: 256148246852 ("[media] tc358743: support probe from device tree") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 1b309bb743c7..f21da11caf22 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state) bps_pr_lane = 2 * endpoint.link_frequencies[0]; if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); + ret = -EINVAL; goto disable_clk; }