From patchwork Mon Jul 12 06:11:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472926 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2662286jao; Sun, 11 Jul 2021 23:53:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNkyLi9bDpWGjsXHVJLTTdLhracKEU5vUnslzm3jehlGXBdIo7xLjSUXwlIkW/6VksPnn6 X-Received: by 2002:a05:6402:51c9:: with SMTP id r9mr62181107edd.326.1626072677125; Sun, 11 Jul 2021 23:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072677; cv=none; d=google.com; s=arc-20160816; b=s1E9kyHqoQcYvHQIIXkqEDRQAvJH7oF/64es3mXhwzMH8Z7hgfUcWh4QJdGBbYML6h ikmq9bhqWumqgjH+0f/qUWZraVohVNd1Jx1IBL/besjJgcK18ks8nnODadLwUvNDuDW8 CZzeMKxuXupMPgHLP97ZeDln/ZnAPFXzVOLj6eIBr0cKdJaSRVctkDVJht9INZ+RtMXZ zHNQbJQVld3H9kCsmTtCvOPj9LQ6BSJhNhyXgZVSJc/QfwyX394q/C4HxJUaS6dY0SA/ Qq3xkiPOFWu3FVyrGVQ2wLma/OZmILi72ScNrBRrtyi00QXbW6o/bUWC0j4WScxmMdyf bXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=URhc9y0JTbW13221WTbEj03HmYAXiwQKqRC5IAKwesc=; b=XhIyR+gniPICqJUHzhsAx7qd5EugaqDWmQOlIZ8g5F4C3fkluxPgh64o6D6gPdi8Mw QqmwgNWlxzU7Pgu/Wcrr/PoOFfa9yGexwxW72BnTbnTJU9td0Jzz+4MAQg6nPvTJ44qi 49eb18GqrMK1ER0Gga0DjrgRbDmE41vWObOBlaXh1CIMndwkRXCDElh4gMaJ4SoZRKyW KTkNUdvY+lLdmEtPOsCPLtm/XvwcJeaaEOJhYvy2bpGAFM5jcupSt25L7EGsA7uWOMlW K3RlNeMeZ1gYp+BO2ugxXeAiBNs81UunKIJ2Eqh8j6d5hyLpv3P/lysZcho8ssEliz55 nuZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="PyyNYZ/U"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si3440466edp.437.2021.07.11.23.51.16; Sun, 11 Jul 2021 23:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="PyyNYZ/U"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235750AbhGLGxV (ORCPT + 12 others); Mon, 12 Jul 2021 02:53:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240471AbhGLGvy (ORCPT ); Mon, 12 Jul 2021 02:51:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 153596112D; Mon, 12 Jul 2021 06:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072533; bh=GwE8RPq5pMt2EPWshQUKIzJE5UeMVqs9MYiF1KNprCw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PyyNYZ/URTkznWvBYSOHWsvZSZxqw/cO3qwufRSnkQqiFT7G0Pj1MG+h/OwJBG7Nc pZccP0WHZdAiC3Fx93yxwjoz7ENzSbm/J2n7jfz6PaQBj1+skP/XdAG8PKU/rrgbKp T+vsGYk1+0ZStgUg56Y/O3OUGmB0qpz9kFycoalY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Mathieu Othacehe , =?utf-8?q?Nuno_S=C3=A1?= , Sasha Levin Subject: [PATCH 5.10 530/593] iio: prox: isl29501: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Date: Mon, 12 Jul 2021 08:11:30 +0200 Message-Id: <20210712060951.748732631@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cameron [ Upstream commit 92babc9938ebbf4050f2fba774836f7edc16a570 ] Add __aligned(8) to ensure the buffer passed to iio_push_to_buffers_with_timestamp() is suitable for the naturally aligned timestamp that will be inserted. Here an explicit structure is not used, because the holes would necessitate the addition of an explict memset(), to avoid a kernel data leak, making for a less minimal fix. Fixes: 1c28799257bc ("iio: light: isl29501: Add support for the ISL29501 ToF sensor.") Signed-off-by: Jonathan Cameron Cc: Mathieu Othacehe Reviewed-by: Nuno Sá Link: https://lore.kernel.org/r/20210613152301.571002-9-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/proximity/isl29501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl29501.c index 90e76451c972..5b6ea783795d 100644 --- a/drivers/iio/proximity/isl29501.c +++ b/drivers/iio/proximity/isl29501.c @@ -938,7 +938,7 @@ static irqreturn_t isl29501_trigger_handler(int irq, void *p) struct iio_dev *indio_dev = pf->indio_dev; struct isl29501_private *isl29501 = iio_priv(indio_dev); const unsigned long *active_mask = indio_dev->active_scan_mask; - u32 buffer[4] = {}; /* 1x16-bit + ts */ + u32 buffer[4] __aligned(8) = {}; /* 1x16-bit + naturally aligned ts */ if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) isl29501_register_read(isl29501, REG_DISTANCE, buffer);