From patchwork Mon Jul 12 06:10:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472914 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2661763jao; Sun, 11 Jul 2021 23:52:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMIteLjFeQ9Y7Ui+dLs5Xkz5RmtwqGdNRGGJnYKdLu48J58W/b0Mgu8ZR3lfa66GcCRLAV X-Received: by 2002:a50:d642:: with SMTP id c2mr7367214edj.22.1626072658013; Sun, 11 Jul 2021 23:50:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072658; cv=none; d=google.com; s=arc-20160816; b=cMuAnKjB4J70o8Apu8BhlVX06ZxpJCN/HI6DFlUYRBRDgURp58rQJ3rA8VKrb/TVe5 f3apY/F4YRxn3qjpYolrLjXo92eBLg9VbNUMT+bK7IcHL/TcxIV/D95zS+jJzZnd4181 z9ndzA6BIZd2Y80ERVKUovR7YJTgx5s9aEeAvQVTCvRjMpyYXk7VmuM5ghXTkhvWrh+9 LjABxY1tDXj9s3OpBaYbCotELuJKRi/E65eFVfjSfCqSJFMSYX23qVb1TjsrfTNYCqaN Vqpi7qeW0A0a8EE9ykpmuAyNZK+0QhxFp4vgCGloz/ooGCDayneG4UcgQ4g6r0qb0cxU 3oyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WvCXsuu5Zfoy72a5BG/G+iqKWNYOdOR/MnkRpWpFFjI=; b=O/7cTsX7aGT6WYc5gGG7ohC2FFoafQfVYD1SnuccyoRSTPvihI8mSW0JnmnZS3ihPA 2ErxbRq9SDDTlJvT9xSspVoQFVswJ/+7LxTeuDNWFgZNRC9rA03kLM5fbqujBmXvGWeg UNPBBXfH+VPHcrxnwHAvTmDVy/ZZZ33nJogNo5WihYKGLh0pdRqSPOOkiDqF4DiAbdrF KITccuTO5CdEl+7YGox4NLNl82odRR0YilTAz8ERMJR2f21K5Ic9bS+I936vVzkF+l7S 4pw+AYqQWQs1sld1EgN6NCF6VPLWD0MScQQ6uLvoSXMe6BrP275LRSxS/5Yy7irn0twd 1u1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uFZJxZqK; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si3440466edp.437.2021.07.11.23.50.57; Sun, 11 Jul 2021 23:50:58 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uFZJxZqK; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239828AbhGLGxD (ORCPT + 12 others); Mon, 12 Jul 2021 02:53:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:48266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239060AbhGLGt2 (ORCPT ); Mon, 12 Jul 2021 02:49:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3078861166; Mon, 12 Jul 2021 06:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072356; bh=FMiubnISiMI2iY0NdN5wTlY0ucMqsT2sp82WSl3hFSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uFZJxZqKe3UMrZNqtUQmfK/y7ugyVgruATsc2Gu2nNuzMjR6FxmtSoRDKwwsnbIIy zlioOAT/lBr5OVTAOhjqc8H39Ni8PKIaxqO916C6Mva4N1jMLjXhcIouSEUSeryJwm yiIFaa6Mfq3Ha2UwEErPQUq3JZeesM2565sRX19c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.10 462/593] iio: light: tcs3414: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Date: Mon, 12 Jul 2021 08:10:22 +0200 Message-Id: <20210712060940.436031367@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cameron [ Upstream commit ff08fbc22ab32ccc6690c21b0e5e1d402dcc076f ] To make code more readable, use a structure to express the channel layout and ensure the timestamp is 8 byte aligned. Found during an audit of all calls of uses of iio_push_to_buffers_with_timestamp() Fixes: a244e7b57f0f ("iio: Add driver for AMS/TAOS tcs3414 digital color sensor") Signed-off-by: Jonathan Cameron Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210501170121.512209-19-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/light/tcs3414.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.30.2 diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c index 6fe5d46f80d4..0593abd600ec 100644 --- a/drivers/iio/light/tcs3414.c +++ b/drivers/iio/light/tcs3414.c @@ -53,7 +53,11 @@ struct tcs3414_data { u8 control; u8 gain; u8 timing; - u16 buffer[8]; /* 4x 16-bit + 8 bytes timestamp */ + /* Ensure timestamp is naturally aligned */ + struct { + u16 chans[4]; + s64 timestamp __aligned(8); + } scan; }; #define TCS3414_CHANNEL(_color, _si, _addr) { \ @@ -209,10 +213,10 @@ static irqreturn_t tcs3414_trigger_handler(int irq, void *p) if (ret < 0) goto done; - data->buffer[j++] = ret; + data->scan.chans[j++] = ret; } - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, iio_get_time_ns(indio_dev)); done: