From patchwork Mon Jul 12 06:10:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472901 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2660446jao; Sun, 11 Jul 2021 23:50:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/32xOe8Tif93bwGUbRkohhFan92qcBYJP3MvC25XEBb6dDc7y+0/gqs1PxlEsydPzoQW7 X-Received: by 2002:a17:906:2413:: with SMTP id z19mr19208446eja.215.1626072612854; Sun, 11 Jul 2021 23:50:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072612; cv=none; d=google.com; s=arc-20160816; b=XDLmlMVqprlYsV/GFIc/GvjmWmec+dAEx7DPIucZfjQUI4jJ8wint1U4/eaFv6Gmcl bBaCSpbPDOAY5DFlpmjxz3OvcFSTNA7y6+C+p+sotqz+/U1cD3bG2N272oq8JsdoJmIq SCinvsrQuNwVK3P48oRPXJaOiap+AD5zZ+8B7xx+PTA8bdmCSpKkNoDF7Z8eg9VEyW+0 07Yy3LdNbkTVYQ9RxpIw4G89S9WQ/Is3wb/68bh9fskxAsXtwt91TjKLyvqIUxlcXb38 5e32Y0WKuSCk3JCF9oAEgr04j6Gt9IzlrdzcoBZrlHkXjOtJ5v/uvzy7tpKIsWc4vEsD syoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t0fhFmnJ0+tnMbD7d09nQuMBTFHz7BADVLAxlvTKp3U=; b=ODALYL2gX6mpEC3EU1QG3A2t90kjJ98i3Q58Ze9zXPlKrvScDHAngThwto0bARfEGz iZykpKj7ZHl40ixI8uXRI506KlOqa3xQLV1RwyhQ9RZmaG/5phFAeCv8NztmwMbxfB1k w/u6w1EvjUoe8GMz8nSY4dAesbFR3aNqz6qS7U90LmUcTMWWj2l7NPj5pj5MH/AWz6vc ziZiyx39gQEBjT5eKapjCOh6gsYsMgXN08nDIRvaXjA90uutw3TU4JaRtFvJ5ty88NIw bNWi6vwyxC84n/UvZ0m8MyI8SNia2DaLbRn65Y/NfR74e1SZTZI17qIu6NQSxrVtKu9B PBRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="t/XB1hcN"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si3440466edp.437.2021.07.11.23.50.12; Sun, 11 Jul 2021 23:50:12 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="t/XB1hcN"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236028AbhGLGwU (ORCPT + 12 others); Mon, 12 Jul 2021 02:52:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:45530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238767AbhGLGtQ (ORCPT ); Mon, 12 Jul 2021 02:49:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 110B961132; Mon, 12 Jul 2021 06:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072314; bh=+lfO5Mra7CXAT9kFyiufjx760HDX/3j3Uo37TVVnrak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t/XB1hcNNcckMAmv4RjCLrf2DHrjWoQw0Rm9eppwE6PzZW5YEAzVnovM/2R5QKKy5 Ms7hiP3PlhZ1siXBwMLOLu0Do2W9tliPs4qzv34cB8VV8HxlF2n6uGA/6DQyW5/nto iaXIjn6UUGC/WwdmhLWFzMW/3iH1PVJ8wET/+qF0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.10 446/593] iio: accel: bma220: Fix buffer alignment in iio_push_to_buffers_with_timestamp() Date: Mon, 12 Jul 2021 08:10:06 +0200 Message-Id: <20210712060938.128944045@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jonathan Cameron [ Upstream commit 151dbf0078da98206817ee0b87d499035479ef11 ] To make code more readable, use a structure to express the channel layout and ensure the timestamp is 8 byte aligned. Found during an audit of all calls of this function. Fixes: 194dc4c71413 ("iio: accel: Add triggered buffer support for BMA220") Signed-off-by: Jonathan Cameron Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210501170121.512209-3-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/accel/bma220_spi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.30.2 diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c index 3c9b0c6954e6..e8a9db1a82ad 100644 --- a/drivers/iio/accel/bma220_spi.c +++ b/drivers/iio/accel/bma220_spi.c @@ -63,7 +63,11 @@ static const int bma220_scale_table[][2] = { struct bma220_data { struct spi_device *spi_device; struct mutex lock; - s8 buffer[16]; /* 3x8-bit channels + 5x8 padding + 8x8 timestamp */ + struct { + s8 chans[3]; + /* Ensure timestamp is naturally aligned. */ + s64 timestamp __aligned(8); + } scan; u8 tx_buf[2] ____cacheline_aligned; }; @@ -94,12 +98,12 @@ static irqreturn_t bma220_trigger_handler(int irq, void *p) mutex_lock(&data->lock); data->tx_buf[0] = BMA220_REG_ACCEL_X | BMA220_READ_MASK; - ret = spi_write_then_read(spi, data->tx_buf, 1, data->buffer, + ret = spi_write_then_read(spi, data->tx_buf, 1, &data->scan.chans, ARRAY_SIZE(bma220_channels) - 1); if (ret < 0) goto err; - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, pf->timestamp); err: mutex_unlock(&data->lock);