From patchwork Mon Jul 12 06:09:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472941 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2664774jao; Sun, 11 Jul 2021 23:56:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHT142jX7tNNEFq5SE1mEV4ENmyzT/7khe2d+O8TSVwrPJ81LmCPf6hMbI8/oRtsptiqwM X-Received: by 2002:a17:906:3402:: with SMTP id c2mr50866491ejb.213.1626072652523; Sun, 11 Jul 2021 23:50:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072652; cv=none; d=google.com; s=arc-20160816; b=QAh0pSjf2UdD2b0ooi6w2lJoQqwbvf10C1gBmDDJpUHm5Bo4Nu/Wr5rXWYiH4tESlA ZRWsRqxQMNN0VY9XLd5aT0dIFx6KBiv69E/jXuc/5bXpDQY0c8sDMYLP0Si3juaj5jnc gReZ3JH4ekkQ513udiCAjLgnWIK5r6zi9p7trcuqkl4tFX/eSugpcmwz0Pi41X1qjA6S acdjYANpMecIbXefhrOcyMhNRYGewGUS5PAl2qjmph0VCtG8senxRoPehzoHb93R9nfV f8oZCTPlPh0TLYWT19KB3Wp4tLhhTy2C+j4+OjsmEBwXYB53F0BUKDoqBb+AMN8FIofR VeGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A4wRdiIj9s43D50nz59qz5HG+phfglVkRai843GNK1A=; b=zgIzEcll9wQWqwH/u4Cf9t5+8slDspSSmVob1BxdK8VVpVAAMWcZWVXbKPAvw8J2rK mT/Ez/NPo0uP4H7bj6wlLbF1kY0Sf4XUvkVADtR6EuKJau76qmPR22cBLEVJDbC/UFzw nG5/qw85TaYgIeSKidljbUJnj3nNjBvO9zmWSPWHIpT020i7eq1Pur6xazd6iujSyJir HgUCw0gzAmFWmouAXD57BiGFoUekanRxdcIXq79Nc7/AR6DN4ZcChFSbtggCxW9YaKlM IzhhG+Tp1M4YrJMny38tDmpDTarufMMZzyfB1adEVbhI4+nby2yP15nWbb0bydxYy3F7 5x6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ICiEGmlU; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si3440466edp.437.2021.07.11.23.50.52; Sun, 11 Jul 2021 23:50:52 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ICiEGmlU; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239416AbhGLGw4 (ORCPT + 12 others); Mon, 12 Jul 2021 02:52:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:48056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238050AbhGLGtG (ORCPT ); Mon, 12 Jul 2021 02:49:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D643D61186; Mon, 12 Jul 2021 06:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072283; bh=Fgcqlh07d0WQ60Zn9ogwcPJ8AZBY3gyRBXAYr2Ty8Ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ICiEGmlU4RwBXGOYbDOwqEnY8SsSYuW2vkp9D0ZpSVwCrlIQM5BhEWCWii0+j5BEr N0uCccLPkbnWf0IGuyuyGWaDvH7/Gqfln1UaHqCIgbDmjOwRe44VK5e2/COO6Z2hvA R4peX5Zri81EOBn8QfEbiEmFgtMBbofqmNfVStpg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Dmitry Baryshkov , Rob Clark , Sasha Levin Subject: [PATCH 5.10 389/593] drm/msm: Fix error return code in msm_drm_init() Date: Mon, 12 Jul 2021 08:09:09 +0200 Message-Id: <20210712060929.992228424@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit a1c9b1e3bdd6d8dc43c18699772fb6cf4497d45a ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210508022836.1777-1-thunder.leizhen@huawei.com Reviewed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 0aacc43faefa..edee4c2a76ce 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -505,6 +505,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) priv->event_thread[i].worker = kthread_create_worker(0, "crtc_event:%d", priv->event_thread[i].crtc_id); if (IS_ERR(priv->event_thread[i].worker)) { + ret = PTR_ERR(priv->event_thread[i].worker); DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); goto err_msm_uninit; }