From patchwork Mon Jul 12 06:06:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472885 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2653959jao; Sun, 11 Jul 2021 23:39:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL/Zh0eJptPY7sbBP9FPb+yAEwxNHN2ELGSERsW/1UlwuaAPzlrJe7Nxk6LAYOpPSWMQFy X-Received: by 2002:a05:6402:451:: with SMTP id p17mr62075536edw.332.1626071979454; Sun, 11 Jul 2021 23:39:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626071979; cv=none; d=google.com; s=arc-20160816; b=dbLXo/YrpTcoQxs9iDLzBtNxpb3eABkIEuZn2IB8zaAeWzbf/S1LEMWk+DE602YiWj 5WLKgIjVpMf1yDaB20Oam7zAWJuG05UWNpQC5B+stFefMitEjMtg1lI+/mJh5FTJZnuI XSq3/DjL8/FwcuphXTGJI8qJuzk5EkwM11/othg5ss1mXZh31OTdy2rFp+Kpdybr3oUf Qcnm3ZEZPCm9b7dHV5J2kGbyCjy5BilU5AmXy3zPD2WSUSMR1j5wmkro1gnbCKFx17d1 2XUO8Mi6nkfPm04O3jKAqc8N865UbJoY3vKmnfraekNaPea3B/cB0u2dmaw4o7+Ij3/t 1mmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Lhn3ff/xcRgypht8B6I4KPSNUk8stGGsGUonpxA2m/k=; b=uqMnnMcUFF+nPlePrVJSP/RL2Ykl6QWS/XjIK6x9qJzdMj73Yp+5JhMbh7iA9aBKD0 xE5pSkwpxDosWbAp1hABfAy55AatCC298zOaO22HadVvr6eFaxCVma740I4Wdurb57OZ N3nkwdCroViB+n3PpaadwgnbqH5BDNK6ai6m74bPdtqml2rGavGgt+PnHeaxVyh1cyRB SV3nqdEWlxWYWmL/Msd09xpmPyHssY8zOueknzlwF6xIy+rafU5sXAKGpWsQudc8d5ZW 6AX9aYGNoYHlBL9tbkthpZj+BhUiTmhrC8OgghT8K44gCNv+gnSSznTmnjJoaoYfwC/A ERLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GYJihDeX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id en10si16062540ejc.118.2021.07.11.23.39.39; Sun, 11 Jul 2021 23:39:39 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GYJihDeX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235788AbhGLGkl (ORCPT + 12 others); Mon, 12 Jul 2021 02:40:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:34334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238137AbhGLGj5 (ORCPT ); Mon, 12 Jul 2021 02:39:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE0DD6121E; Mon, 12 Jul 2021 06:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071777; bh=obXfwdfgfnX/URfyq+fECvSq1NSWtujCIhTIwSwwAZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GYJihDeX6GmKnXYQTJy7/FsAectgOJK4nX6YIxlX7ReVgZmj77jnkBjXVJItRsdoZ +DM+ZSfGqbza0EV6S0I6HuLp+8ZSIp3ZGdLJYPCI37z7q79CBttqd+QSyzQEymSmHX zEW2oMNzGFCjvS8oAYmpEB6KwTgkr27QWz5QQWe0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Linus Walleij , Herbert Xu , Sasha Levin Subject: [PATCH 5.10 216/593] crypto: ux500 - Fix error return code in hash_hw_final() Date: Mon, 12 Jul 2021 08:06:16 +0200 Message-Id: <20210712060906.681873615@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit b01360384009ab066940b45f34880991ea7ccbfb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 8a63b1994c50 ("crypto: ux500 - Add driver for HASH hardware") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Reviewed-by: Linus Walleij Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/ux500/hash/hash_core.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index 3d407eebb2ba..1e2daf403032 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c @@ -1009,6 +1009,7 @@ static int hash_hw_final(struct ahash_request *req) goto out; } } else if (req->nbytes == 0 && ctx->keylen > 0) { + ret = -EPERM; dev_err(device_data->dev, "%s: Empty message with keylength > 0, NOT supported\n", __func__); goto out;