| Message ID | 20210623151753.191481-3-axboe@kernel.dk |
|---|---|
| State | Accepted |
| Commit | 22634bc5620d29765e5199c7b230a372c7ddcda2 |
| Headers | show |
| Series | [1/2] io_uring: add IOPOLL and reserved field checks to IORING_OP_RENAMEAT | expand |
diff --git a/fs/io_uring.c b/fs/io_uring.c index 9b6c7dad0b73..45c606846303 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -3504,6 +3504,10 @@ static int io_unlinkat_prep(struct io_kiocb *req, struct io_unlink *un = &req->unlink; const char __user *fname; + if (unlikely(req->ctx->flags & IORING_SETUP_IOPOLL)) + return -EINVAL; + if (sqe->ioprio || sqe->off || sqe->len || sqe->buf_index) + return -EINVAL; if (unlikely(req->flags & REQ_F_FIXED_FILE)) return -EBADF;
We can't support IOPOLL with non-pollable request types, and we should check for unused/reserved fields like we do for other request types. Fixes: 14a1143b68ee ("io_uring: add support for IORING_OP_UNLINKAT") Cc: stable@vger.kernel.org Reported-by: Dmitry Kadashev <dkadashev@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> --- fs/io_uring.c | 4 ++++ 1 file changed, 4 insertions(+)