From patchwork Thu May 20 09:22:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 443226 Delivered-To: patch@linaro.org Received: by 2002:a02:7a1b:0:0:0:0:0 with SMTP id a27csp2192110jac; Thu, 20 May 2021 04:18:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycJWCLQ1fu+A7trEg3GKgYsSxbyFCoST6rHZLt4XVBkJHmJEZ8/s5Ewos3YAg/GC6YKg3O X-Received: by 2002:a02:95a8:: with SMTP id b37mr2984799jai.125.1621509532249; Thu, 20 May 2021 04:18:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621509532; cv=none; d=google.com; s=arc-20160816; b=u8pHrkXJMtYlCphTHJ5X8alt0QiOTaUgUQw5LwwtqJ/1oiJ5eQ3QrCV2YISzrWV8z3 eq6SFmfPVTNBkU1PhCcXRvz973n+gmfBB23tO0mK2NSiE+H0h++H8HvM7iKjIeRKQ3ym nIaIz5qxeeSHBnb0itLj/y4+Sbr1TLHnyWPmCPC7ODOhZRzVIlkUmm0uZBD+J/bdNQ+x mpg5GLW0vQukkYf1QIOnGAaNfgm1tJ/Hpk64H7hp5lRq99dL8mWs2Q4CTx+f1uMUD5uQ UeVERlgwyC9WtslZeldC0Yf/6KexRfkZYhuPrBzQgeoXQ74R/B/U394H71v2nlPT5Jf6 e+Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hRAVn2GgSK4/IPPyoq4XNbCuci23rBl6ZEznt+wJzrc=; b=Cz6XVMh7kwDk/oqfcJHndiAJEXa5cWJ2fbvvaU074sj77qa5DUy98WdwSbbYwTvNon KHf9VCxyFReMyur5/Bju464D4datVpMhu1UUU5Ttvhrt8atJSo5pzfVLXNYxHCuFp4M2 W7n6shMwObOr0QiRaxUPRmOkEJRegKcaY/D0ko4km8jGDDJAj3dxOz6/RMKrEVmyqCNT vGl9o3a0Ko6AIvjYr1UxqVwtEOBx4fe5Uk8udgo5gJLv4G/lG1Fv/S2xMEOGtI8lN5Ei bKMvqJ+JPEWkwT/vW6ctG29zc9flgiIqqMLarLgi202sQ4mW1vzgTnIcmZJmop1FsoBn f/Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IJ+634vX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si2198666ilr.135.2021.05.20.04.18.52; Thu, 20 May 2021 04:18:52 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IJ+634vX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238912AbhETLUG (ORCPT + 12 others); Thu, 20 May 2021 07:20:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:37898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239844AbhETLRE (ORCPT ); Thu, 20 May 2021 07:17:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C68146194D; Thu, 20 May 2021 10:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621505373; bh=aqSnn32DClRk/sKgfHKM1/7v4s/2EXYqYOp9LYOrsQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IJ+634vXMX4v8M5y1g12c1+FjucCnHVqkVG00V/zr6wIj+bWLvlHcNoipj0b26ImI Zej/sCx7jLQI1r27X4Js4+oglxSGF1xAidYRsvzY+we/wqi1HBdPNiKCJcX7IQHDMl iGpfQPsqcIDWp6+J+dEOzccdOtosAzOmRIFmNvFE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 104/190] scsi: fcoe: Fix mismatched fcoe_wwn_from_mac declaration Date: Thu, 20 May 2021 11:22:48 +0200 Message-Id: <20210520092105.633546421@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092102.149300807@linuxfoundation.org> References: <20210520092102.149300807@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 5b11c9d80bde81f6896cc85b23aeaa9502a704ed ] An old cleanup changed the array size from MAX_ADDR_LEN to unspecified in the declaration, but now gcc-11 warns about this: drivers/scsi/fcoe/fcoe_ctlr.c:1972:37: error: argument 1 of type ‘unsigned char[32]’ with mismatched bound [-Werror=array-parameter=] 1972 | u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN], | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ In file included from /git/arm-soc/drivers/scsi/fcoe/fcoe_ctlr.c:33: include/scsi/libfcoe.h:252:37: note: previously declared as ‘unsigned char[]’ 252 | u64 fcoe_wwn_from_mac(unsigned char mac[], unsigned int, unsigned int); | ~~~~~~~~~~~~~~^~~~~ Change the type back to what the function definition uses. Link: https://lore.kernel.org/r/20210322164702.957810-1-arnd@kernel.org Fixes: fdd78027fd47 ("[SCSI] fcoe: cleans up libfcoe.h and adds fcoe.h for fcoe module") Signed-off-by: Arnd Bergmann Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- include/scsi/libfcoe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/include/scsi/libfcoe.h b/include/scsi/libfcoe.h index e59180264591..004bf0ca8884 100644 --- a/include/scsi/libfcoe.h +++ b/include/scsi/libfcoe.h @@ -256,7 +256,7 @@ int fcoe_ctlr_recv_flogi(struct fcoe_ctlr *, struct fc_lport *, struct fc_frame *); /* libfcoe funcs */ -u64 fcoe_wwn_from_mac(unsigned char mac[], unsigned int, unsigned int); +u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN], unsigned int, unsigned int); int fcoe_libfc_config(struct fc_lport *, struct fcoe_ctlr *, const struct libfc_function_template *, int init_fcp); u32 fcoe_fc_crc(struct fc_frame *fp);